From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C81DCC433ED for ; Wed, 28 Apr 2021 16:51:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94DCC61400 for ; Wed, 28 Apr 2021 16:51:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241372AbhD1QwH (ORCPT ); Wed, 28 Apr 2021 12:52:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241345AbhD1Qv6 (ORCPT ); Wed, 28 Apr 2021 12:51:58 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41524C06138B for ; Wed, 28 Apr 2021 09:51:13 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id d19so28522608qkk.12 for ; Wed, 28 Apr 2021 09:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rrj3UlBlJ91qMWs4IlTPGuw8X2L/oNKhyyRLTCh8fWE=; b=lf++hd/X6bQjKPClgG4WlPiLlx0SEPhHDHsu8w5ZyHb/uz+XduZNY+A0zluRDDQxjc L2fOBYoKdVMfh8CB6Dxs6hGNXdaO+l98nAg/bwFcadAUV1wPG3qXuF3ERBWSvSCt0Zrg UiDRc/2MnqpGGBT99Roig9k+c6ycmYY0gP8j8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rrj3UlBlJ91qMWs4IlTPGuw8X2L/oNKhyyRLTCh8fWE=; b=f+djNYrQiLe9W87eXTxktV4GQNyPxbW4dX0RZyUDoqOXyeqLpUCDN5EoyoabtRX/Y3 vkKNCQBHqs2fOjcrdg6gwcMojVsoiqWa8b4JOAl9lklnlCnOG3wB4cguMZxwsME/wX55 PpqIy4xYV+B86PB7dPOgRIoQ7JH2x96bguzsnUCQ1j7K1jYrWmfb5PeB+l31rd48eihx xSteE4ZePkoF76EFyQnkSTiJYdxrx4z4SnvwDdnPjMuhArOoZIFT1oJEhkRsMZiavN2i b85qVLoa0Chu4W/hwrwcTBAYjqnLt3u1ulk5YUgGZjax2CR2u1/A78j5Sit9DzUUj0dr vipQ== X-Gm-Message-State: AOAM532J4PYhrr40FW/dhEJea31xYkhOKEg+KAr8XcrwgXNCbVr23QtE jfof8yoE7QaHSXaxKFt7DMoBBh36AiD1vQ== X-Google-Smtp-Source: ABdhPJxM8l++oSbSVILDldmxxwuHN9fEU+ahJXo1E/xZCDu+w0NwvvxAHvbt4xQFniOfMcTUP3KeSA== X-Received: by 2002:a05:620a:2ee:: with SMTP id a14mr25212172qko.229.1619628672323; Wed, 28 Apr 2021 09:51:12 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id g185sm192073qkf.62.2021.04.28.09.51.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 09:51:12 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id q192so21096349ybg.4 for ; Wed, 28 Apr 2021 09:51:12 -0700 (PDT) X-Received: by 2002:a25:7157:: with SMTP id m84mr42521872ybc.175.1619628324558; Wed, 28 Apr 2021 09:45:24 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.17.Ibd31b8f7c73255d68c5c9f5b611b4bfaa036f727@changeid> In-Reply-To: <20210423095743.v5.17.Ibd31b8f7c73255d68c5c9f5b611b4bfaa036f727@changeid> From: Sean Paul Date: Wed, 28 Apr 2021 12:44:45 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 17/20] drm/panel: panel-simple: Power the panel when reading the EDID To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , robdclark@chromium.org, dri-devel , David Airlie , linux-arm-msm , Steev Klimaszewski , Stephen Boyd , Stanislav Lisovskiy , Thierry Reding , linux-i2c@vger.kernel.org, Bjorn Andersson , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 1:00 PM Douglas Anderson wrote: > > I don't believe that it ever makes sense to read the EDID when a panel > is not powered and the powering on of the panel is the job of > prepare(). Let's make sure that this happens before we try to read the > EDID. We use the pm_runtime functions directly rather than directly > calling the normal prepare() function because the pm_runtime functions > are definitely refcounted whereas it's less clear if the prepare() one > is. > > NOTE: I'm not 100% sure how EDID reading was working for folks in the > past, but I can only assume that it was failing on the initial attempt > and then working only later. This patch, presumably, will fix that. If > some panel out there really can read the EDID without powering up and > it's a big advantage to preserve the old behavior we can add a > per-panel flag. It appears that providing the DDC bus to the panel in > the past was somewhat uncommon in any case. > Maybe some combination of drivers caching the EDID for panels while they're already powered and overly broad pm runtime references? At any rate, this makes sense to me, Reviewed-by: Sean Paul > Signed-off-by: Douglas Anderson > Reviewed-by: Bjorn Andersson > --- > > (no changes since v1) > > drivers/gpu/drm/panel/panel-simple.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 4de33c929a59..a12dfe8b8d90 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -510,12 +510,18 @@ static int panel_simple_get_modes(struct drm_panel *panel, > > /* probe EDID if a DDC bus is available */ > if (p->ddc) { > - struct edid *edid = drm_get_edid(connector, p->ddc); > + struct edid *edid; > > + pm_runtime_get_sync(panel->dev); > + > + edid = drm_get_edid(connector, p->ddc); > if (edid) { > num += drm_add_edid_modes(connector, edid); > kfree(edid); > } > + > + pm_runtime_mark_last_busy(panel->dev); > + pm_runtime_put_autosuspend(panel->dev); > } > > /* add hard-coded panel modes */ > -- > 2.31.1.498.g6c1eba8ee3d-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel