From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A994C43457 for ; Sun, 18 Oct 2020 19:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26575206ED for ; Sun, 18 Oct 2020 19:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="VMvrkPOj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733178AbgJRToO (ORCPT ); Sun, 18 Oct 2020 15:44:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730269AbgJRTnz (ORCPT ); Sun, 18 Oct 2020 15:43:55 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B6A0C061755 for ; Sun, 18 Oct 2020 12:43:55 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id l16so8262103ilt.13 for ; Sun, 18 Oct 2020 12:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pWenhFesr1w3jNOrHoKxpIn7aIFwj8qNewUZEqgfPdM=; b=VMvrkPOjHLlUI4sI2rGOGrISxzwGTODFlquH0zCr68cYhcIzYg/MHdPtegAja3vzVw Lu+TAn7km0+xlnYQyM1xJS8hq3q73WvmTpICDR4AwTamcnLbCwvquMZ3KbGvgusTKw2Q 2qpBvGIjMWb6GtF5HJUNqK1yUBBNMA+GcEjKn7WNoFbNz0405900KcycpwxBG10xc/gH lMd/6ncCX7lUP61gfFhdD+FeqB7kKrIbRx2WjIOjl0K13gCaOn9cXTW+xhlzRLXS/4Uo BYns0JcvGifKCUYamerAe//rCV6IKDoi8F0IgF1UALU+6FIQpd5d2TarzYtWPAi/CIf5 ve6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pWenhFesr1w3jNOrHoKxpIn7aIFwj8qNewUZEqgfPdM=; b=r4AdnZmzH0rbtTPQgShVJxWK3sT4MVW5kGXlC5ckgro7U3f2bQaV0LwS3n+c1wpTvj XPtHq2v/Gu46Mz6y5Ou8WCfy9TSqj+MZl/d6UUpdy8r6t3j/OUGPeSQe86doMiXxfpAM Z9G4jlo355JUK6Nd38XrKo+7lSDJgfM5Mx7TIJbyIL+x1rK8QSOj25+2CJw9DikgMwqr 0F1k/WNAz+nELrd0x2xmKwAHqdUad/yPp2+iZ8zoeJLtmUMKnf5L40pF3aqpRaPkFKXi M2X0ztV8PTA5RMriD7/WlLuisYRFijBAD6httWt0obmx3BHGpeL1E/HF0xMZL1yhoGP/ vhlw== X-Gm-Message-State: AOAM530PhWUCdQStUe2oqN8FuRvYA68va1s0JPToCwzWjxyH1uzBEOy7 pLKw9aHIqd66D0vdtM1V8VtGcOM9MPy0uizXPH1L6w== X-Google-Smtp-Source: ABdhPJzVCY4CXlJo5Yk7DLu6Jm6h8fkfHziS90cktjXSQwP51sBX0o/6i7dgEM8BHuTRh478qb6FII0oYpE820vpB5c= X-Received: by 2002:a92:c5af:: with SMTP id r15mr8834836ilt.88.1603050234668; Sun, 18 Oct 2020 12:43:54 -0700 (PDT) MIME-Version: 1.0 References: <20201018171545.3190476-1-fparent@baylibre.com> In-Reply-To: From: Fabien Parent Date: Sun, 18 Oct 2020 21:43:43 +0200 Message-ID: Subject: Re: [PATCH v2] iio: adc: mediatek: fix unset field To: Andy Shevchenko Cc: Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , linux-arm Mailing List , linux-iio , Matthias Brugger , Jonathan Cameron , chun-hung.wu@mediatek.com, Alexandru Ardelean , Peter Meerwald , Lars-Peter Clausen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy On Sun, Oct 18, 2020 at 8:33 PM Andy Shevchenko wrote: > > On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko > wrote: > > > > On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent wrote: > > > > > > dev_comp field is used in a couple of places but it is never set. This > > > results in kernel oops when dereferencing a NULL pointer. Set the > > > `dev_comp` field correctly in the probe function. > > > > > > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support") > > > > > > Signed-off-by: Fabien Parent > > > > Shouldn't be a blank line in the tag block. > > > > I think Jonathan can fix it, but be more careful in the future. > > One more serious issue, you forgot to add tags you have gotten in the > previous round. Thanks for the review. I will make it easy for the maintainer and send right away a v3 that fixes both issues you pointed out. > -- > With Best Regards, > Andy Shevchenko