linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: youling 257 <youling257@gmail.com>
To: Michel Lespinasse <walken@google.com>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Daniel Jordan <daniel.m.jordan@oracle.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Hugh Dickins <hughd@google.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	Jerome Glisse <jglisse@redhat.com>,
	John Hubbard <jhubbard@nvidia.com>,
	Laurent Dufour <ldufour@linux.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Peter Zijlstra <peterz@infradead.org>,
	David Rientjes <rientjes@google.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	Ying Han <yinghan@google.com>
Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock
Date: Thu, 4 Jun 2020 16:06:46 +0800	[thread overview]
Message-ID: <CAOzgRdaDkYNGNgfNbEnANUiRLnR7s+-He1H0jABGOAe6h4YSaQ@mail.gmail.com> (raw)
In-Reply-To: <CANN689Gy2aUgF7oE2UE3miHf7fah=9zM3KZ512Mj6kJTiRz3Xg@mail.gmail.com>

i build linux next kernel have the kernel/sys.c error.

2020-06-04 13:57 GMT+08:00, Michel Lespinasse <walken@google.com>:
> On Wed, Jun 3, 2020 at 9:35 PM youling 257 <youling257@gmail.com> wrote:
>> I have build error about kernel/sys.c,
>>
>> kernel/sys.c: In function ‘prctl_set_vma’:
>> kernel/sys.c:2392:18: error:
>> ‘struct mm_struct’ has no member named ‘mmap_sem’; did you mean
>> ‘mmap_base’?
>>   2392 |  down_write(&mm->mmap_sem);
>>        |                  ^~~~~~~~
>>        |                  mmap_base
>> kernel/sys.c:2402:16: error:
>> ‘struct mm_struct’ has no member named ‘mmap_sem’; did you mean
>> ‘mmap_base’?
>>   2402 |  up_write(&mm->mmap_sem);
>>        |                ^~~~~~~~
>>        |                mmap_base
>>
>> why not rename kernel/sys.c mmap_sem to mmap_lock?
>
> The proper fix would be to use the mmap locking apis defined in
> include/linux/mmap_lock.h instead.
>
> However I would like more information about your report. Did you apply
> the series yourself ? If so, what base tree did you apply it onto ? If
> not, what tree did you use that already included the series ?
>
> Thanks,
>
> --
> Michel "Walken" Lespinasse
> A program is never fully debugged until the last user dies.
>

  reply	other threads:[~2020-06-04  8:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  4:35 [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock youling 257
2020-06-04  5:57 ` Michel Lespinasse
2020-06-04  8:06   ` youling 257 [this message]
2020-06-04  8:16   ` youling 257
2020-06-04  8:38     ` Michel Lespinasse
2020-06-13  4:44       ` youling 257
  -- strict thread matches above, loose matches on Subject: below --
2020-05-20  5:28 [PATCH v6 00/12] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-05-20  5:29 ` [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-05-22 14:16   ` Davidlohr Bueso
2020-05-29 20:42   ` Daniel Jordan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOzgRdaDkYNGNgfNbEnANUiRLnR7s+-He1H0jABGOAe6h4YSaQ@mail.gmail.com \
    --to=youling257@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.m.jordan@oracle.com \
    --cc=dave@stgolabs.net \
    --cc=hughd@google.com \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=walken@google.com \
    --cc=willy@infradead.org \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).