From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
To: Chen Yu <yu.c.chen@intel.com>
Cc: Doug Smythies <dsmythies@telus.net>,
Bingsong Si <owen.si@ucloud.cn>,
youling257 <youling257@gmail.com>,
erwanaliasr1@gmail.com, lenb@kernel.org, rjw@rjwysocki.net,
LKML <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Zhang Rui <rui.zhang@intel.com>
Subject: Re: [3/3,v3] tools/power turbostat: Enable accumulate RAPL display
Date: Sat, 24 Apr 2021 12:50:30 +0200 [thread overview]
Message-ID: <CAP+8YyE2KKgrxF+RV_iYao8Hc5vSjXiRPZ39WzL6Yj2qZ3QL8w@mail.gmail.com> (raw)
In-Reply-To: <20210424014343.GA432544@chenyu-desktop>
(apologies for resend, seems my client switched to HTML before)
On Sat, Apr 24, 2021 at 3:40 AM Chen Yu <yu.c.chen@intel.com> wrote:
>
> Hi Bas Nieuwenhuizen,
> On Fri, Mar 12, 2021 at 09:41:14PM +0800, Chen Yu wrote:
> > Hi Youling, Bas, and Bingsong,
> > On Wed, Mar 10, 2021 at 04:03:31PM -0800, Doug Smythies wrote:
> > > Hi Yu,
> > >
> > > I am just resending your e-mail, adjusting the "To:" list to
> > > include the 3 others that have submitted similar patches.
> > >
> > > ... Doug
> > >
> > Could you please help check if the following combined patch works?
> >
> > Thanks,
> > Chenyu
> >
> >
> > From 00e0622b1b693a5c7dc343aeb3aa51614a9e125e Mon Sep 17 00:00:00 2001
> > From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
> > Date: Fri, 12 Mar 2021 21:27:40 +0800
> > Subject: [PATCH] tools/power/turbostat: Fix turbostat for AMD Zen CPUs
> >
> > It was reported that on Zen+ system turbostat started exiting,
> > which was tracked down to the MSR_PKG_ENERGY_STAT read failing because
> > offset_to_idx wasn't returning a non-negative index.
> >
> > This patch combined the modification from Bingsong Si and
> > Bas Nieuwenhuizen and addd the MSR to the index system as alternative for
> > MSR_PKG_ENERGY_STATUS.
> >
> > Fixes: 9972d5d84d76 ("tools/power turbostat: Enable accumulate RAPL display")
> > Reported-by: youling257 <youling257@gmail.com>
> > Co-developed-by: Bingsong Si <owen.si@ucloud.cn>
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> >
> Can I add your SOB here if you are not object to it?
Yes, seems fine by me. Thanks!
>
> thanks,
> Chenyu
prev parent reply other threads:[~2021-04-24 10:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 8:31 [PATCH 0/3][v3] tools/power turbostat: Enable accumulated energy consumption for long time sampling Chen Yu
2020-04-18 8:31 ` [PATCH 1/3][v3] tools/power turbostat: Make the energy variable to be 64 bit Chen Yu
2020-04-18 8:31 ` [PATCH 2/3][v3] tools/power turbostat: Introduce functions to accumulate RAPL consumption Chen Yu
2020-04-18 8:32 ` [PATCH 3/3][v3] tools/power turbostat: Enable accumulate RAPL display Chen Yu
2021-03-08 13:49 ` [3/3,v3] " youling257
2021-03-08 15:37 ` Doug Smythies
2021-03-08 16:15 ` Chen Yu
2021-03-11 0:03 ` Doug Smythies
2021-03-12 12:17 ` Chen Yu
2021-03-12 13:41 ` Chen Yu
2021-03-13 13:49 ` youling 257
2021-03-24 14:44 ` Doug Smythies
2021-03-24 15:55 ` Christian Kastner
2021-03-25 12:12 ` Kurt Garloff
2021-03-26 2:14 ` sibingsong
2021-04-24 1:43 ` Chen Yu
2021-04-24 10:50 ` Bas Nieuwenhuizen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP+8YyE2KKgrxF+RV_iYao8Hc5vSjXiRPZ39WzL6Yj2qZ3QL8w@mail.gmail.com \
--to=bas@basnieuwenhuizen.nl \
--cc=dsmythies@telus.net \
--cc=erwanaliasr1@gmail.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=owen.si@ucloud.cn \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=youling257@gmail.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).