linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Sandipan Das <sandipan.das@amd.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	namhyung@kernel.org,  mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	 adrian.hunter@intel.com, eranian@google.com,
	ravi.bangoria@amd.com,  ananth.narayan@amd.com
Subject: Re: [PATCH 2/4] perf vendor events amd: Add Zen 5 uncore events
Date: Mon, 11 Mar 2024 10:43:35 -0700	[thread overview]
Message-ID: <CAP-5=fU=gO49ASVVLUbT5bFPoOE3qi3+xJqvRD3tA=upVUT_aQ@mail.gmail.com> (raw)
In-Reply-To: <e100c902fd9e1e4f58e3a9c175d572962a9cdd50.1710133771.git.sandipan.das@amd.com>

On Sun, Mar 10, 2024 at 10:24 PM Sandipan Das <sandipan.das@amd.com> wrote:
>
> Add uncore events taken from Section 1.5 "L3 Cache Performance Monitor
> Counters" and Section 2 "UMC Performance Monitors" of the Performance
> Monitor Counters for AMD Family 1Ah Model 00h-0Fh Processors document
> available at the link below. This constitutes events which capture L3
> cache and UMC command activity.

Why do the L3 uncore PMU events go in the same topic as the core/cpu
events, but the memory controller events not? Could they both go in
separate files to make better use of the topic?

Thanks,
Ian

> Link: https://bugzilla.kernel.org/attachment.cgi?id=305974
> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> ---
>  .../pmu-events/arch/x86/amdzen5/cache.json    | 175 ++++++++++++++++++
>  .../arch/x86/amdzen5/memory-controller.json   | 101 ++++++++++

[ ... snip ... ]

  reply	other threads:[~2024-03-11 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11  5:23 [PATCH 0/4] perf vendor events amd: Add Zen 5 events and metrics Sandipan Das
2024-03-11  5:23 ` [PATCH 1/4] perf vendor events amd: Add Zen 5 core events Sandipan Das
2024-03-11 17:40   ` Ian Rogers
2024-03-12  9:59     ` Sandipan Das
2024-03-11  5:23 ` [PATCH 2/4] perf vendor events amd: Add Zen 5 uncore events Sandipan Das
2024-03-11 17:43   ` Ian Rogers [this message]
2024-03-12 10:02     ` Sandipan Das
2024-03-11  5:23 ` [PATCH 3/4] perf vendor events amd: Add Zen 5 metrics Sandipan Das
2024-03-11 18:46   ` Ian Rogers
2024-03-12 10:32     ` Sandipan Das
2024-03-11  5:23 ` [PATCH 4/4] perf vendor events amd: Add Zen 5 mapping Sandipan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-5=fU=gO49ASVVLUbT5bFPoOE3qi3+xJqvRD3tA=upVUT_aQ@mail.gmail.com' \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ananth.narayan@amd.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sandipan.das@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).