From: Ian Rogers <irogers@google.com>
To: John Garry <john.garry@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Kajol Jain <kjain@linux.ibm.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Kim Phillips <kim.phillips@amd.com>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf jevents: Silence warning for ArchStd files
Date: Fri, 7 May 2021 08:46:19 -0700 [thread overview]
Message-ID: <CAP-5=fUGRU+vi5NfYLBV9dXgZcG0WY45srsi3Q75T7pPLBLnMQ@mail.gmail.com> (raw)
In-Reply-To: <4f9a4f20-82ac-dd68-4aee-b560396755f2@huawei.com>
On Fri, May 7, 2021 at 2:00 AM John Garry <john.garry@huawei.com> wrote:
>
> On 06/05/2021 23:56, Ian Rogers wrote:
> > json files in the level 1 directory are used for ArchStd events (see
> > preprocess_arch_std_files), as such they shouldn't be warned about.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/pmu-events/jevents.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> > index ed4f0bd72e5a..7422b0ea8790 100644
> > --- a/tools/perf/pmu-events/jevents.c
> > +++ b/tools/perf/pmu-events/jevents.c
> > @@ -1123,8 +1123,10 @@ static int process_one_file(const char *fpath, const struct stat *sb,
> > mapfile = strdup(fpath);
> > return 0;
> > }
> > -
> > - pr_info("%s: Ignoring file %s\n", prog, fpath);
> > + if (is_json_file(bname))
> > + pr_debug("%s: ArchStd json is preprocessed %s\n", prog, fpath)
> We could get more elaborate and add the same first debug print in
> process_one_file() to preprocess_arch_std_file() to give the allusion
> that they are preprocessed, and change the logic not print that for arch
> std files (in process_one_file()). But not sure it's worth it.
>
> Or else we could also just omit any print here for archstd files here.
I thought about just dropping the print in the json case but then a
comment would be nice, the pr_debug is a comment and is somewhat
intention revealing. If you think it is overkill then it is ok to
change.
Thanks,
Ian
> But I suppose what you are doing is ok...
>
> Thanks,
> John
>
> > + else
> > + pr_info("%s: Ignoring file %s\n", prog, fpath);
> > return 0;
> > }
> >
> >
>
next prev parent reply other threads:[~2021-05-07 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 22:56 [PATCH] perf jevents: Silence warning for ArchStd files Ian Rogers
2021-05-07 8:59 ` John Garry
2021-05-07 15:46 ` Ian Rogers [this message]
2021-05-07 16:29 ` John Garry
2021-05-08 14:24 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fUGRU+vi5NfYLBV9dXgZcG0WY45srsi3Q75T7pPLBLnMQ@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).