From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D6B2C433DF for ; Tue, 2 Jun 2020 20:31:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D0FF206E2 for ; Tue, 2 Jun 2020 20:31:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sDdwGkN1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728090AbgFBUa7 (ORCPT ); Tue, 2 Jun 2020 16:30:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgFBUa6 (ORCPT ); Tue, 2 Jun 2020 16:30:58 -0400 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B744CC08C5C0 for ; Tue, 2 Jun 2020 13:30:58 -0700 (PDT) Received: by mail-yb1-xb42.google.com with SMTP id j8so7688427ybj.12 for ; Tue, 02 Jun 2020 13:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dG2W30ikv7IrUlDO3uoRpNzwGtub0ifXIazr40I7HqQ=; b=sDdwGkN1aw+rFG87Zy/vBPI61YaYEMyJpvOrSu4Wod1Q79GO3E5FqvelR+/3Ud8IyU y2QEE9JQ8Pacn4MKRA7VRnmAAurkthXh5tLyRsqFIQSCfuVK0VWJZJb0MSF4v5XaA//8 gpIvEuyGePst/EVnG9jXgQluwhXZ8Ik/Vz7s7sKXR3Qc/IZHFyzkT9j77InsukBy5eC8 hsUsUjRG2hUBl4btt8uFZr+gCB2PO2Ilf5UUjNobN4xFu46HmtEfXzzNMDX+CSHFY6oR b1vh/Iacn4Xnb/BwSlFDZokXltbO9xRhG9j371UfY0/bVcshkR+q6oOLfbp+07UGqHGt J7dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dG2W30ikv7IrUlDO3uoRpNzwGtub0ifXIazr40I7HqQ=; b=acd6j/0Axp0lw3q8xva/Sgb2MFF0dUxeQAzIWuTO+3aaeRQb4giWZD70thO1k/t8KC TWb3WrwV70INtjaVs38u3Ek0iOcsU6WzYHByQYnTI8XAakRQzKz4MOef37DopPEr5+Lf GlVsD2PugnrHnu595rJn+9iw4HoOalBUHcuVKI8vU9YttlKpLMILRqGCCTOhMEhTiXQu tiNu8tsdue2Uwc2iCjxg3YmcoUsYn+i5M/uP4PAFN6s8GgalgqjOev6pdHuYhfdPRqMz xLuhaOILhVeDU6FXFmAjgG6/Pq4LXTUr1rq8YGgatGC6grED7utbWOOqTdaQmudopL2W Q2IA== X-Gm-Message-State: AOAM533ryjPeuiAIkAZ68QE0ZzMXiOyS1LXXpnDDO4qi8m/OxpPf6YAd k9NlXmdkaqUhsjIBb9Ws6now0adUXT6Sa7s8+2doeA== X-Google-Smtp-Source: ABdhPJz5r8XzDs6ct4fU0Wz5IOgXddNtGgB0aDw/R1jZjBJfR6vXAvlDsvp3+ZMXX+BDew2vwrIsnpnjI4WekMFGKi4= X-Received: by 2002:a25:be81:: with SMTP id i1mr44795639ybk.184.1591129857654; Tue, 02 Jun 2020 13:30:57 -0700 (PDT) MIME-Version: 1.0 References: <20200602115055.1168446-1-jolsa@kernel.org> <20200602115055.1168446-5-jolsa@kernel.org> <20200602190815.GH1169993@krava> In-Reply-To: <20200602190815.GH1169993@krava> From: Ian Rogers Date: Tue, 2 Jun 2020 13:30:46 -0700 Message-ID: Subject: Re: [PATCH 04/13] perf tests: Add another metric parsing test To: Jiri Olsa Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Stephane Eranian , Andi Kleen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 2, 2020 at 12:08 PM Jiri Olsa wrote: > > On Tue, Jun 02, 2020 at 10:58:32AM -0700, Ian Rogers wrote: > > SNIP > > > > +static int check_parse_fake(const char *id) > > > +{ > > > + struct parse_events_error error; > > > > nit: this reads funny as it isn't clear, without looking at > > check_parse_id, that error is zero initialized. > > right, how about something like below? Thanks, looks good! Ian > thanks, > jirka > > > --- > diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c > index d3343827eb4d..c745b6e13cbe 100644 > --- a/tools/perf/tests/pmu-events.c > +++ b/tools/perf/tests/pmu-events.c > @@ -403,7 +403,6 @@ static int check_parse_id(const char *id, struct parse_events_error *error, > evlist = evlist__new(); > if (!evlist) > return -ENOMEM; > - memset(error, 0, sizeof(*error)); > ret = parse_events(evlist, id, error, fake_pmu); > evlist__delete(evlist); > return ret; > @@ -411,7 +410,7 @@ static int check_parse_id(const char *id, struct parse_events_error *error, > > static int check_parse_cpu(const char *id, bool same_cpu, struct pmu_event *pe) > { > - struct parse_events_error error; > + struct parse_events_error error = { 0 }; > > int ret = check_parse_id(id, &error, false); > if (ret && same_cpu) { > @@ -433,7 +432,7 @@ static int check_parse_cpu(const char *id, bool same_cpu, struct pmu_event *pe) > > static int check_parse_fake(const char *id) > { > - struct parse_events_error error; > + struct parse_events_error error = { 0 }; > int ret = check_parse_id(id, &error, true); > > free(error.str); >