From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf/script: allow --symbol to accept hexadecimal addresses
Date: Thu, 2 Apr 2020 10:43:14 -0700 [thread overview]
Message-ID: <CAP-5=fUkOaP+xzWDQyxttHEx2pbPkZKMbP7-2Pvu4mYXJrnhug@mail.gmail.com> (raw)
In-Reply-To: <20200331191128.GL9917@kernel.org>
On Tue, Mar 31, 2020 at 12:11 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Wed, Mar 25, 2020 at 03:08:02PM -0700, Ian Rogers escreveu:
> > From: Stephane Eranian <eranian@google.com>
> >
> > This patch extends the perf script --symbols option to filter
> > on hexadecimal addresses in addition to symbol names. This makes
> > it easier to handle cases where symbols are aliased.
> >
> > With this patch, it is possible to mix and match symbols and hexadecimal
> > addresses using the --symbols option.
> >
> > $ perf script --symbols=noploop,0x4007a0
>
> Applied, can you please send a followup patch to the man page stating
> that this is supported?
Many thanks! I've sent:
https://lore.kernel.org/lkml/20200402174130.140319-1-irogers@google.com/T/#u
Ian
> Thanks,
>
> - Arnaldo
>
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > Signed-off-by: Stephane Eranian <eranian@google.com>
> > ---
> > tools/perf/util/event.c | 21 +++++++++++++++++----
> > 1 file changed, 17 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> > index c5447ff516a2..c978a73fe475 100644
> > --- a/tools/perf/util/event.c
> > +++ b/tools/perf/util/event.c
> > @@ -599,10 +599,23 @@ int machine__resolve(struct machine *machine, struct addr_location *al,
> > al->sym = map__find_symbol(al->map, al->addr);
> > }
> >
> > - if (symbol_conf.sym_list &&
> > - (!al->sym || !strlist__has_entry(symbol_conf.sym_list,
> > - al->sym->name))) {
> > - al->filtered |= (1 << HIST_FILTER__SYMBOL);
> > + if (symbol_conf.sym_list) {
> > + int ret = 0;
> > + char al_addr_str[32];
> > + size_t sz = sizeof(al_addr_str);
> > +
> > + if (al->sym) {
> > + ret = strlist__has_entry(symbol_conf.sym_list,
> > + al->sym->name);
> > + }
> > + if (!(ret && al->sym)) {
> > + snprintf(al_addr_str, sz, "0x%"PRIx64,
> > + al->map->unmap_ip(al->map, al->sym->start));
> > + ret = strlist__has_entry(symbol_conf.sym_list,
> > + al_addr_str);
> > + }
> > + if (!ret)
> > + al->filtered |= (1 << HIST_FILTER__SYMBOL);
> > }
> >
> > return 0;
> > --
> > 2.25.1.696.g5e7596f4ac-goog
> >
>
> --
>
> - Arnaldo
next prev parent reply other threads:[~2020-04-02 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 22:08 [PATCH] perf/script: allow --symbol to accept hexadecimal addresses Ian Rogers
2020-03-31 19:11 ` Arnaldo Carvalho de Melo
2020-04-02 17:43 ` Ian Rogers [this message]
2020-04-04 8:41 ` [tip: perf/urgent] perf script: Allow " tip-bot2 for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fUkOaP+xzWDQyxttHEx2pbPkZKMbP7-2Pvu4mYXJrnhug@mail.gmail.com' \
--to=irogers@google.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).