From: Ian Rogers <irogers@google.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 15/35] perf script: Add machine_pid and vcpu
Date: Tue, 19 Jul 2022 17:39:12 -0700 [thread overview]
Message-ID: <CAP-5=fVC0Vx+NWLW1NE4PuKLn0XHBG2MZhnTfLPZxhqE1To3jA@mail.gmail.com> (raw)
In-Reply-To: <20220711093218.10967-16-adrian.hunter@intel.com>
On Mon, Jul 11, 2022 at 2:33 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Add fields machine_pid and vcpu. These are displayed only if machine_pid is
> non-zero.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/Documentation/perf-script.txt | 7 ++++++-
> tools/perf/builtin-script.c | 11 +++++++++++
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
> index e250ff5566cf..c09cc44e50ee 100644
> --- a/tools/perf/Documentation/perf-script.txt
> +++ b/tools/perf/Documentation/perf-script.txt
> @@ -133,7 +133,8 @@ OPTIONS
> comm, tid, pid, time, cpu, event, trace, ip, sym, dso, addr, symoff,
> srcline, period, iregs, uregs, brstack, brstacksym, flags, bpf-output,
> brstackinsn, brstackinsnlen, brstackoff, callindent, insn, insnlen, synth,
> - phys_addr, metric, misc, srccode, ipc, data_page_size, code_page_size, ins_lat.
> + phys_addr, metric, misc, srccode, ipc, data_page_size, code_page_size, ins_lat,
> + machine_pid, vcpu.
> Field list can be prepended with the type, trace, sw or hw,
> to indicate to which event type the field list applies.
> e.g., -F sw:comm,tid,time,ip,sym and -F trace:time,cpu,trace
> @@ -226,6 +227,10 @@ OPTIONS
> The ipc (instructions per cycle) field is synthesized and may have a value when
> Instruction Trace decoding.
>
> + The machine_pid and vcpu fields are derived from data resulting from using
> + perf insert to insert a perf.data file recorded inside a virtual machine into
Presumably 'perf inject' ?
Thanks,
Ian
> + a perf.data file recorded on the host at the same time.
> +
> Finally, a user may not set fields to none for all event types.
> i.e., -F "" is not allowed.
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 4b00a50faf00..ac19fee62d8e 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -125,6 +125,8 @@ enum perf_output_field {
> PERF_OUTPUT_CODE_PAGE_SIZE = 1ULL << 34,
> PERF_OUTPUT_INS_LAT = 1ULL << 35,
> PERF_OUTPUT_BRSTACKINSNLEN = 1ULL << 36,
> + PERF_OUTPUT_MACHINE_PID = 1ULL << 37,
> + PERF_OUTPUT_VCPU = 1ULL << 38,
> };
>
> struct perf_script {
> @@ -193,6 +195,8 @@ struct output_option {
> {.str = "code_page_size", .field = PERF_OUTPUT_CODE_PAGE_SIZE},
> {.str = "ins_lat", .field = PERF_OUTPUT_INS_LAT},
> {.str = "brstackinsnlen", .field = PERF_OUTPUT_BRSTACKINSNLEN},
> + {.str = "machine_pid", .field = PERF_OUTPUT_MACHINE_PID},
> + {.str = "vcpu", .field = PERF_OUTPUT_VCPU},
> };
>
> enum {
> @@ -746,6 +750,13 @@ static int perf_sample__fprintf_start(struct perf_script *script,
> int printed = 0;
> char tstr[128];
>
> + if (PRINT_FIELD(MACHINE_PID) && sample->machine_pid)
> + printed += fprintf(fp, "VM:%5d ", sample->machine_pid);
> +
> + /* Print VCPU only for guest events i.e. with machine_pid */
> + if (PRINT_FIELD(VCPU) && sample->machine_pid)
> + printed += fprintf(fp, "VCPU:%03d ", sample->vcpu);
> +
> if (PRINT_FIELD(COMM)) {
> const char *comm = thread ? thread__comm_str(thread) : ":-1";
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-07-20 0:39 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 9:31 [PATCH 00/35] perf intel-pt: Add support for tracing virtual machine user space on the host Adrian Hunter
2022-07-11 9:31 ` [PATCH 01/35] perf tools: Fix dso_id inode generation comparison Adrian Hunter
2022-07-18 14:57 ` Arnaldo Carvalho de Melo
2022-07-19 10:18 ` Adrian Hunter
2022-07-19 15:13 ` Ian Rogers
2022-07-19 19:16 ` Arnaldo Carvalho de Melo
2022-07-11 9:31 ` [PATCH 02/35] perf tools: Export dsos__for_each_with_build_id() Adrian Hunter
2022-07-19 16:55 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 03/35] perf ordered_events: Add ordered_events__last_flush_time() Adrian Hunter
2022-07-19 16:56 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 04/35] perf tools: Export perf_event__process_finished_round() Adrian Hunter
2022-07-19 17:04 ` Ian Rogers
2022-08-09 11:37 ` Adrian Hunter
2022-07-11 9:31 ` [PATCH 05/35] perf tools: Factor out evsel__id_hdr_size() Adrian Hunter
2022-07-19 17:09 ` Ian Rogers
2022-08-09 11:49 ` Adrian Hunter
2022-08-09 17:07 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 06/35] perf tools: Add perf_event__synthesize_id_sample() Adrian Hunter
2022-07-19 17:10 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 07/35] perf script: Add --dump-unsorted-raw-trace option Adrian Hunter
2022-07-19 17:11 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 08/35] perf buildid-cache: Add guestmount'd files to the build ID cache Adrian Hunter
2022-07-19 17:41 ` Ian Rogers
2022-08-09 12:21 ` Adrian Hunter
2022-07-11 9:31 ` [PATCH 09/35] perf buildid-cache: Do not require purge files to also be in the file system Adrian Hunter
2022-07-19 17:44 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 10/35] perf tools: Add machine_pid and vcpu to id_index Adrian Hunter
2022-07-19 17:48 ` Ian Rogers
2022-08-09 12:19 ` Adrian Hunter
2022-07-11 9:31 ` [PATCH 11/35] perf session: Create guest machines from id_index Adrian Hunter
2022-07-19 17:51 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 12/35] perf tools: Add guest_cpu to hypervisor threads Adrian Hunter
2022-07-20 0:23 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 13/35] perf tools: Add machine_pid and vcpu to perf_sample Adrian Hunter
2022-07-20 0:36 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 14/35] perf tools: Use sample->machine_pid to find guest machine Adrian Hunter
2022-07-20 0:37 ` Ian Rogers
2022-07-11 9:31 ` [PATCH 15/35] perf script: Add machine_pid and vcpu Adrian Hunter
2022-07-20 0:39 ` Ian Rogers [this message]
2022-07-11 9:31 ` [PATCH 16/35] perf dlfilter: " Adrian Hunter
2022-07-20 0:42 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 17/35] perf auxtrace: Add machine_pid and vcpu to auxtrace_error Adrian Hunter
2022-07-20 0:43 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 18/35] perf script python: Add machine_pid and vcpu Adrian Hunter
2022-07-20 0:43 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 19/35] perf script python: intel-pt-events: " Adrian Hunter
2022-07-20 0:44 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 20/35] perf tools: Remove also guest kcore_dir with host kcore_dir Adrian Hunter
2022-07-20 0:45 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 21/35] perf tools: Make has_kcore_dir() work also for guest kcore_dir Adrian Hunter
2022-07-20 0:49 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 22/35] perf tools: Automatically use guest kcore_dir if present Adrian Hunter
2022-07-20 0:51 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 23/35] perf tools: Add reallocarray_as_needed() Adrian Hunter
2022-07-20 0:55 ` Ian Rogers
2022-08-09 16:48 ` Adrian Hunter
2022-07-11 9:32 ` [PATCH 24/35] perf inject: Add support for injecting guest sideband events Adrian Hunter
2022-07-20 1:06 ` Ian Rogers
2022-08-11 17:19 ` Adrian Hunter
2022-07-11 9:32 ` [PATCH 25/35] perf machine: Use realloc_array_as_needed() in machine__set_current_tid() Adrian Hunter
2022-07-11 9:32 ` [PATCH 26/35] perf tools: Handle injected guest kernel mmap event Adrian Hunter
2022-07-20 1:09 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 27/35] perf tools: Add perf_event__is_guest() Adrian Hunter
2022-07-20 1:11 ` Ian Rogers
2022-07-20 14:06 ` Arnaldo Carvalho de Melo
2022-07-20 14:56 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 28/35] perf intel-pt: Remove guest_machine_pid Adrian Hunter
2022-07-20 1:12 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 29/35] perf intel-pt: Add some more logging to intel_pt_walk_next_insn() Adrian Hunter
2022-07-20 1:13 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 30/35] perf intel-pt: Track guest context switches Adrian Hunter
2022-07-20 1:13 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 31/35] perf intel-pt: Disable sync switch with guest sideband Adrian Hunter
2022-07-20 1:14 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 32/35] perf intel-pt: Determine guest thread from " Adrian Hunter
2022-07-20 1:15 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 33/35] perf intel-pt: Add machine_pid and vcpu to auxtrace_error Adrian Hunter
2022-07-20 5:27 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 34/35] perf intel-pt: Use guest pid/tid etc in guest samples Adrian Hunter
2022-07-20 5:28 ` Ian Rogers
2022-07-11 9:32 ` [PATCH 35/35] perf intel-pt: Add documentation for tracing guest machine user space Adrian Hunter
2022-07-20 5:29 ` Ian Rogers
2022-07-18 15:28 ` [PATCH 00/35] perf intel-pt: Add support for tracing virtual machine user space on the host Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fVC0Vx+NWLW1NE4PuKLn0XHBG2MZhnTfLPZxhqE1To3jA@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).