From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] perf tools: Ignore Documentation dependency file
Date: Sun, 12 Sep 2021 09:21:51 -0700 [thread overview]
Message-ID: <CAP-5=fVQ7Y1XUmUx74D4ipX59yWGWAi62SdybsQT6OFhhPRr_w@mail.gmail.com> (raw)
In-Reply-To: <YTz8DL1Nuwp+XmzE@kernel.org>
On Sat, Sep 11, 2021 at 11:57 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Sat, Sep 11, 2021 at 03:37:20PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Sep 10, 2021 at 04:22:49PM -0700, Ian Rogers escreveu:
> > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> > > Fixes: a81df63a5df3 ("perf doc: Fix doc.dep")
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> >
> > Thanks for the patch, but you forgot to mention _why_ we should ignore
> > that file, I'll try to figure out.
>
> Added this, probably anodine, but better than nothing :-)
>
> ---
> When building directly on the checked out repository the build process
> produces a file that should be ignored, so add it to .gitignore.
> ---
Sounds good to me.
Thanks,
Ian
> - Arnaldo
> >
> > > ---
> > > tools/perf/.gitignore | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> > > index e555e9729758..8e0163b7ef01 100644
> > > --- a/tools/perf/.gitignore
> > > +++ b/tools/perf/.gitignore
> > > @@ -39,3 +39,4 @@ pmu-events/jevents
> > > feature/
> > > fixdep
> > > libtraceevent-dynamic-list
> > > +Documentation/doc.dep
> > > --
> > > 2.33.0.309.g3052b89438-goog
> >
> > --
> >
> > - Arnaldo
>
> --
>
> - Arnaldo
prev parent reply other threads:[~2021-09-12 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 23:22 [PATCH] perf tools: Ignore Documentation dependency file Ian Rogers
2021-09-11 18:37 ` Arnaldo Carvalho de Melo
2021-09-11 18:57 ` Arnaldo Carvalho de Melo
2021-09-12 16:21 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fVQ7Y1XUmUx74D4ipX59yWGWAi62SdybsQT6OFhhPRr_w@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).