From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E510CC32773 for ; Thu, 18 Aug 2022 16:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344601AbiHRQYX (ORCPT ); Thu, 18 Aug 2022 12:24:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344754AbiHRQX6 (ORCPT ); Thu, 18 Aug 2022 12:23:58 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2DF3C578F for ; Thu, 18 Aug 2022 09:21:23 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id u14so2294237wrq.9 for ; Thu, 18 Aug 2022 09:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=+GXISQvtaIcczS69+RKhoaC+BLvnMP0XhURL22EwPBU=; b=WHexSDDDQjVU9NY71f0bjUOuwxytNIer3Tv63ip49uSINYcJORiqINdb07+ix16PGN 5PTNc8T9hJVyDH2RBz+as8zwM86Low33SAwdhadn5Asd98HMnXqseX6qBMKS6dQXOoAa vT6Hb3DQv/tzL6xGVBpBT/n80onTny5H2Zlxs3yHwQjNdjdU9C9Nfqq834Ov3MYpTbiO XNtbNG8hsPIRN7xIE5HM3NpvkCiui38PbAj1aLUOCu+H6rh7bfyxAhQ4pEunBo90wawO WPSaXyYDe2ba+NXiUBFeQBqP+3eC7YvjoahD/Pzm2bVnbFwMWn0ijoCDtRR5SDdxq5Gu B/Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=+GXISQvtaIcczS69+RKhoaC+BLvnMP0XhURL22EwPBU=; b=hSWIHyAk18Y8W/txu9w3iKCD0p031i1z4Vkt/YvFZA3C/a731UKw1WaQuuKXIyoU3P ZXTehhl3dyz3sZrz0cC3133gGb3Tmlkkw7zLkVBxsTepwxTSHlB7fcW+2oTY0Hn1OnU2 MQQfRR28kylhzO3UVLez5KIywaXPSeO0BhABZAnHZEfgci0KSEwKjedNMLQTb5XDhbCf 4SMtQBGGwANgOyas0Jw+uolsdWflReZh/FMaoJz79YUkHPxN8KTE1R1WBvfaag7cXHB3 8s0TInJpeNcB2cSQNIVH5x+nCjbR6Ojqr2T+iQ/7M0PO9tUp+9MoI4hvpOWtqDoxeGPd b1BQ== X-Gm-Message-State: ACgBeo3qyL5cSgQUunAy2vhtsKUusjzGx42wm4Ba5Duba+DqkXGXPhmB +e0orUvLk151qCsqcXEayEe67kAun2YwqvoXcZvulg== X-Google-Smtp-Source: AA6agR5WiRUlNtYVxk55SwJWX8bStnebINMwUik3f8z7aHgP2E1PlCV+C4Trq6lf6Yo0nPXPOIntbx+RvWDS+Cb/vq0= X-Received: by 2002:a05:6000:1a87:b0:222:2c85:2f5b with SMTP id f7-20020a0560001a8700b002222c852f5bmr2110287wry.654.1660839664062; Thu, 18 Aug 2022 09:21:04 -0700 (PDT) MIME-Version: 1.0 References: <20220817053930.769840-1-irogers@google.com> <20220817053930.769840-7-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Thu, 18 Aug 2022 09:20:52 -0700 Message-ID: Subject: Re: [PATCH v1 6/6] perf build: Enable -Wthread-safety with clang To: Namhyung Kim Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Thomas Gleixner , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Nathan Chancellor , Nick Desaulniers , Tom Rix , Athira Rajeev , Weiguo Li , Pavithra Gurushankar , Thomas Richter , Ravi Bangoria , Dario Petrillo , Wenyu Liu , Hewenliang , yaowenbin , Dave Marchevsky , Andrii Nakryiko , Alexandre Truong , Kim Phillips , Leo Yan , Quentin Monnet , William Cohen , Andres Freund , Song Liu , Adrian Hunter , =?UTF-8?Q?Martin_Li=C5=A1ka?= , Colin Ian King , James Clark , Fangrui Song , Stephane Eranian , Kajol Jain , Andi Kleen , Alexey Bayduraev , Riccardo Mancini , Masami Hiramatsu , Christophe JAILLET , Zechuan Chen , Jason Wang , Lexi Shao , Remi Bernon , linux-kernel , linux-perf-users , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2022 at 8:59 AM Namhyung Kim wrote: > > On Thu, Aug 18, 2022 at 6:17 AM Ian Rogers wrote: > > > > On Wed, Aug 17, 2022, 11:11 PM Namhyung Kim wrote: > > > > > > Hi Ian, > > > > > > On Tue, Aug 16, 2022 at 10:39 PM Ian Rogers wrote: > > > > > > > > If building with clang then enable -Wthread-safety warnings. > > > > > > Do you know the minimal supported version for the option? > > > I'm not sure we have a check for that kind of thing. > > > > > > It has been supported for a long time, close to 10 years. Looking > > around it looks like clang 3.5 had the support. For context, BPF was > > supported after clang 3.7. Given this long support, and we don't > > version check for BPF, I think it is okay to assume the flag is > > supported. > > Good, thanks for checking it. It was a good point, thanks for the reminder! Ian