linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	linux-perf-users@vger.kernel.org,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf test hybrid failing on 14700K
Date: Fri, 19 Jan 2024 22:09:10 -0800	[thread overview]
Message-ID: <CAP-5=fWVQ-7ijjK3-w1q+k2WYVNHbAcejb-xY0ptbjRw476VKA@mail.gmail.com> (raw)
In-Reply-To: <ZYbm5L7tw7bdpDpE@kernel.org>

On Sat, Dec 23, 2023 at 5:55 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Hi Kan,
>
> I noticed the following problem, are you able to reproduce it?
>
> Happy solstice!
>
> - Arnaldo

Hi Arnaldo,

I'm seeing a test failure on Alderlake in perf-tools-next and wondered
if it was on your radar:
```
 32: Session topology                                                :
--- start ---
test child forked, pid 539222
templ file: /tmp/perf-test-HMet21
Using CPUID GenuineIntel-6-97-2
------------------------------------------------------------
perf_event_attr:
 type                             0 (PERF_TYPE_HARDWARE)
 config                           0x800000000
 disabled                         1
------------------------------------------------------------
sys_perf_event_open: pid 0  cpu -1  group_fd -1  flags 0x8 = 4
------------------------------------------------------------
perf_event_attr:
 type                             0 (PERF_TYPE_HARDWARE)
 config                           0x400000000
 disabled                         1
------------------------------------------------------------
sys_perf_event_open: pid 0  cpu -1  group_fd -1  flags 0x8 = 5
non matching sample_type
FAILED tests/topology.c:73 can't get session
test child finished with -1
---- end ----
Session topology: FAILED!
```

The code is hitting this line in evlist__valid_sample_type as
core.nr_entries is 2 on hybrid not 1:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/evlist.c?h=perf-tools-next#n1215
this causes perf_session__open to fail:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/session.c?h=perf-tools-next#n129

Thanks,
Ian

  parent reply	other threads:[~2024-01-20  6:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-23 13:55 perf test hybrid failing on 14700K Arnaldo Carvalho de Melo
2024-01-02 15:43 ` Liang, Kan
2024-01-02 22:41   ` Ian Rogers
2024-01-03 14:15     ` Liang, Kan
2024-01-03 16:31       ` Ian Rogers
2024-01-03 16:28     ` Arnaldo Carvalho de Melo
2024-01-05 12:05     ` Mark Rutland
2024-01-05 17:21       ` Ian Rogers
2024-01-09 16:37         ` Mark Rutland
2024-01-10 16:29           ` Ian Rogers
2024-01-15 11:00             ` Mark Rutland
2024-01-16 17:27               ` Mark Rutland
2024-01-20  6:09 ` Ian Rogers [this message]
2024-01-30 13:56   ` Arnaldo Carvalho de Melo
2024-01-30 14:02     ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-5=fWVQ-7ijjK3-w1q+k2WYVNHbAcejb-xY0ptbjRw476VKA@mail.gmail.com' \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).