From: Ian Rogers <irogers@google.com>
To: Rob Herring <robh@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libperf test: Silence printf flag warning
Date: Mon, 10 May 2021 09:33:33 -0700 [thread overview]
Message-ID: <CAP-5=fWfZXS57aQ2Sf+ycmDnvRpUf_oJfkv1sNzVdpY4PVcOdA@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLUxMOF_AhtDj7KuPmBzax-ZejSC76HNOOTr-Pq5fdj7Q@mail.gmail.com>
On Tue, May 4, 2021 at 6:53 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, May 4, 2021 at 2:43 PM Ian Rogers <irogers@google.com> wrote:
> >
> > __u64 maybe an unsigned long, it may also differ from the format
> > expected by PRIu64. Add a cast to silence the warning:
> >
> > tools/lib/perf/tests/test-evsel.c:176:33: error: format specifies type 'unsigned long long' but the argument has type 'unsigned long' [-Werror,-Wformat]
> > __T_VERBOSE("count = %llu\n", end - start);
> > ~~~~ ^~~~~~~~~~~
> > %lu
>
> Which arch/compiler did you hit this? LLVM? Would have been 64-bit
> presumably. I'm wondering how I didn't...
>
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/lib/perf/tests/test-evsel.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/lib/perf/tests/test-evsel.c b/tools/lib/perf/tests/test-evsel.c
> > index 288b5feaefe2..558097bbbfd0 100644
> > --- a/tools/lib/perf/tests/test-evsel.c
> > +++ b/tools/lib/perf/tests/test-evsel.c
> > @@ -173,7 +173,7 @@ static int test_stat_user_read(int event)
> >
> > __T("invalid counter data", (end - start) > last);
> > last = end - start;
> > - __T_VERBOSE("count = %llu\n", end - start);
> > + __T_VERBOSE("count = %llu\n", (unsigned long long)(end - start));
>
> I think I'd either change end/start to uint64_t which matches the
> count struct and use PRIu64, or change them to unsigned long long.
Thanks! I need to dig into this again, I suspect there was a problem
on PowerPC defining s64/u64 to be long int. Perhaps this is happening
by way of a typedef using int64_t but more likely defining
__SANE_USERSPACE_TYPES__ is my fix. The guidance in the kernel on
formatters is pretty clear:
https://www.kernel.org/doc/Documentation/printk-formats.txt
And so I think it is better to fix the type for overall sanity and to drop this.
Thanks,
Ian
> > }
> >
> > perf_evsel__munmap(evsel);
> > --
> > 2.31.1.607.g51e8a6a459-goog
> >
prev parent reply other threads:[~2021-05-10 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 19:43 [PATCH] libperf test: Silence printf flag warning Ian Rogers
2021-05-05 1:53 ` Rob Herring
2021-05-10 16:33 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fWfZXS57aQ2Sf+ycmDnvRpUf_oJfkv1sNzVdpY4PVcOdA@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).