linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Steven Rostedt <rostedt@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users <linux-perf-users@vger.kernel.org>,
	Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Remove traceevent from tools/lib
Date: Thu, 17 Nov 2022 09:59:46 -0800	[thread overview]
Message-ID: <CAP-5=fWxAjEia-Qbm0RVzKOxyiod8rUOBieqaGK=DtQboDe3Qw@mail.gmail.com> (raw)

Hi,

Arnaldo raised defaulting BUiLD_BPF_SKEL in the perf tool build:
https://lore.kernel.org/lkml/Y3Yy5DFEoCEBv%2FQi@kernel.org/

The recent build clean up:
https://lore.kernel.org/lkml/20221109184914.1357295-1-irogers@google.com/
https://lore.kernel.org/lkml/20221116224631.207631-1-irogers@google.com/

Means that perf is cleanly(ish) separated from libraries in tools/lib.
traceevent in tools/lib is out of date (~2years - version 1.1.0 whilst
the latest is 1.6.3 [1]) . Should we delete traceevent from tools/lib
and just make LIBTRACEEVENT_DYNAMIC the only supported perf build
option? I guess this may break old distributions that may not have
libtraceevent, but even so I'm not sure that should motivate not
cleaning this up (if they are building perf they can build
libtraceevent).

Thanks,
Ian

[1] https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/tree/Makefile

             reply	other threads:[~2022-11-17 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 17:59 Ian Rogers [this message]
2022-11-17 18:42 ` Remove traceevent from tools/lib Steven Rostedt
2022-11-17 22:52   ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-5=fWxAjEia-Qbm0RVzKOxyiod8rUOBieqaGK=DtQboDe3Qw@mail.gmail.com' \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).