From: Ian Rogers <irogers@google.com>
To: Nick Gasson <nick.gasson@arm.com>
Cc: Stephane Eranian <eranian@google.com>,
Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Subject: Re: [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent
Date: Thu, 14 May 2020 15:41:26 -0700 [thread overview]
Message-ID: <CAP-5=fX-dV+VHaPMO2Sw0DFB72YtuSyc23X5S3EvxGxYhAT4kQ@mail.gmail.com> (raw)
In-Reply-To: <20200514132337.GM5583@kernel.org>
On Thu, May 14, 2020 at 6:23 AM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Thu, May 14, 2020 at 04:56:07PM +0800, Nick Gasson escreveu:
> > On 04/27/20 18:35 pm, Jiri Olsa wrote:
> > >
> > > adding Stephane to the loop
>
> Stephane, Ian, can you guys please take a look at this one and provide a
> Reviewed-by or Acked-by?
>
> Thanks,
>
> - Arnaldo
>
>
> > > jirka
> > >
> > >>
> > >> These three patches fix a couple of issues I ran into while using the
> > >> jitdump JVMTI agent to profile the SPECjbb benchmark.
> > >>
> >
> > Hi, any feedback on these patches?
> >
> > Thanks,
> > Nick
>
Thanks Nick,
If you are looking at this code I believe there is a bug in that the
loop handling jvmtiCompiledMethodLoadInlineRecord is writing out the
entire line number table before a pc and not just the line number
table at the pc. This loop in do_get_line_numbers:
if (loc_tab[i].start_location < bci) {
tab[lines].pc = (unsigned long)pc;
tab[lines].line_number = loc_tab[i].line_number;
tab[lines].discrim = 0; /* not yet used */
tab[lines].methodID = m;
lines++;
} else {
It could possibly make sense if it were iterating over the inline data
in the jvmtiCompiledMethodLoadInlineRecord rather than the line number
table.
Fixing this is toward the end of a list of things I need to look at.
Thanks,
Ian
> > >>
> > >>
> > >> Nick Gasson (3):
> > >> perf jvmti: Fix jitdump for methods without debug info
> > >> perf jvmti: Do not report error when missing debug information
> > >> perf jvmti: Fix demangling Java symbols
> > >>
> > >> tools/perf/jvmti/libjvmti.c | 24 +++++++--------
> > >> tools/perf/tests/Build | 1 +
> > >> tools/perf/tests/builtin-test.c | 4 +++
> > >> tools/perf/tests/demangle-java-test.c | 42 +++++++++++++++++++++++++++
> > >> tools/perf/tests/tests.h | 1 +
> > >> tools/perf/util/demangle-java.c | 13 +++++----
> > >> 6 files changed, 66 insertions(+), 19 deletions(-)
> > >> create mode 100644 tools/perf/tests/demangle-java-test.c
> > >>
> > >> --
> > >> 2.26.1
> > >>
> >
>
> --
>
> - Arnaldo
next prev parent reply other threads:[~2020-05-14 22:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 6:15 [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent Nick Gasson
2020-04-27 6:15 ` [PATCH 1/3] perf jvmti: Fix jitdump for methods without debug info Nick Gasson
2020-05-14 22:06 ` Ian Rogers
2020-04-27 6:15 ` [PATCH 2/3] perf jvmti: Do not report error when missing debug information Nick Gasson
2020-05-14 22:08 ` Ian Rogers
2020-05-27 14:07 ` Arnaldo Carvalho de Melo
2020-05-27 14:08 ` Arnaldo Carvalho de Melo
2020-04-27 6:15 ` [PATCH 3/3] perf jvmti: Fix demangling Java symbols Nick Gasson
2020-05-14 22:09 ` Ian Rogers
2020-05-27 14:10 ` Arnaldo Carvalho de Melo
2020-05-27 14:20 ` Arnaldo Carvalho de Melo
2020-05-27 16:23 ` Arnaldo Carvalho de Melo
2020-05-27 22:34 ` Arnaldo Carvalho de Melo
2020-05-28 5:42 ` Nick Gasson
2020-04-27 10:35 ` [PATCH 0/3] perf jvmti: Various fixes to JVMTI agent Jiri Olsa
2020-05-14 8:56 ` Nick Gasson
2020-05-14 13:23 ` Arnaldo Carvalho de Melo
2020-05-14 22:41 ` Ian Rogers [this message]
2020-05-15 7:45 ` Nick Gasson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fX-dV+VHaPMO2Sw0DFB72YtuSyc23X5S3EvxGxYhAT4kQ@mail.gmail.com' \
--to=irogers@google.com \
--cc=Mark.Rutland@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nick.gasson@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).