From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC1055E76 for ; Wed, 14 Feb 2024 21:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707945343; cv=none; b=dzrhOnpA9XTRm7tLosgjLDVIQLEqj+Z1dp7lSmjrwRItZRUgcX5V6idA+fL+wnkfECyTkArNxYR/gyk64pPxpwRQ2TxAzsD0+xfeCYiiB+FVC266xcIAg7Lf6DfrC7lFmU/8AoII+BLrhRC2SDAJPjqcUilUCnhVnlm4SmUsJJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707945343; c=relaxed/simple; bh=F9oKYLh44bvwDgUu2A/DAornn6Az7M/1rM8//1GfUsY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=jskDsx04utVyYNqvpLp7dH0Y3x7wvMa+9CFo9JnXFgM5yrORXyCOAiJwUYhcZWa3P255tuT4agfQOd6FLODEXcfflBhMgFbAkTyfDsqFy6VoZl9XLn4ZLBOgwnAk+DHLYCgV9VsjyiNCLaf65JAtoh5/OFBXo3lzu5unCJglLQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bfWC7NN+; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bfWC7NN+" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-42dc7306ca1so8741cf.0 for ; Wed, 14 Feb 2024 13:15:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707945341; x=1708550141; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rtPYS+AuuZocKBV8MQsQ9n8ruvZkdc3y9Vt/v5r10Go=; b=bfWC7NN+E64DVyDhqXIBAFqshBjmiiXEfnsjOpJGgY8cD3ewiUtMOdVSNjCMuqW14T q/OvfVbpdLQW9VdwtkDUVlIKn8+04TlyPL8BuR2qslAJajSF2CU2j88oCbGjMyukeS8x AOAthsstPPUXOQEYDOXIXIW5U0nPddGJvhWQJswl/8zvaHCeIWfyO1/P8H8Dui81byYz vlAUP4hmSbkbPJk53netgDL3RuuOQALSsvi+hDqgMsmiYHQK0ocVZbHDQy2vwipSGTrI NWkxstYgj686YNcd2Q6c4l9841Tmh6HoBStqdiscHsGij92OIFoepr5uPtFHczdQwuL8 Xq+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707945341; x=1708550141; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rtPYS+AuuZocKBV8MQsQ9n8ruvZkdc3y9Vt/v5r10Go=; b=oUTgmBP/MqhcFNWVbqGJxi0m0El9AobaC4BfHt0c4COAv7qmD7wls4ADSRtOp0eZqX H35CB8R5fFYkEKsbJIWgVU2RfjlJDwGxK/fL5b8zwYUV2Xz9HZeyAW+V5U2gu/bJyxC9 2yyborpoVdChTS0yAPNtlEpL58BwpOHK/sdLqkgJ4+/3GAomG7vGW8Eu+vxBofDb4EcE bpty6P/nMpmF6F6CqK1yiFtJAYY0tw2YlysRv2niGEKwrJRC5B+U3/z6LLRrSoh69kvC ZhWl3dGS/qEW2iagy0MGkTGs/YNzTIkm7UXap16kyQbwNtFAWcCOfXAETdO82jzX2UJn 1GEw== X-Forwarded-Encrypted: i=1; AJvYcCVOUo0Fe2Ea9ZM6zYKA/UOJSjfCw63P2Q5fC32IVrpqFLN5FN1NNVhnj+nvGbxn5dPL6JjnRSkZQEz3ejX98uAfoSkSSYJVz/gYea6G X-Gm-Message-State: AOJu0Ywykrw65VijK176SHiB3iRGWqYXoDPpwc7ur6pMdKPYhF5g5I6L 6LIbxBLDwAmmEzLHSOoIOgq8sSL6LHYzsxiDbDHgM6k/mKC+K2Mc+e5KdOM+9TMqkIzjN02VXsE eEaqSV+RVAOYcK8aPiygX3cfU2/R5UYX6Bohc X-Google-Smtp-Source: AGHT+IEipjTakTkH6uUdqHEGoQ/AQsh79Py+LRmsAxPdIx46RUJnI91c573VL4Jo7dlUQ0Sjjg38UhtVioJEXHjoSuw= X-Received: by 2002:a05:622a:1882:b0:42c:501c:ed12 with SMTP id v2-20020a05622a188200b0042c501ced12mr495153qtc.4.1707945340646; Wed, 14 Feb 2024 13:15:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240214063708.972376-1-irogers@google.com> <20240214063708.972376-3-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Wed, 14 Feb 2024 13:15:27 -0800 Message-ID: Subject: Re: [PATCH v1 2/6] perf trace: Ignore thread hashing in summary To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Oliver Upton , Yang Jihong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 14, 2024 at 10:27=E2=80=AFAM Ian Rogers wr= ote: > > On Wed, Feb 14, 2024 at 9:25=E2=80=AFAM Arnaldo Carvalho de Melo > wrote: > > > > On Tue, Feb 13, 2024 at 10:37:04PM -0800, Ian Rogers wrote: > > > Commit 91e467bc568f ("perf machine: Use hashtable for machine > > > threads") made the iteration of thread tids unordered. The perf trace > > > --summary output sorts and prints each hash bucket, rather than all > > > threads globally. Change this behavior by turn all threads into a > > > list, sort the list by number of trace events then by tids, finally > > > print the list. This also allows the rbtree in threads to be not > > > accessed outside of machine. > > > > Can you please provide a refresh of the output that is changed by your = patch? > > Hmm.. looks like perf trace record has broken and doesn't produce > output in newer perfs. It works on 6.5 and so a bisect is necessary. Bisect result: ``` 9925495d96efc14d885ba66c5696f664fe0e663c is the first bad commit commit 9925495d96efc14d885ba66c5696f664fe0e663c Author: Ian Rogers Date: Thu Sep 14 14:19:45 2023 -0700 perf build: Default BUILD_BPF_SKEL, warn/disable for missing deps ... https://lore.kernel.org/r/20230914211948.814999-3-irogers@google.com ``` Now to do the bisect with BUILD_BPF_SKEL=3D1 on each make. Thanks, Ian