From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0EEAC00140 for ; Wed, 10 Aug 2022 14:26:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232530AbiHJO0P (ORCPT ); Wed, 10 Aug 2022 10:26:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232498AbiHJO0L (ORCPT ); Wed, 10 Aug 2022 10:26:11 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4960B1CFDB for ; Wed, 10 Aug 2022 07:26:10 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id n4so16182947wrp.10 for ; Wed, 10 Aug 2022 07:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=PxC7taMylQDUHixSMWrpX0lBX/KvvsQMV/F2vgDXG0c=; b=HGVm54lbjow5CHbKkhecvtoEv7Dcln74pUP4USjVFB7pMfzJbJx/OxkpzaQ/KTqCKJ Q4XxCbg4qes4bnKM/IPm4Oiv/M9ZhLcKH6BpN6ditlXliiApYs4ZMqOTTVuNliu+blPV 44yoslgnbOAC/GOVFRvZAqC1RCiCORmq7HaBr9fg0ZRTcOUOt5A2tuQherdXkUI8NOR6 TIMhNf1waB2m/vD/JoqFSNjwJi5pKZIFie7H2eE++/R9Nlf9INz9zufJ6F0aT9uRlT3C zMUw3rfoyXHVuesoV7LgOmUgOS/W9pL5oe6aIT4CcNxSTMAJGKF/hwlg1iBru9eBtqPN FKCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=PxC7taMylQDUHixSMWrpX0lBX/KvvsQMV/F2vgDXG0c=; b=pvCYgjkjhohJYRJt0YM0JiWLUqA/7ilwc6bwWG2mu7a5r/H3NldjKcPnwwRA6Km9bx fabcl7F9Ryv/lG9nvMQkmrfLdDcszV5NZbSGASUsxxcZH0NcTk05g9IOP6oH3HMRRyON 2Bb8KBOVTyUV15v2552SJ7ejIDDL/kYiTrn3wLCul3/xgKChz83YOvwUJ0tbeSh1ADGp C5xaRj7r+GJ3WXJiz+Nejx/GFyh6BEEMYf1pldlkYSQRzuDaE67hQvnEBj3eMrS54t/j ByBPil15EOQpFgC/dztWI/4dPOK7XwDhwQqgR/cCgZUM1U8tVv3B5fD/xiiFYQWQQCkp 5UFw== X-Gm-Message-State: ACgBeo2lqF9H+y4uBgfnHVeDLquVgMn2j6uO7cG17ZupMdekjCB4u9n9 fVZnwtrD9zfxDFyuGWE2Awv9wr9LBJnSN3dqwWwPvA== X-Google-Smtp-Source: AA6agR5tn2cSIsF6oseDLw/DBgnH5iau93kiUtSyR4DVnZloPDnLHTkWOMq4ezSDrM3e8QPzWZPiIV6bLplCNTgzsuI= X-Received: by 2002:adf:e28d:0:b0:21e:4c3b:b446 with SMTP id v13-20020adfe28d000000b0021e4c3bb446mr17038394wri.300.1660141568603; Wed, 10 Aug 2022 07:26:08 -0700 (PDT) MIME-Version: 1.0 References: <20220804221816.1802790-1-irogers@google.com> <20220804221816.1802790-9-irogers@google.com> <04e1e8c1-d060-6658-141a-b7c1b7dd8400@huawei.com> In-Reply-To: <04e1e8c1-d060-6658-141a-b7c1b7dd8400@huawei.com> From: Ian Rogers Date: Wed, 10 Aug 2022 07:25:56 -0700 Message-ID: Subject: Re: [PATCH v4 08/17] perf pmu-events: Hide pmu_sys_event_tables To: John Garry Cc: Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 5, 2022 at 4:15 AM John Garry wrote: > > On 04/08/2022 23:18, Ian Rogers wrote: > > Move usage of the table to pmu-events.c so it may be hidden. By > > abstracting the table the implementation can later be changed. > > > > Signed-off-by: Ian Rogers > > Reviewed-by: John Garry > > > - const struct pmu_event *sys_event_tables = __test_pmu_get_sys_events_table(); > > + const struct pmu_event *sys_event_tables = find_sys_events_table("pme_test_soc_sys"); > > Maybe we can change to not need the "pme_" prefix or even some of the > suffix, like "_sys" Ack. Not done here so the change is the smallest possible. Thanks, Ian > > const struct pmu_events_map *map = __test_pmu_get_events_map(); >