From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932926AbcKPQkO (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Nov 2016 11:40:14 -0500
Received: from mail-ua0-f195.google.com ([209.85.217.195]:33496 "EHLO
        mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932754AbcKPQkL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Nov 2016 11:40:11 -0500
MIME-Version: 1.0
In-Reply-To: <26413C89-E639-4834-A600-C4B6679162F2@gmail.com>
References: <20161110234055.8654-1-khuey@kylehuey.com> <20161110234055.8654-8-khuey@kylehuey.com>
 <26413C89-E639-4834-A600-C4B6679162F2@gmail.com>
From: Kyle Huey <me@kylehuey.com>
Date: Wed, 16 Nov 2016 08:40:09 -0800
Message-ID: <CAP045AqG5f5pJLYVVnFZfrFv8h8ZzpcD=bkS+tJrVWE_vX48Qg@mail.gmail.com>
Subject: Re: [PATCH v11 7/7] KVM: x86: virtualize cpuid faulting
To: Nadav Amit <nadav.amit@gmail.com>
Cc: "Robert O'Callahan" <robert@ocallahan.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Shuah Khan <shuah@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@suse.de>, Peter Zijlstra <peterz@infradead.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Len Brown <len.brown@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Dmitry Safonov <dsafonov@virtuozzo.com>,
        David Matlack <dmatlack@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "open list:USER-MODE LINUX (UML)" 
        <user-mode-linux-devel@lists.sourceforge.net>,
        "open list:USER-MODE LINUX (UML)" 
        <user-mode-linux-user@lists.sourceforge.net>,
        "open list:FILESYSTEMS (VFS and infrastructure)" 
        <linux-fsdevel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KVM <kvm@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 11, 2016 at 12:54 PM, Nadav Amit <nadav.amit@gmail.com> wrote:
>
>> On Nov 10, 2016, at 3:40 PM, Kyle Huey <me@kylehuey.com> wrote:
>>
>> Hardware support for faulting on the cpuid instruction is not required to
>> emulate it, because cpuid triggers a VM exit anyways. KVM handles the relevant
>> MSRs (MSR_PLATFORM_INFO and MSR_MISC_FEATURES_ENABLE) and upon a
>> cpuid-induced VM exit checks the cpuid faulting state and the CPL.
>> kvm_require_cpl is even kind enough to inject the GP fault for us.
>
> I think that for consistency you should also revise em_cpuid() of KVM
> instruction emulator. Otherwise it may be a potential security
> hazard (as far fetched as it currently seems).

Hmm, ok.  Do you know how I can test this code path?

- Kyle