From: Sarbojit Ganguly <unixman.linuxboy@gmail.com>
To: Daniel Mack <zonque@gmail.com>
Cc: "Alan Stern" <stern@rowland.harvard.edu>,
"Bjørn Mork" <bjorn@mork.no>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, "Takashi Iwai" <tiwai@suse.de>
Subject: Re: Kernel Oops while disconnecting USB peripheral (always)
Date: Wed, 8 Aug 2012 08:52:56 +0530 [thread overview]
Message-ID: <CAP2rAF-8wC0BkCieCi6S59kYbPgum=H8bp+_MM+RnGhsq0yAAQ@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1207281218190.23545-100000@netrider.rowland.org>
Sorry guys I was away due to personal emergency, however now I am back
and will check the reply ASAP.
On 28 July 2012 21:49, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Sat, 28 Jul 2012, Daniel Mack wrote:
>
>> Hmm, interesting. Thanks for sharing this. I personally never saw this
>> bug kicking in, but if I understand your findings correctly, we would
>> need something like the following patch for snd-usb and the storage driver?
>>
>> Sarbojit, could you give this a test and see whether your kernel still
>> crashes in any of the two drivers?
>
>
>> --- a/drivers/usb/storage/usb.c
>> +++ b/drivers/usb/storage/usb.c
>> @@ -1025,9 +1025,14 @@ void usb_stor_disconnect(struct usb_interface *intf)
>> {
>> struct us_data *us = usb_get_intfdata(intf);
>>
>> + if (!us)
>> + return;
>
> This can never happen. The disconnect routine gets called only once,
> so us will not be NULL.
>
>> +
>> US_DEBUGP("storage_disconnect() called\n");
>> quiesce_and_remove_host(us);
>> release_everything(us);
>> +
>> + usb_set_intfdata(intf, NULL);
>> }
>> EXPORT_SYMBOL_GPL(usb_stor_disconnect);
>
> Alan Stern
>
--
Regards,
Sarbojit
next prev parent reply other threads:[~2012-08-08 3:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 3:42 Kernel Oops while disconnecting USB peripheral (always) Sarbojit Ganguly
2012-07-23 5:50 ` Daniel Mack
2012-07-23 6:03 ` Sarbojit Ganguly
2012-07-23 14:47 ` Alan Stern
2012-07-23 14:54 ` Daniel Mack
2012-07-23 15:05 ` Sarbojit Ganguly
2012-07-28 12:27 ` Bjørn Mork
2012-07-28 12:52 ` Daniel Mack
2012-07-28 13:25 ` Bjørn Mork
2012-07-28 13:30 ` Daniel Mack
2012-07-28 16:19 ` Alan Stern
2012-08-08 3:22 ` Sarbojit Ganguly [this message]
2012-07-23 15:04 ` Sarbojit Ganguly
2012-07-23 15:07 ` Daniel Mack
2012-07-28 11:13 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP2rAF-8wC0BkCieCi6S59kYbPgum=H8bp+_MM+RnGhsq0yAAQ@mail.gmail.com' \
--to=unixman.linuxboy@gmail.com \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).