From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767C3C2D0A3 for ; Tue, 3 Nov 2020 17:42:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E34621D91 for ; Tue, 3 Nov 2020 17:42:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rXQORZKJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728934AbgKCRmV (ORCPT ); Tue, 3 Nov 2020 12:42:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728690AbgKCRmU (ORCPT ); Tue, 3 Nov 2020 12:42:20 -0500 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F44AC0613D1 for ; Tue, 3 Nov 2020 09:42:20 -0800 (PST) Received: by mail-ed1-x543.google.com with SMTP id l24so19220274edj.8 for ; Tue, 03 Nov 2020 09:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VYn/vKDpZ5hpbmpnVni806ofiX+cJciXsAeXX/Sk4l0=; b=rXQORZKJ2U+ylxQMF+9AWKUkZJig+UmoOXKVflnPvZyXuXR3GWmyk8sl0FLRxGl5xg 5lfIaoIOsrcyieN13ynqLZkEePlq89EUJamlYl6hghYN63fgjJkxx5xHyPyZzpGICC+o 2o5rigaAjjX8gaTETVTq1LnQYk/hyVYawJ6DJXxvf7OlCULVdl1YUj4OO7Gu+CRU2OBq MAaCSUd8n0j4PhonBKq9VehFQtMRUjEKokqvCTZl0igGB0NPyqMotDu7y/VLM73ncz3z f3MmwqNWLrByP7AxDGZS7wh2d1qoMU/OM17PTogjmy70uuo1AHpN8QVQ1rOprZFXD+UO 5GRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VYn/vKDpZ5hpbmpnVni806ofiX+cJciXsAeXX/Sk4l0=; b=fJnLSwjrNlxM8MYUEdIQYvUle6v3OBsPtd9kdZqN3hkFsaOf/PhAb7AkrCi9HJBwIl Ck5tNx0PSOouJAvDQyAUTaEsR+UZZn57XdOf/26FrEcjdt4ldQUhKqtys+PEupoCIu+J Cz85HGk6WV5JBA26JBMIN1VSNDRus8do0B5eN0NfJQYFqtP95dFo4/zY0O4q2EWsztPX 25F/ud39QEtMNSSpB5ZGBawJk+SPaQwnQU6W9ewo8AiqZupp7E8yBf8xg5xNK9vsSusE Ir3a7lMqiul1mh/DV1M+YBU8L/15cIguB9HR33Lb+veTHuSz+h19paRF25gdXHm4Zm4U IPjQ== X-Gm-Message-State: AOAM533Skwfs63a0JL2udNbkUvn4ByXQlITWRhjXT+NKf20hycWcP+o3 1BAbv0m6E30Nwvinmwysgpf2COPEXvQk1WyfDj9C4Q== X-Google-Smtp-Source: ABdhPJx5S3UzzTfDY8cKn+TAZM3BY37RtnJgYkeBXCiaVtJb0CB9xGlXlLQ7ZmZrDmrYSo9E3rydacpjFJ5hnLH6KB4= X-Received: by 2002:a05:6402:4d:: with SMTP id f13mr23008097edu.306.1604425339037; Tue, 03 Nov 2020 09:42:19 -0800 (PST) MIME-Version: 1.0 References: <20201001230403.2445035-1-danielwinkler@google.com> In-Reply-To: From: Daniel Winkler Date: Tue, 3 Nov 2020 09:42:07 -0800 Message-ID: Subject: Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add To: Luiz Augusto von Dentz Cc: Marcel Holtmann , BlueZ , chromeos-bluetooth-upstreaming , "David S. Miller" , Jakub Kicinski , Johan Hedberg , Linux Kernel Mailing List , "open list:NETWORKING [GENERAL]" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Luiz, Thank you for the information. It is good to know that this tool is actively used and that there is a way to skip existing flaky tests. Just for clarification, is this a requirement to land the kernel changes, i.e. should I prioritize adding these tests immediately to move the process forward? Or can we land the changes based on the testing I have already done and I'll work on these tests in parallel? Thanks, Daniel On Thu, Oct 29, 2020 at 5:04 PM Luiz Augusto von Dentz wrote: > > Hi Daniel, > > On Thu, Oct 29, 2020 at 3:25 PM Daniel Winkler wrote: > > > > Hi Luiz, > > > > Thank you for the feedback regarding mgmt-tester. I intended to use > > the tool, but found that it had a very high rate of test failure even > > before I started adding new tests. If you have a strong preference for > > its use, I can look into it again but it may take some time. These > > changes were tested with manual and automated functional testing on > > our end. > > > > Please let me know your thoughts. > > Total: 406, Passed: 358 (88.2%), Failed: 43, Not Run: 5 > > Looks like there are some 43 tests failing, we will need to fix these > but it should prevent us to add new ones as well, you can use -p to > filter what tests to run if you want to avoid these for now.