linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tedheadster <tedheadster@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: ville.syrjala@linux.intel.com, David Miller <davem@davemloft.net>,
	eric.dumazet@gmail.com, edumazet@google.com,
	netdev <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")
Date: Mon, 10 Apr 2017 10:22:05 -0400	[thread overview]
Message-ID: <CAP8WD_aos5u90cxS5+fCL9pVziHXV==1b+j2tzwxA5qxe7Ao-w@mail.gmail.com> (raw)
In-Reply-To: <20170408102305.GA4522@electric-eye.fr.zoreil.com>

On Sat, Apr 8, 2017 at 6:23 AM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> David Miller <davem@davemloft.net> :
> [...]
>> One theory is that the interrupt masking isn't working properly
>> and interrupts are still arriving and hitting the NAPI state even
>> when we are actively polling NAPI.
>>
>> And this problem was masked by the locking done here.
>
> Yes.
>
> Ville, can you rule out irq sharing between the 8139 and some other
> device ? It's a candidate for unexpected interrupt handler invocation
> with older pc, even with properly working hardware.
>

Eric,
  If napi_complete_done() calls could affect drivers on older
hardware, I can test the following:

drivers/net/ethernet/3com/typhoon.c
drivers/net/ethernet/amd/pcnet32.c
drivers/net/ethernet/broadcom/tg3.c
drivers/net/ethernet/dec/tulip/interrupt.c
drivers/net/ethernet/intel/e100.c
drivers/net/ethernet/intel/e1000/e1000_main.c
drivers/net/ethernet/smsc/epic100.c
drivers/net/ethernet/via/via-rhine.c

- Matthew

  reply	other threads:[~2017-04-10 14:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 18:17 [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()") Ville Syrjälä
2017-04-07 18:38 ` Eric Dumazet
2017-04-07 18:42   ` David Miller
2017-04-08 10:23     ` Francois Romieu
2017-04-10 14:22       ` tedheadster [this message]
2017-04-10 14:55         ` Eric Dumazet
2017-04-10 12:11   ` Ville Syrjälä
2017-09-18 19:46     ` Ville Syrjälä
2017-09-18 19:52       ` Eric Dumazet
2017-09-19 12:45         ` Ville Syrjälä
2017-09-19 13:51           ` Eric Dumazet
2017-06-19 14:44   ` Michal Kubecek
2017-07-05 19:53     ` Ville Syrjälä
2017-04-21 11:40 ` Ville Syrjälä
2017-04-21 13:29   ` Eric Dumazet
2017-04-21 15:09     ` Eric Dumazet
2017-04-21 15:34       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP8WD_aos5u90cxS5+fCL9pVziHXV==1b+j2tzwxA5qxe7Ao-w@mail.gmail.com' \
    --to=tedheadster@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=whiteheadm@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).