From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752046AbdBBUHf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Feb 2017 15:07:35 -0500
Received: from mail-ua0-f194.google.com ([209.85.217.194]:36731 "EHLO
        mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751889AbdBBUHc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Feb 2017 15:07:32 -0500
MIME-Version: 1.0
In-Reply-To: <20170110212838.16175-5-manuel.schoelling@gmx.de>
References: <4640722.jsFVORW8WM@amdc3058> <20170110212838.16175-1-manuel.schoelling@gmx.de>
 <20170110212838.16175-5-manuel.schoelling@gmx.de>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Thu, 2 Feb 2017 15:07:01 -0500
X-Google-Sender-Auth: Yw7pavwpGnVBAOOBdYrrNlTXBdY
Message-ID: <CAP=VYLpBfFdixRm5=gQOqjxc+Qpy-Kk1oa1uMQjUnXTJO3fqrg@mail.gmail.com>
Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter
To: =?UTF-8?Q?Manuel_Sch=C3=B6lling?= <manuel.schoelling@gmx.de>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        jslaby@suse.com, kilobyte@angband.pl, lkml14@scotdoyle.com,
        rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com,
        Andrew Morton <akpm@linux-foundation.org>, paul.burton@imgtec.com,
        daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com,
        LKML <linux-kernel@vger.kernel.org>, linux-fbdev@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v12K7is7005152

On Tue, Jan 10, 2017 at 4:28 PM, Manuel Schölling
<manuel.schoelling@gmx.de> wrote:
> The impact of the persistent scrollback feature on the code size is
> rather small, so the config option is removed. The feature stays
> disabled by default and can be enabled by using the boot command line
> parameter 'vgacon.scrollback_persistent=1' or by setting
> VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y.
>
> Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
> Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---

[...]

> +module_param_named(scrollback_persistent, scrollback_persistent, bool, 0000);
> +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent scrollback for all vga consoles");

Since this hasn't got widespread deployment yet and  only exists
in Greg's tree, can we please fix the above to use setup_param or
similar, since there is nothing modular about this code at all.

Thanks.
Paul.