From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbbAVFxK (ORCPT ); Thu, 22 Jan 2015 00:53:10 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:58604 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbbAVFxH (ORCPT ); Thu, 22 Jan 2015 00:53:07 -0500 MIME-Version: 1.0 In-Reply-To: References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1421859105-25253-1-git-send-email-a.ryabinin@samsung.com> <54C042D2.4040809@oracle.com> Date: Thu, 22 Jan 2015 09:53:06 +0400 Message-ID: Subject: Re: [PATCH v9 00/17] Kernel address sanitizer - runtime memory debugger. From: Andrey Ryabinin To: Sasha Levin Cc: Andrey Ryabinin , LKML , Dmitry Vyukov , Konstantin Serebryany , Dmitry Chernenkov , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Michal Marek , Thomas Gleixner , Ingo Molnar , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Dave Hansen , Andi Kleen , Vegard Nossum , "H. Peter Anvin" , "x86@kernel.org" , "linux-mm@kvack.org" , Randy Dunlap , Peter Zijlstra , Alexander Viro , Dave Jones , Jonathan Corbet , Linus Torvalds , Catalin Marinas Content-Type: multipart/mixed; boundary=001a11c3d66c3ec2ac050d374977 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --001a11c3d66c3ec2ac050d374977 Content-Type: text/plain; charset=UTF-8 2015-01-22 8:34 GMT+03:00 Andrey Ryabinin : > 2015-01-22 3:22 GMT+03:00 Sasha Levin : >> On 01/21/2015 11:51 AM, Andrey Ryabinin wrote: >>> Changes since v8: >>> - Fixed unpoisoned redzones for not-allocated-yet object >>> in newly allocated slab page. (from Dmitry C.) >>> >>> - Some minor non-function cleanups in kasan internals. >>> >>> - Added ack from Catalin >>> >>> - Added stack instrumentation. With this we could detect >>> out of bounds accesses in stack variables. (patch 12) >>> >>> - Added globals instrumentation - catching out of bounds in >>> global varibles. (patches 13-17) >>> >>> - Shadow moved out from vmalloc into hole between vmemmap >>> and %esp fixup stacks. For globals instrumentation >>> we will need shadow backing modules addresses. >>> So we need some sort of a shadow memory allocator >>> (something like vmmemap_populate() function, except >>> that it should be available after boot). >>> >>> __vmalloc_node_range() suits that purpose, except that >>> it can't be used for allocating for shadow in vmalloc >>> area because shadow in vmalloc is already 'allocated' >>> to protect us from other vmalloc users. So we need >>> 16TB of unused addresses. And we have big enough hole >>> between vmemmap and %esp fixup stacks. So I moved shadow >>> there. >> >> I'm not sure which new addition caused it, but I'm getting tons of >> false positives from platform drivers trying to access memory they >> don't "own" - because they expect to find hardware there. >> > > To be sure, that this is really false positives, could you try with > patches in attachment? Attaching properly formed patches --001a11c3d66c3ec2ac050d374977 Content-Type: text/x-patch; charset=US-ASCII; name="0001-backlight-da9052_bl-terminate-da9052_wled_ids-array-.patch" Content-Disposition: attachment; filename="0001-backlight-da9052_bl-terminate-da9052_wled_ids-array-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i57ylfp93 RnJvbSA4YWNhMjhkYzRkZjJlZDU5N2Y0ZmUwZDQ5NDY4MDIxZGI1ZjI5YzYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXkgUnlhYmluaW4gPGEucnlhYmluaW5Ac2Ftc3VuZy5j b20+CkRhdGU6IFRodSwgMjIgSmFuIDIwMTUgMTI6NDQ6NDIgKzAzMDAKU3ViamVjdDogW1BBVENI IDEvM10gYmFja2xpZ2h0OiBkYTkwNTJfYmw6IHRlcm1pbmF0ZSBkYTkwNTJfd2xlZF9pZHMgYXJy YXkKIHdpdGggZW1wdHkgZWxlbWVudAoKQXJyYXkgb2YgcGxhdGZvcm1fZGV2aWNlX2lkIGVsZW1l bnRzIHNob3VsZCBiZSB0ZXJtaW5hdGVkCndpdGggZW1wdHkgZWxlbWVudC4KClNpZ25lZC1vZmYt Ynk6IEFuZHJleSBSeWFiaW5pbiA8YS5yeWFiaW5pbkBzYW1zdW5nLmNvbT4KLS0tCiBkcml2ZXJz L3ZpZGVvL2JhY2tsaWdodC9kYTkwNTJfYmwuYyB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvZGE5MDUyX2Js LmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9kYTkwNTJfYmwuYwppbmRleCBkNGJkNzRiZC4u YjE5NDNlNyAxMDA2NDQKLS0tIGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvZGE5MDUyX2JsLmMK KysrIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvZGE5MDUyX2JsLmMKQEAgLTE2NSw2ICsxNjUs NyBAQCBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RldmljZV9pZCBkYTkwNTJfd2xlZF9pZHNbXSA9 IHsKIAkJLm5hbWUJCT0gImRhOTA1Mi13bGVkMyIsCiAJCS5kcml2ZXJfZGF0YQk9IERBOTA1Ml9U WVBFX1dMRUQzLAogCX0sCisJeyB9LAogfTsKIAogc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2 ZXIgZGE5MDUyX3dsZWRfZHJpdmVyID0gewotLSAKMi4wLjQKCg== --001a11c3d66c3ec2ac050d374977 Content-Type: text/x-patch; charset=US-ASCII; name="0002-crypto-ccp-terminate-ccp_support-array-with-empty-el.patch" Content-Disposition: attachment; filename="0002-crypto-ccp-terminate-ccp_support-array-with-empty-el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i57ylfpq4 RnJvbSAyN2Y4Y2YwYWZmN2QxNmMwNjFkZGE5ZGQyMTk4ODdjYWUyMjE0NTg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXkgUnlhYmluaW4gPGEucnlhYmluaW5Ac2Ftc3VuZy5j b20+CkRhdGU6IFRodSwgMjIgSmFuIDIwMTUgMTI6NDY6NDQgKzAzMDAKU3ViamVjdDogW1BBVENI IDIvM10gY3J5cHRvOiBjY3A6IHRlcm1pbmF0ZSBjY3Bfc3VwcG9ydCBhcnJheSB3aXRoIGVtcHR5 CiBlbGVtZW50Cgp4ODZfbWF0Y2hfY3B1KCkgZXhwZWN0cyBhcnJheSBvZiB4ODZfY3B1X2lkcyB0 ZXJtaW5hdGVkCndpdGggZW1wdHkgZWxlbWVudC4KClNpZ25lZC1vZmYtYnk6IEFuZHJleSBSeWFi aW5pbiA8YS5yeWFiaW5pbkBzYW1zdW5nLmNvbT4KLS0tCiBkcml2ZXJzL2NyeXB0by9jY3AvY2Nw LWRldi5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQg YS9kcml2ZXJzL2NyeXB0by9jY3AvY2NwLWRldi5jIGIvZHJpdmVycy9jcnlwdG8vY2NwL2NjcC1k ZXYuYwppbmRleCBjNmU2MTcxLi5jYTI5YzEyIDEwMDY0NAotLS0gYS9kcml2ZXJzL2NyeXB0by9j Y3AvY2NwLWRldi5jCisrKyBiL2RyaXZlcnMvY3J5cHRvL2NjcC9jY3AtZGV2LmMKQEAgLTU4Myw2 ICs1ODMsNyBAQCBib29sIGNjcF9xdWV1ZXNfc3VzcGVuZGVkKHN0cnVjdCBjY3BfZGV2aWNlICpj Y3ApCiAjaWZkZWYgQ09ORklHX1g4Ngogc3RhdGljIGNvbnN0IHN0cnVjdCB4ODZfY3B1X2lkIGNj cF9zdXBwb3J0W10gPSB7CiAJeyBYODZfVkVORE9SX0FNRCwgMjIsIH0sCisJeyB9LAogfTsKICNl bmRpZgogCi0tIAoyLjAuNAoK --001a11c3d66c3ec2ac050d374977 Content-Type: text/x-patch; charset=US-ASCII; name="0003-rtc-s5m-terminate-s5m_rtc_id-array-with-empty-elemen.patch" Content-Disposition: attachment; filename="0003-rtc-s5m-terminate-s5m_rtc_id-array-with-empty-elemen.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i57ylfq05 RnJvbSAzYTNiZDljZmQyMjNmMTRkMzEzNTJiOWE0NDIwOTQ3NmIzZjVlZjExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXkgUnlhYmluaW4gPGEucnlhYmluaW5Ac2Ftc3VuZy5j b20+CkRhdGU6IFRodSwgMjIgSmFuIDIwMTUgMTI6NDg6MTUgKzAzMDAKU3ViamVjdDogW1BBVENI IDMvM10gcnRjOiBzNW06IHRlcm1pbmF0ZSBzNW1fcnRjX2lkIGFycmF5IHdpdGggZW1wdHkgZWxl bWVudAoKQXJyYXkgb2YgcGxhdGZvcm1fZGV2aWNlX2lkIGVsZW1lbnRzIHNob3VsZCBiZSB0ZXJt aW5hdGVkCndpdGggZW1wdHkgZWxlbWVudC4KClNpZ25lZC1vZmYtYnk6IEFuZHJleSBSeWFiaW5p biA8YS5yeWFiaW5pbkBzYW1zdW5nLmNvbT4KLS0tCiBkcml2ZXJzL3J0Yy9ydGMtczVtLmMgfCAx ICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMv cnRjL3J0Yy1zNW0uYyBiL2RyaXZlcnMvcnRjL3J0Yy1zNW0uYwppbmRleCBiNWU3YzQ2Li44OWFj MWQ1IDEwMDY0NAotLS0gYS9kcml2ZXJzL3J0Yy9ydGMtczVtLmMKKysrIGIvZHJpdmVycy9ydGMv cnRjLXM1bS5jCkBAIC04MzIsNiArODMyLDcgQEAgc3RhdGljIFNJTVBMRV9ERVZfUE1fT1BTKHM1 bV9ydGNfcG1fb3BzLCBzNW1fcnRjX3N1c3BlbmQsIHM1bV9ydGNfcmVzdW1lKTsKIHN0YXRpYyBj b25zdCBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlX2lkIHM1bV9ydGNfaWRbXSA9IHsKIAl7ICJzNW0t cnRjIiwJCVM1TTg3NjdYIH0sCiAJeyAiczJtcHMxNC1ydGMiLAlTMk1QUzE0WCB9LAorCXsgfSwK IH07CiAKIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHM1bV9ydGNfZHJpdmVyID0gewot LSAKMi4wLjQKCg== --001a11c3d66c3ec2ac050d374977--