From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B54C282C0 for ; Wed, 23 Jan 2019 06:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4B2921726 for ; Wed, 23 Jan 2019 06:10:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="atALjpUS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726340AbfAWGKH (ORCPT ); Wed, 23 Jan 2019 01:10:07 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:40114 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfAWGKH (ORCPT ); Wed, 23 Jan 2019 01:10:07 -0500 Received: by mail-oi1-f196.google.com with SMTP id t204so887425oie.7 for ; Tue, 22 Jan 2019 22:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9FeO1gesXy6KU0wTtnDDJtJcP0TAwXtlCZpvjn7+aHM=; b=atALjpUSlb7TCgaZHAqLsdxvdjr2mFnw3ZywEFCay6yGw4aroMpcL/Q/IRBD7z9aBB zET+HXG8yBrNOur9CiqIj81Ptho6ThWc/9lHjCH0HwlZgvDUPdP5e1Ct4tgUpPn2hYBn fLmI9hkKb98tv5EA34KS8t9vITbvDhBCoCIUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9FeO1gesXy6KU0wTtnDDJtJcP0TAwXtlCZpvjn7+aHM=; b=pO4YlcM4q9VuKWuAy+8RWtnsmIHLy0Y3Tu2youGEGwmX0YPYHtan2d/7BP3kqLwPQ0 v56A0MGb3Cl9PtGIaWOu3AzvB2WWSHNbXx/+jpNmqR9nCJ26l6cO4hUBpsiS1xOI+F4f pp0sCWSB2aK9Bok5q/xyFWIC/IE8HfM120w3APbU5NX4lJB3xk822puQD7D3APKuoDF2 tNyIAAAXA9y8Xc2RzQwlhQUIPXByZL3bYk3XnIwgn6m0era7XpKTOqTU+QF3j3Ktl1WB SqQPNNLBQohBTx4qGAHar5i3TvHkR//nA5RCJwhEoZgGjxz3kvbq8mN8KcKduyftRoUt c0nA== X-Gm-Message-State: AJcUukdXXJl8RVo/awRwqZcZ+rHRQOhEMV+7Gf0e51XdCYx10/7E+bD2 b6rvXCMmvjYV1jZC+UZ8aXth7xpovnwcGQ== X-Google-Smtp-Source: ALg8bN6g99uEKQGCKHWPCE8oWjc735qwNwcWxXUyvrWLvE3U9K4aBWExwbs9vQI6gSGrgqTOU6Bl/Q== X-Received: by 2002:aca:ef87:: with SMTP id n129mr570750oih.118.1548223806679; Tue, 22 Jan 2019 22:10:06 -0800 (PST) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com. [209.85.167.173]) by smtp.gmail.com with ESMTPSA id h24sm7447101otq.11.2019.01.22.22.10.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 22:10:05 -0800 (PST) Received: by mail-oi1-f173.google.com with SMTP id v6so914769oif.2 for ; Tue, 22 Jan 2019 22:10:05 -0800 (PST) X-Received: by 2002:aca:ad14:: with SMTP id w20mr576883oie.3.1548223805144; Tue, 22 Jan 2019 22:10:05 -0800 (PST) MIME-Version: 1.0 References: <20190109084616.17162-1-stanimir.varbanov@linaro.org> <20190109084616.17162-5-stanimir.varbanov@linaro.org> In-Reply-To: <20190109084616.17162-5-stanimir.varbanov@linaro.org> From: Alexandre Courbot Date: Wed, 23 Jan 2019 15:09:53 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] venus: helpers: drop setting of timestap invalid flag To: Stanimir Varbanov Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , LKML , linux-arm-msm@vger.kernel.org, Vikash Garodia , Tomasz Figa , Malathi Gottam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 9, 2019 at 5:46 PM Stanimir Varbanov wrote: > > The zero timestap is really a valid so not sure why I discarded it. Fix s/timestap/timestamp, also in patch title. > that mistake by drop the code which checks for zero timestamp. s/drop/dropping > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/helpers.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > index e436385bc5ab..5cad601d4c57 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -439,9 +439,6 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf) > fdata.flags = 0; > fdata.clnt_data = vbuf->vb2_buf.index; > > - if (!fdata.timestamp) > - fdata.flags |= HFI_BUFFERFLAG_TIMESTAMPINVALID; > - > if (type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) { > fdata.buffer_type = HFI_BUFFER_INPUT; > fdata.filled_len = vb2_get_plane_payload(vb, 0); > -- > 2.17.1 >