From: Nick Krause <xerofoify@gmail.com>
To: Tony Luck <tony.luck@gmail.com>
Cc: "Bjørn Mork" <bjorn@mork.no>,
"Doug Thompson" <dougthompson@xmission.com>,
"Borislav Petkov" <bp@alien8.de>,
"m.chehab@samsung.com" <m.chehab@samsung.com>,
"Linux Edac Mailing List" <linux-edac@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c
Date: Tue, 22 Jul 2014 13:40:42 -0400 [thread overview]
Message-ID: <CAPDOMVjaf+vne4vbUPo8EPs0XnQBbNm2ZOXns8fw5pkg9tRSww@mail.gmail.com> (raw)
In-Reply-To: <CA+8MBb+fnCNeQtyEqttxbkWx-4N+GUaKCUoCSdn5X9+bDDvTOg@mail.gmail.com>
On Tue, Jul 22, 2014 at 1:25 PM, Tony Luck <tony.luck@gmail.com> wrote:
> On Tue, Jul 22, 2014 at 7:04 AM, Bjørn Mork <bjorn@mork.no> wrote:
>>> - /* FIXME - should use PAGE_SHIFT */
>>> - page = error_1b >> 6; /* convert the address to 4k page */
>>> + page = error_1b >> PAGE_SHIFT; /* convert the address to 4k page */
>>
>> I just have to bite... Where did you get the idea that you can go
>> around and "fix" FIMXE's like they were spelling errors?
>
> Or apparently without thinking? Since "PAGE_SHIFT" does not have
> the numerical value "6" your new code is obviously not equivalent to
> the old.
>
> -Tony
Tony,
What is the value of Page shift then ? If you can tell me it would be
much easier for
me to fix this.
Cheers Nick
next prev parent reply other threads:[~2014-07-22 17:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 4:53 [PATCH] edac: Remove fixmes in e7xxx_edac.c Nicholas Krause
2014-07-22 14:04 ` Bjørn Mork
2014-07-22 17:25 ` Tony Luck
2014-07-22 17:40 ` Nick Krause [this message]
2014-07-22 17:46 ` Borislav Petkov
2014-07-22 18:03 ` Nick Krause
2014-07-22 18:08 ` Borislav Petkov
2014-07-22 18:14 ` Levente Kurusa
2014-07-22 18:25 ` Nick Krause
2014-07-22 19:17 ` Randy Dunlap
2014-07-22 19:33 ` Steven Rostedt
2014-07-22 20:56 ` Nick Krause
2014-07-23 14:37 ` Steven Rostedt
2014-07-23 15:35 ` Nick Krause
2014-07-23 16:07 ` Steven Rostedt
2014-07-23 16:19 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDOMVjaf+vne4vbUPo8EPs0XnQBbNm2ZOXns8fw5pkg9tRSww@mail.gmail.com \
--to=xerofoify@gmail.com \
--cc=bjorn@mork.no \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).