From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09C6C43461 for ; Mon, 7 Sep 2020 10:08:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6294E207C3 for ; Mon, 7 Sep 2020 10:08:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O2L0eLGd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728564AbgIGKIT (ORCPT ); Mon, 7 Sep 2020 06:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728548AbgIGKII (ORCPT ); Mon, 7 Sep 2020 06:08:08 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A8E6C061575 for ; Mon, 7 Sep 2020 03:08:08 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id c127so1373281vsc.1 for ; Mon, 07 Sep 2020 03:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dZ0cXtIu18O1k22F/ZDQa/bXyptLZb81gkafcnjYNcM=; b=O2L0eLGdR+6+ZhRzQIz42SKnDGT0lu7O6LKXrLLcRyWaY3A4BOwdgSFgeWg0bN/Efh Fak+f85L/g4Qpl1UXC9ta/tPAic75s2ru0IsLhvDD2XT0lreXQnG2ksFAt+N7DJC4PPi wFXZ9JNFr9qbD8MbzUBRhihO6wvFInG8xlAksZhYEBTIuKx37atFH1d1LsgK4GPU86nj ntwGoA9ZTlttMtr4Shq+5qxC2Je3wJUNjtyK4S35317lToJbFRdKk5QfAkZfAFYxeGNP dLMfjTTk1zo1FLQYxPqUOg6XydIgz4lUKW6utGB7GnMK2FNEU3y6QkiZCiXYZSJ4NHbq cTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dZ0cXtIu18O1k22F/ZDQa/bXyptLZb81gkafcnjYNcM=; b=KNQePcaC4sYCWSY+9+Xx6aJoUq3PLleB0lish7ox/eOf/rbGVoT2Fi2/N5O7U+Tdro D9iqhGL5cOGqLV+apwNTfu63Cl+OQ1IzaCWwQaVlSOzzYUGsoxuXmx7ybErvx/j7bZT6 ER+QirDClzWn1P717BNObJYFT5YIU4xeO98N9OZTvDLxoOZUPXAKBh4ZVmnRXoQJmIzX DY12IT92qNdclLekzYLp3eqJZ2crWHFp+04A8xYdryojB86EKaueuGECky82FkDQ/96C ccB3aVq7n8n2LVJT3idjUroPOWEbQOoK3Mc4D9X1L02cPcnACdzycQfAEWIwatqtLX8Q bHHA== X-Gm-Message-State: AOAM530fJmTvc2xTuCANEHsp7WHu3reqiBz0Qa6gZ+a4rRJiyKZCZ8jm AufYBe5QXKZWVG39bNn2tsxDNjIwWZgfsHWx6ShivQ== X-Google-Smtp-Source: ABdhPJzK8imxVzFICBf5slUvnoT+nIGcFmxhDDZ+N5lgeyXxY/MWgnT4W+c7RvwPtr/PAV7TEjJg1KFBqInVadg+qOY= X-Received: by 2002:a67:308c:: with SMTP id w134mr10855802vsw.8.1599473287226; Mon, 07 Sep 2020 03:08:07 -0700 (PDT) MIME-Version: 1.0 References: <20200904164315.24618-1-krzk@kernel.org> <20200904164315.24618-2-krzk@kernel.org> In-Reply-To: <20200904164315.24618-2-krzk@kernel.org> From: Ulf Hansson Date: Mon, 7 Sep 2020 12:07:30 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] mmc: host: Enable compile testing of multiple drivers To: Krzysztof Kozlowski Cc: Arnd Bergmann , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Manuel Lauss , Kishon Vijay Abraham I , Prabu Thangamuthu , Manjunath M B , Linux ARM , linux-samsung-soc , "open list:ARM/Amlogic Meson..." , linux-arm-msm , linux-stm32@st-md-mailman.stormreply.com, "moderated list:ARM/Mediatek SoC support" , linux-omap , linux-aspeed , linux-tegra , linux-arm-kernel@axis.com, =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Sep 2020 at 18:43, Krzysztof Kozlowski wrote: > > Multiple MMC host controller driver can be compile tested as they do not > depend on architecture specific headers. > > Signed-off-by: Krzysztof Kozlowski I tried to apply this, but there was a conflict around the SDHCI_S3C. Can you please rebase. Kind regards Uffe > > --- > > Changes since v1: > 1. Add COMMON_CLK dependency to MESON_GX to fix errors like: > ERROR: modpost: "devm_clk_register" [drivers/mmc/host/meson-gx-mmc.ko] undefined! > --- > drivers/mmc/host/Kconfig | 41 +++++++++++++++++++++------------------- > 1 file changed, 22 insertions(+), 19 deletions(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index eea01fde0591..93db789cf8ec 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -178,7 +178,7 @@ config MMC_SDHCI_OF_AT91 > config MMC_SDHCI_OF_ESDHC > tristate "SDHCI OF support for the Freescale eSDHC controller" > depends on MMC_SDHCI_PLTFM > - depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE > + depends on PPC || ARCH_MXC || ARCH_LAYERSCAPE || COMPILE_TEST > select MMC_SDHCI_IO_ACCESSORS > select FSL_GUTS > help > @@ -216,7 +216,7 @@ config MMC_SDHCI_OF_DWCMSHC > config MMC_SDHCI_OF_SPARX5 > tristate "SDHCI OF support for the MCHP Sparx5 SoC" > depends on MMC_SDHCI_PLTFM > - depends on ARCH_SPARX5 > + depends on ARCH_SPARX5 || COMPILE_TEST > help > This selects the Secure Digital Host Controller Interface (SDHCI) > found in the MCHP Sparx5 SoC. > @@ -238,7 +238,7 @@ config MMC_SDHCI_CADENCE > > config MMC_SDHCI_CNS3XXX > tristate "SDHCI support on the Cavium Networks CNS3xxx SoC" > - depends on ARCH_CNS3XXX > + depends on ARCH_CNS3XXX || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > help > This selects the SDHCI support for CNS3xxx System-on-Chip devices. > @@ -262,7 +262,7 @@ config MMC_SDHCI_ESDHC_MCF > > config MMC_SDHCI_ESDHC_IMX > tristate "SDHCI support for the Freescale eSDHC/uSDHC i.MX controller" > - depends on ARCH_MXC > + depends on ARCH_MXC || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > select MMC_SDHCI_IO_ACCESSORS > select MMC_CQHCI > @@ -276,7 +276,7 @@ config MMC_SDHCI_ESDHC_IMX > > config MMC_SDHCI_DOVE > tristate "SDHCI support on Marvell's Dove SoC" > - depends on ARCH_DOVE || MACH_DOVE > + depends on ARCH_DOVE || MACH_DOVE || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > select MMC_SDHCI_IO_ACCESSORS > help > @@ -289,7 +289,7 @@ config MMC_SDHCI_DOVE > > config MMC_SDHCI_TEGRA > tristate "SDHCI platform support for the Tegra SD/MMC Controller" > - depends on ARCH_TEGRA > + depends on ARCH_TEGRA || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > select MMC_SDHCI_IO_ACCESSORS > select MMC_CQHCI > @@ -301,7 +301,8 @@ config MMC_SDHCI_TEGRA > > config MMC_SDHCI_S3C > tristate "SDHCI support on Samsung S3C SoC" > - depends on MMC_SDHCI && (PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS) > + depends on MMC_SDHCI > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST > help > This selects the Secure Digital Host Controller Interface (SDHCI) > often referrered to as the HSMMC block in some of the Samsung S3C > @@ -313,7 +314,7 @@ config MMC_SDHCI_S3C > > config MMC_SDHCI_SIRF > tristate "SDHCI support on CSR SiRFprimaII and SiRFmarco SoCs" > - depends on ARCH_SIRF > + depends on ARCH_SIRF || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > select MMC_SDHCI_IO_ACCESSORS > help > @@ -351,7 +352,8 @@ config MMC_SDHCI_PXAV2 > > config MMC_SDHCI_SPEAR > tristate "SDHCI support on ST SPEAr platform" > - depends on MMC_SDHCI && PLAT_SPEAR > + depends on MMC_SDHCI > + depends on PLAT_SPEAR || COMPILE_TEST > depends on OF > help > This selects the Secure Digital Host Controller Interface (SDHCI) > @@ -374,7 +376,7 @@ config MMC_SDHCI_S3C_DMA > > config MMC_SDHCI_BCM_KONA > tristate "SDHCI support on Broadcom KONA platform" > - depends on ARCH_BCM_MOBILE > + depends on ARCH_BCM_MOBILE || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > help > This selects the Broadcom Kona Secure Digital Host Controller > @@ -422,7 +424,8 @@ config MMC_SDHCI_IPROC > > config MMC_MESON_GX > tristate "Amlogic S905/GX*/AXG SD/MMC Host Controller support" > - depends on ARCH_MESON > + depends on ARCH_MESON || COMPILE_TEST > + depends on COMMON_CLK > help > This selects support for the Amlogic SD/MMC Host Controller > found on the S905/GX*/AXG family of SoCs. This controller is > @@ -458,7 +461,7 @@ config MMC_MESON_MX_SDIO > > config MMC_MOXART > tristate "MOXART SD/MMC Host Controller support" > - depends on ARCH_MOXART > + depends on ARCH_MOXART || COMPILE_TEST > help > This selects support for the MOXART SD/MMC Host Controller. > MOXA provides one multi-functional card reader which can > @@ -467,7 +470,7 @@ config MMC_MOXART > > config MMC_SDHCI_ST > tristate "SDHCI support on STMicroelectronics SoC" > - depends on ARCH_STI || FSP2 > + depends on ARCH_STI || FSP2 || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > select MMC_SDHCI_IO_ACCESSORS > help > @@ -587,7 +590,7 @@ config MMC_TIFM_SD > > config MMC_MVSDIO > tristate "Marvell MMC/SD/SDIO host driver" > - depends on PLAT_ORION > + depends on PLAT_ORION || (COMPILE_TEST && ARM) > depends on OF > help > This selects the Marvell SDIO host driver. > @@ -599,7 +602,7 @@ config MMC_MVSDIO > > config MMC_DAVINCI > tristate "TI DAVINCI Multimedia Card Interface support" > - depends on ARCH_DAVINCI > + depends on ARCH_DAVINCI || COMPILE_TEST > help > This selects the TI DAVINCI Multimedia card Interface. > If you have an DAVINCI board with a Multimedia Card slot, > @@ -628,7 +631,7 @@ config MMC_SPI > > config MMC_S3C > tristate "Samsung S3C SD/MMC Card Interface support" > - depends on ARCH_S3C24XX > + depends on ARCH_S3C24XX || COMPILE_TEST > depends on S3C24XX_DMAC > help > This selects a driver for the MCI interface found in > @@ -681,7 +684,7 @@ config MMC_SDRICOH_CS > > config MMC_SDHCI_SPRD > tristate "Spreadtrum SDIO host Controller" > - depends on ARCH_SPRD > + depends on ARCH_SPRD || COMPILE_TEST > depends on MMC_SDHCI_PLTFM > select MMC_SDHCI_IO_ACCESSORS > select MMC_HSQ > @@ -698,7 +701,7 @@ config MMC_TMIO_CORE > > config MMC_TMIO > tristate "Toshiba Mobile IO Controller (TMIO) MMC/SD function support" > - depends on MFD_TMIO || MFD_ASIC3 > + depends on MFD_TMIO || MFD_ASIC3 || COMPILE_TEST > select MMC_TMIO_CORE > help > This provides support for the SD/MMC cell found in TC6393XB, > @@ -971,7 +974,7 @@ config MMC_REALTEK_USB > > config MMC_SUNXI > tristate "Allwinner sunxi SD/MMC Host Controller support" > - depends on ARCH_SUNXI > + depends on ARCH_SUNXI || COMPILE_TEST > help > This selects support for the SD/MMC Host Controller on > Allwinner sunxi SoCs. > -- > 2.17.1 >