* [PATCH v6 01/11] ACPI / LPSS: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
@ 2019-01-05 10:05 ` Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 02/11] ata: pata_acpi: " Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:05 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Rafael J. Wysocki, Len Brown, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")', it is possible to build ACPI without any PCI support.
This code depends on PCI. Compile only when PCI is present.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/acpi/Makefile | 3 ++-
drivers/acpi/internal.h | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 7c6afc111d76..bb857421c2e8 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -41,7 +41,8 @@ acpi-y += ec.o
acpi-$(CONFIG_ACPI_DOCK) += dock.o
acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o
obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o
-acpi-y += acpi_lpss.o acpi_apd.o
+acpi-$(CONFIG_PCI) += acpi_lpss.o
+acpi-y += acpi_apd.o
acpi-y += acpi_platform.o
acpi-y += acpi_pnp.o
acpi-$(CONFIG_ARM_AMBA) += acpi_amba.o
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 7e6952edb5b0..6a9e1fb8913a 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -81,7 +81,11 @@ void acpi_debugfs_init(void);
#else
static inline void acpi_debugfs_init(void) { return; }
#endif
+#ifdef CONFIG_PCI
void acpi_lpss_init(void);
+#else
+static inline void acpi_lpss_init(void) {}
+#endif
void acpi_apd_init(void);
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 02/11] ata: pata_acpi: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:05 ` [PATCH v6 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
@ 2019-01-05 10:05 ` Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 03/11] vga-switcheroo: make " Sinan Kaya
` (8 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:05 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. PATA_ACPI is a PCI device driver but the PCI
dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
config PATA_ACPI
tristate "ACPI firmware driver for PATA"
- depends on ATA_ACPI && ATA_BMDMA
+ depends on ATA_ACPI && ATA_BMDMA && PCI
help
This option enables an ACPI method driver which drives
motherboard PATA controller interfaces through the ACPI
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 03/11] vga-switcheroo: make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:05 ` [PATCH v6 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 02/11] ata: pata_acpi: " Sinan Kaya
@ 2019-01-05 10:05 ` Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: " Sinan Kaya
` (7 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:05 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Maarten Lankhorst, Maxime Ripard,
Sean Paul, David Airlie, Daniel Vetter, open list:DRM DRIVERS,
open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO
bool "Laptop Hybrid Graphics - GPU switching support"
depends on X86
depends on ACPI
+ depends on PCI
select VGA_ARB
help
Many laptops released in 2008/9/10 have two GPUs with a multiplexer
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 04/11] platform/x86: intel_ips: make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (2 preceding siblings ...)
2019-01-05 10:05 ` [PATCH v6 03/11] vga-switcheroo: make " Sinan Kaya
@ 2019-01-05 10:05 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
` (6 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:05 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. Ipss driver is a PCI device driver but this has
not been mentioned anywhere in Kconfig.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index e3b62c2ee8d1..b36ea14b41ad 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL
config INTEL_IPS
tristate "Intel Intelligent Power Sharing"
- depends on ACPI
+ depends on ACPI && PCI
---help---
Intel Calpella platforms support dynamic power sharing between the
CPU and GPU, maximizing performance in a given TDP. This driver,
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (3 preceding siblings ...)
2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: " Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
2019-01-09 10:47 ` Rafael J. Wysocki
2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya
` (5 subsequent siblings)
10 siblings, 1 reply; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. Code relies on PCI for execution. Specify this
in the Kconfig.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b36ea14b41ad..7afb96cb1cd6 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
config INTEL_PMC_IPC
tristate "Intel PMC IPC Driver"
- depends on ACPI
+ depends on ACPI && PCI
---help---
This driver provides support for PMC control on some Intel platforms.
The PMC is an ARC processor which defines IPC commands for communication
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (4 preceding siblings ...)
2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
` (4 subsequent siblings)
10 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This driver depends on the PCI infrastructure but
the dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 7afb96cb1cd6..5e2109c54c7c 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1135,7 +1135,7 @@ config SAMSUNG_Q10
config APPLE_GMUX
tristate "Apple Gmux Driver"
- depends on ACPI
+ depends on ACPI && PCI
depends on PNP
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (5 preceding siblings ...)
2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
2019-01-07 11:19 ` Rafael J. Wysocki
2019-01-05 10:06 ` [PATCH v6 08/11] ASoC: Intel: atom: " Sinan Kaya
` (3 subsequent siblings)
10 siblings, 1 reply; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. Need CONFIG_PCI to be set in order to be able to use
this driver.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index 0582bd12a239..fba1976d5f8d 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -31,7 +31,7 @@ if INT340X_THERMAL
config INT3406_THERMAL
tristate "ACPI INT3406 display thermal driver"
- depends on ACPI_VIDEO
+ depends on ACPI_VIDEO && PCI
help
The display thermal device represents the LED/LCD display panel
that may or may not include touch support. The main function of
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (6 preceding siblings ...)
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
2019-01-07 11:15 ` Rafael J. Wysocki
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
` (2 subsequent siblings)
10 siblings, 1 reply; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This code relies on IOSF_MBI and IOSF_MBI depends
on PCI. For this reason, add a direct dependency on CONFIG_PCI to the
IOSF_MBI driver.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 99a62ba409df..bd9fd2035c55 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
default ACPI
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (7 preceding siblings ...)
2019-01-05 10:06 ` [PATCH v6 08/11] ASoC: Intel: atom: " Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
2019-01-07 11:17 ` Rafael J. Wysocki
` (3 more replies)
2019-01-05 10:06 ` [PATCH v6 10/11] x86/intel/lpss: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
10 siblings, 4 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Ulf Hansson, Adrian Hunter, Shawn Lin,
Masahiro Yamada, Paul Cercueil, Geert Uytterhoeven, Faiz Abbas,
Chunyan Zhang, Jisheng Zhang, Ludovic Barre, Arnd Bergmann,
Alex Smith, Chris Brandt, open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND...,
open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..1b9401fe94c0 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -116,7 +116,7 @@ config MMC_RICOH_MMC
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
- depends on MMC_SDHCI && ACPI
+ depends on MMC_SDHCI && ACPI && PCI
select IOSF_MBI if X86
help
This selects support for ACPI enumerated SDHCI controllers,
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 10/11] x86/intel/lpss: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (8 preceding siblings ...)
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
10 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. LPSS code relies on PCI infrastructure but this
dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index a1ce34864eaf..d9b6a015d037 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -618,7 +618,7 @@ config X86_INTEL_QUARK
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* [PATCH v6 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit
[not found] <20190105100606.6673-1-okaya@kernel.org>
` (9 preceding siblings ...)
2019-01-05 10:06 ` [PATCH v6 10/11] x86/intel/lpss: " Sinan Kaya
@ 2019-01-05 10:06 ` Sinan Kaya
10 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. IOSF_CORE depends on PCI. For this reason, add a
direct dependency on CONFIG_PCI.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index fba1976d5f8d..2acddf8fb314 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -4,7 +4,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.19.0
^ permalink raw reply related [flat|nested] 29+ messages in thread
* Re: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 08/11] ASoC: Intel: atom: " Sinan Kaya
@ 2019-01-07 11:15 ` Rafael J. Wysocki
2019-01-07 12:19 ` Mark Brown
2019-01-07 15:13 ` Sinan Kaya
0 siblings, 2 replies; 29+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 11:15 UTC (permalink / raw)
To: Sinan Kaya, Mark Brown
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This code relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency on CONFIG_PCI to the
> IOSF_MBI driver.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
> ---
> sound/soc/intel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 99a62ba409df..bd9fd2035c55 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
> config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> default ACPI
> - depends on X86 && ACPI
> + depends on X86 && ACPI && PCI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
> --
Mark, assuming that the ACK above was given here, do you want me to
take this patch or do you want to take care of it yourself?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
@ 2019-01-07 11:17 ` Rafael J. Wysocki
2019-01-07 12:42 ` Adrian Hunter
2019-01-08 13:27 ` Arnd Bergmann
` (2 subsequent siblings)
3 siblings, 1 reply; 29+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 11:17 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Adrian Hunter, Shawn Lin, Masahiro Yamada, Paul Cercueil,
Geert Uytterhoeven, Faiz Abbas, Chunyan Zhang, Jisheng Zhang,
Ludovic Barre, Arnd Bergmann, Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list
On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..1b9401fe94c0 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> - depends on MMC_SDHCI && ACPI
> + depends on MMC_SDHCI && ACPI && PCI
> select IOSF_MBI if X86
> help
> This selects support for ACPI enumerated SDHCI controllers,
> --
Any objections against this one from anyone?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
@ 2019-01-07 11:19 ` Rafael J. Wysocki
2019-01-08 11:58 ` Zhang Rui
0 siblings, 1 reply; 29+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 11:19 UTC (permalink / raw)
To: Sinan Kaya, Zhang Rui
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
Eduardo Valentin, Daniel Lezcano, Amit Kucheria,
open list:THERMAL, open list
On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. Need CONFIG_PCI to be set in order to be able to use
> this driver.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
> index 0582bd12a239..fba1976d5f8d 100644
> --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> @@ -31,7 +31,7 @@ if INT340X_THERMAL
>
> config INT3406_THERMAL
> tristate "ACPI INT3406 display thermal driver"
> - depends on ACPI_VIDEO
> + depends on ACPI_VIDEO && PCI
> help
> The display thermal device represents the LED/LCD display panel
> that may or may not include touch support. The main function of
> --
Rui, any objections here? And for the [11/11]?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-07 11:15 ` Rafael J. Wysocki
@ 2019-01-07 12:19 ` Mark Brown
2019-01-07 15:16 ` Sinan Kaya
2019-01-07 15:13 ` Sinan Kaya
1 sibling, 1 reply; 29+ messages in thread
From: Mark Brown @ 2019-01-07 12:19 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Sinan Kaya, Linux-Next Mailing List, ACPI Devel Maling List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Mon, Jan 07, 2019 at 12:15:35PM +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
Yes. I've also applied it already and it's *still* being sent without
either a cover letter or the rest of the series :(
Sinan:
Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code. Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-07 11:17 ` Rafael J. Wysocki
@ 2019-01-07 12:42 ` Adrian Hunter
2019-01-07 12:48 ` Shah, Nehal-bakulchandra
2019-01-09 2:10 ` Wang, Dongsheng
0 siblings, 2 replies; 29+ messages in thread
From: Adrian Hunter @ 2019-01-07 12:42 UTC (permalink / raw)
To: Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Shawn Lin, Masahiro Yamada, Paul Cercueil, Geert Uytterhoeven,
Faiz Abbas, Chunyan Zhang, Jisheng Zhang, Ludovic Barre,
Arnd Bergmann, Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list, Wang Dongsheng, Shah Nehal-Bakulchandra, Philip Elcan
On 7/01/19 1:17 PM, Rafael J. Wysocki wrote:
> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>>
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
>> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>> drivers/mmc/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index e26b8145efb3..1b9401fe94c0 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>>
>> config MMC_SDHCI_ACPI
>> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
>> - depends on MMC_SDHCI && ACPI
>> + depends on MMC_SDHCI && ACPI && PCI
>> select IOSF_MBI if X86
>> help
>> This selects support for ACPI enumerated SDHCI controllers,
>> --
>
> Any objections against this one from anyone?
+ QCOM and AMD contributors
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-07 12:42 ` Adrian Hunter
@ 2019-01-07 12:48 ` Shah, Nehal-bakulchandra
2019-01-09 2:10 ` Wang, Dongsheng
1 sibling, 0 replies; 29+ messages in thread
From: Shah, Nehal-bakulchandra @ 2019-01-07 12:48 UTC (permalink / raw)
To: Adrian Hunter, Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Shawn Lin, Masahiro Yamada, Paul Cercueil, Geert Uytterhoeven,
Faiz Abbas, Chunyan Zhang, Jisheng Zhang, Ludovic Barre,
Arnd Bergmann, Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list, Wang Dongsheng, Philip Elcan
Hi
On 1/7/2019 6:12 PM, Adrian Hunter wrote:
> On 7/01/19 1:17 PM, Rafael J. Wysocki wrote:
>> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>>>
>>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>>> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
>>> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>>>
>>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>> ---
>>> drivers/mmc/host/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>> index e26b8145efb3..1b9401fe94c0 100644
>>> --- a/drivers/mmc/host/Kconfig
>>> +++ b/drivers/mmc/host/Kconfig
>>> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>>>
>>> config MMC_SDHCI_ACPI
>>> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
>>> - depends on MMC_SDHCI && ACPI
>>> + depends on MMC_SDHCI && ACPI && PCI
>>> select IOSF_MBI if X86
>>> help
>>> This selects support for ACPI enumerated SDHCI controllers,
>>> --
>>
>> Any objections against this one from anyone?
>
> + QCOM and AMD contributors
>
No issues with us as we have separate PCI based driver and ACPI based driver.
Regards
Nehal Shah
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-07 11:15 ` Rafael J. Wysocki
2019-01-07 12:19 ` Mark Brown
@ 2019-01-07 15:13 ` Sinan Kaya
1 sibling, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-07 15:13 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Mark Brown, Linux-Next Mailing List, ACPI Devel Maling List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
On Mon, Jan 7, 2019 at 6:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
> >
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. This code relies on IOSF_MBI and IOSF_MBI depends
> > on PCI. For this reason, add a direct dependency on CONFIG_PCI to the
> > IOSF_MBI driver.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
>
> Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
>
Yes, there was an ack assuming that I fixed the ia64 kconfig. Since I
didn't, I took it back.
Later ia64 failure was fixed by another patchset and Pierre-Louis said
"looks good to me". I didn't
assume it was an ack unless explicitly stated.
It might be good if Pierre-Louis acked this version instead.
> > ---
> > sound/soc/intel/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> > index 99a62ba409df..bd9fd2035c55 100644
> > --- a/sound/soc/intel/Kconfig
> > +++ b/sound/soc/intel/Kconfig
> > @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
> > config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> > tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> > default ACPI
> > - depends on X86 && ACPI
> > + depends on X86 && ACPI && PCI
> > select SND_SST_IPC_ACPI
> > select SND_SST_ATOM_HIFI2_PLATFORM
> > select SND_SOC_ACPI_INTEL_MATCH
> > --
>
> Mark, assuming that the ACK above was given here, do you want me to
> take this patch or do you want to take care of it yourself?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-07 12:19 ` Mark Brown
@ 2019-01-07 15:16 ` Sinan Kaya
2019-01-07 15:41 ` Mark Brown
0 siblings, 1 reply; 29+ messages in thread
From: Sinan Kaya @ 2019-01-07 15:16 UTC (permalink / raw)
To: Mark Brown
Cc: Rafael J. Wysocki, Linux-Next Mailing List,
ACPI Devel Maling List, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
On Mon, Jan 7, 2019 at 7:19 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Jan 07, 2019 at 12:15:35PM +0100, Rafael J. Wysocki wrote:
> > On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > > Signed-off-by: Sinan Kaya <okaya@kernel.org>
>
> > Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
>
> Yes. I've also applied it already and it's *still* being sent without
> either a cover letter or the rest of the series :(
There is a cover letter but it is being sent to Linux-acpi and Linux-next only.
https://patchwork.kernel.org/cover/10749203/
This means that you are not on either of these mailing lists.
>
> Sinan:
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
I apologize. I didn't realize that you applied this already. I'll drop
this patch
in case I need to submit a new revision.
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-07 15:16 ` Sinan Kaya
@ 2019-01-07 15:41 ` Mark Brown
0 siblings, 0 replies; 29+ messages in thread
From: Mark Brown @ 2019-01-07 15:41 UTC (permalink / raw)
To: Sinan Kaya
Cc: Rafael J. Wysocki, Linux-Next Mailing List,
ACPI Devel Maling List, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On Mon, Jan 07, 2019 at 10:16:53AM -0500, Sinan Kaya wrote:
> On Mon, Jan 7, 2019 at 7:19 AM Mark Brown <broonie@kernel.org> wrote:
> > Yes. I've also applied it already and it's *still* being sent without
> > either a cover letter or the rest of the series :(
> There is a cover letter but it is being sent to Linux-acpi and Linux-next only.
> https://patchwork.kernel.org/cover/10749203/
> This means that you are not on either of these mailing lists.
No, it means that neither of those lists is going into my inbox
directly - the cover letters really need to go through the same route as
the patches to ensure that they're seen. People often read the lists at
different times to their inbox, for example I prioritize reviewing
things that are in my inbox and look at list traffic less frequently
when my inbox is busy (as it tends to be most of the time).
> I apologize. I didn't realize that you applied this already. I'll drop
> this patch
> in case I need to submit a new revision.
You should have got this mail when it was applied:
http://mailman.alsa-project.org/pipermail/alsa-devel/2019-January/143687.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
2019-01-07 11:19 ` Rafael J. Wysocki
@ 2019-01-08 11:58 ` Zhang Rui
2019-01-08 13:03 ` Sinan Kaya
0 siblings, 1 reply; 29+ messages in thread
From: Zhang Rui @ 2019-01-08 11:58 UTC (permalink / raw)
To: Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
Eduardo Valentin, Daniel Lezcano, Amit Kucheria,
open list:THERMAL, open list
On 一, 2019-01-07 at 12:19 +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
> >
> >
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built
> > without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. Need CONFIG_PCI to be set in order to be able
> > to use
> > this driver.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig
> > b/drivers/thermal/intel/int340x_thermal/Kconfig
> > index 0582bd12a239..fba1976d5f8d 100644
> > --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> > +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> > @@ -31,7 +31,7 @@ if INT340X_THERMAL
> >
> > config INT3406_THERMAL
> > tristate "ACPI INT3406 display thermal driver"
> > - depends on ACPI_VIDEO
> > + depends on ACPI_VIDEO && PCI
> > help
> > The display thermal device represents the LED/LCD display
> > panel
> > that may or may not include touch support. The main
> > function of
> > --
> Rui, any objections here? And for the [11/11]?
CONFIG_INT3406_THERMAL depends on CONFIG_INT340X_THERMAL, so IMO, patch
11 is sufficient.
thanks,
rui
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
2019-01-08 11:58 ` Zhang Rui
@ 2019-01-08 13:03 ` Sinan Kaya
0 siblings, 0 replies; 29+ messages in thread
From: Sinan Kaya @ 2019-01-08 13:03 UTC (permalink / raw)
To: Zhang Rui
Cc: Rafael J. Wysocki, Linux-Next Mailing List,
ACPI Devel Maling List, Eduardo Valentin, Daniel Lezcano,
Amit Kucheria, open list:THERMAL, open list
On Tue, Jan 8, 2019 at 6:58 AM Zhang Rui <rui.zhang@intel.com> wrote:
>
> On 一, 2019-01-07 at 12:19 +0100, Rafael J. Wysocki wrote:
> > On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
> > >
> > >
> > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built
> > > without
> > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > > specified directly. Need CONFIG_PCI to be set in order to be able
> > > to use
> > > this driver.
> > >
> > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
> > > CONFIG_PCI set")
> > > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > > ---
> > > drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig
> > > b/drivers/thermal/intel/int340x_thermal/Kconfig
> > > index 0582bd12a239..fba1976d5f8d 100644
> > > --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> > > +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> > > @@ -31,7 +31,7 @@ if INT340X_THERMAL
> > >
> > > config INT3406_THERMAL
> > > tristate "ACPI INT3406 display thermal driver"
> > > - depends on ACPI_VIDEO
> > > + depends on ACPI_VIDEO && PCI
> > > help
> > > The display thermal device represents the LED/LCD display
> > > panel
> > > that may or may not include touch support. The main
> > > function of
> > > --
> > Rui, any objections here? And for the [11/11]?
>
> CONFIG_INT3406_THERMAL depends on CONFIG_INT340X_THERMAL, so IMO, patch
> 11 is sufficient.
Yes, we can drop this patch. I found the issues in reverse order. Can
we get an ACK for 11/11?
>
> thanks,
> rui
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
2019-01-07 11:17 ` Rafael J. Wysocki
@ 2019-01-08 13:27 ` Arnd Bergmann
2019-01-14 8:32 ` Adrian Hunter
2019-01-14 11:44 ` Ulf Hansson
3 siblings, 0 replies; 29+ messages in thread
From: Arnd Bergmann @ 2019-01-08 13:27 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Adrian Hunter, Shawn Lin, Masahiro Yamada, Paul Cercueil,
Geert Uytterhoeven, Faiz Abbas, Chunyan Zhang, Jisheng Zhang,
Ludovic Barre, Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list
On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-07 12:42 ` Adrian Hunter
2019-01-07 12:48 ` Shah, Nehal-bakulchandra
@ 2019-01-09 2:10 ` Wang, Dongsheng
1 sibling, 0 replies; 29+ messages in thread
From: Wang, Dongsheng @ 2019-01-09 2:10 UTC (permalink / raw)
To: Adrian Hunter, Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Shawn Lin, Masahiro Yamada, Paul Cercueil, Geert Uytterhoeven,
Faiz Abbas, Chunyan Zhang, Jisheng Zhang, Ludovic Barre,
Arnd Bergmann, Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list, Shah Nehal-Bakulchandra, Philip Elcan
On 2019/1/7 20:43, Adrian Hunter wrote:
> On 7/01/19 1:17 PM, Rafael J. Wysocki wrote:
>> On Sat, Jan 5, 2019 at 11:06 AM Sinan Kaya <okaya@kernel.org> wrote:
>>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>>> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
>>> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>>>
>>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>> ---
>>> drivers/mmc/host/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>> index e26b8145efb3..1b9401fe94c0 100644
>>> --- a/drivers/mmc/host/Kconfig
>>> +++ b/drivers/mmc/host/Kconfig
>>> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>>>
>>> config MMC_SDHCI_ACPI
>>> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
>>> - depends on MMC_SDHCI && ACPI
>>> + depends on MMC_SDHCI && ACPI && PCI
>>> select IOSF_MBI if X86
>>> help
>>> This selects support for ACPI enumerated SDHCI controllers,
>>> --
>> Any objections against this one from anyone?
> + QCOM and AMD contributors
>
No issue with QCOM.
Cheers
Dongsheng
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
@ 2019-01-09 10:47 ` Rafael J. Wysocki
2019-01-09 11:10 ` Andy Shevchenko
0 siblings, 1 reply; 29+ messages in thread
From: Rafael J. Wysocki @ 2019-01-09 10:47 UTC (permalink / raw)
To: Sinan Kaya, Andy Shevchenko
Cc: linux-next, linux-acpi, Darren Hart,
open list:X86 PLATFORM DRIVERS, open list
On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. Code relies on PCI for execution. Specify this
> in the Kconfig.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index b36ea14b41ad..7afb96cb1cd6 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
>
> config INTEL_PMC_IPC
> tristate "Intel PMC IPC Driver"
> - depends on ACPI
> + depends on ACPI && PCI
> ---help---
> This driver provides support for PMC control on some Intel platforms.
> The PMC is an ARC processor which defines IPC commands for communication
Andy, you had some reservations regarding this patch IIRC.
Should I apply it?
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
2019-01-09 10:47 ` Rafael J. Wysocki
@ 2019-01-09 11:10 ` Andy Shevchenko
2019-01-15 18:40 ` Rafael J. Wysocki
0 siblings, 1 reply; 29+ messages in thread
From: Andy Shevchenko @ 2019-01-09 11:10 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Sinan Kaya, Andy Shevchenko, linux-next, ACPI Devel Maling List,
Darren Hart, open list:X86 PLATFORM DRIVERS, open list
On Wed, Jan 9, 2019 at 12:48 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote:
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. Code relies on PCI for execution. Specify this
> > in the Kconfig.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/platform/x86/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index b36ea14b41ad..7afb96cb1cd6 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
> >
> > config INTEL_PMC_IPC
> > tristate "Intel PMC IPC Driver"
> > - depends on ACPI
> > + depends on ACPI && PCI
> > ---help---
> > This driver provides support for PMC control on some Intel platforms.
> > The PMC is an ARC processor which defines IPC commands for communication
>
> Andy, you had some reservations regarding this patch IIRC.
>
> Should I apply it?
Let's do it as a quick fix with something like below being added to
the commit message:
"For sake of a quick fix this introduces a new mandatory dependency to
the driver which may survive without it. Otherwise we need to revisit
the driver architecture to address this properly."
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
2019-01-07 11:17 ` Rafael J. Wysocki
2019-01-08 13:27 ` Arnd Bergmann
@ 2019-01-14 8:32 ` Adrian Hunter
2019-01-14 11:44 ` Ulf Hansson
3 siblings, 0 replies; 29+ messages in thread
From: Adrian Hunter @ 2019-01-14 8:32 UTC (permalink / raw)
To: Sinan Kaya, linux-next
Cc: linux-acpi, Ulf Hansson, Shawn Lin, Masahiro Yamada,
Paul Cercueil, Geert Uytterhoeven, Faiz Abbas, Chunyan Zhang,
Jisheng Zhang, Ludovic Barre, Arnd Bergmann, Alex Smith,
Chris Brandt, open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND...,
open list
On 5/01/19 12:06 PM, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..1b9401fe94c0 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> - depends on MMC_SDHCI && ACPI
> + depends on MMC_SDHCI && ACPI && PCI
> select IOSF_MBI if X86
> help
> This selects support for ACPI enumerated SDHCI controllers,
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
` (2 preceding siblings ...)
2019-01-14 8:32 ` Adrian Hunter
@ 2019-01-14 11:44 ` Ulf Hansson
3 siblings, 0 replies; 29+ messages in thread
From: Ulf Hansson @ 2019-01-14 11:44 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, ACPI Devel Maling List, Adrian Hunter, Shawn Lin,
Masahiro Yamada, Paul Cercueil, Geert Uytterhoeven, Faiz Abbas,
Chunyan Zhang, Jisheng Zhang, Ludovic Barre, Arnd Bergmann,
Alex Smith, Chris Brandt, open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND...,
open list
On Sat, 5 Jan 2019 at 11:06, Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..1b9401fe94c0 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> - depends on MMC_SDHCI && ACPI
> + depends on MMC_SDHCI && ACPI && PCI
> select IOSF_MBI if X86
> help
> This selects support for ACPI enumerated SDHCI controllers,
> --
> 2.19.0
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
2019-01-09 11:10 ` Andy Shevchenko
@ 2019-01-15 18:40 ` Rafael J. Wysocki
0 siblings, 0 replies; 29+ messages in thread
From: Rafael J. Wysocki @ 2019-01-15 18:40 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Sinan Kaya, Andy Shevchenko, linux-next, ACPI Devel Maling List,
Darren Hart, open list:X86 PLATFORM DRIVERS, open list
On Wednesday, January 9, 2019 12:10:45 PM CET Andy Shevchenko wrote:
> On Wed, Jan 9, 2019 at 12:48 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote:
> > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > > specified directly. Code relies on PCI for execution. Specify this
> > > in the Kconfig.
> > >
> > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > > ---
> > > drivers/platform/x86/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > > index b36ea14b41ad..7afb96cb1cd6 100644
> > > --- a/drivers/platform/x86/Kconfig
> > > +++ b/drivers/platform/x86/Kconfig
> > > @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
> > >
> > > config INTEL_PMC_IPC
> > > tristate "Intel PMC IPC Driver"
> > > - depends on ACPI
> > > + depends on ACPI && PCI
> > > ---help---
> > > This driver provides support for PMC control on some Intel platforms.
> > > The PMC is an ARC processor which defines IPC commands for communication
> >
> > Andy, you had some reservations regarding this patch IIRC.
> >
> > Should I apply it?
>
> Let's do it as a quick fix with something like below being added to
> the commit message:
>
> "For sake of a quick fix this introduces a new mandatory dependency to
> the driver which may survive without it. Otherwise we need to revisit
> the driver architecture to address this properly."
Done, thanks!
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2019-01-15 18:41 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:05 ` [PATCH v6 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 02/11] ata: pata_acpi: " Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 03/11] vga-switcheroo: make " Sinan Kaya
2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2019-01-09 10:47 ` Rafael J. Wysocki
2019-01-09 11:10 ` Andy Shevchenko
2019-01-15 18:40 ` Rafael J. Wysocki
2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2019-01-07 11:19 ` Rafael J. Wysocki
2019-01-08 11:58 ` Zhang Rui
2019-01-08 13:03 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 08/11] ASoC: Intel: atom: " Sinan Kaya
2019-01-07 11:15 ` Rafael J. Wysocki
2019-01-07 12:19 ` Mark Brown
2019-01-07 15:16 ` Sinan Kaya
2019-01-07 15:41 ` Mark Brown
2019-01-07 15:13 ` Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 09/11] mmc: sdhci-acpi: " Sinan Kaya
2019-01-07 11:17 ` Rafael J. Wysocki
2019-01-07 12:42 ` Adrian Hunter
2019-01-07 12:48 ` Shah, Nehal-bakulchandra
2019-01-09 2:10 ` Wang, Dongsheng
2019-01-08 13:27 ` Arnd Bergmann
2019-01-14 8:32 ` Adrian Hunter
2019-01-14 11:44 ` Ulf Hansson
2019-01-05 10:06 ` [PATCH v6 10/11] x86/intel/lpss: " Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).