From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC8AC2B9F8 for ; Tue, 25 May 2021 09:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5853F613F7 for ; Tue, 25 May 2021 09:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbhEYJH7 (ORCPT ); Tue, 25 May 2021 05:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232171AbhEYJHw (ORCPT ); Tue, 25 May 2021 05:07:52 -0400 Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A9F8C061756 for ; Tue, 25 May 2021 02:06:23 -0700 (PDT) Received: by mail-ua1-x92c.google.com with SMTP id c6so9722688uat.0 for ; Tue, 25 May 2021 02:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W24PiGNXNex8TSJmeSkCuTzb+uJdL2zsMiFv8BFcFvc=; b=HZDJYKmF2kWGMUczQAf7ma7GkNX/N8HRLLGvXuz1bsSNCRPtdZu3EXxCcOyOSf85rR 2+5IzEiRw6mSBNaqUZQSZILbj5l8TepV7yh1yRteMeIOSXAzSTACleiyI1U2/x4IML4b V/QFV3bz2ohxOh+9AwcpCiBBsuUFkdep4LpOSoQO/8V/LfiePEue6hTluOoNohrc/o+K M0bv/FoGoua8irhKUYw9RKSiMdnfD+3vBZc0XR9puX90dGNHGKPvlHS0KAKqxirRMCag IwvIx7aYUGf3kzlwZkjCgQexSo6Dp1Zr/Ost8X8MKIDrse+AI3BK24S8nhz1dgQL9fRH 9Bxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W24PiGNXNex8TSJmeSkCuTzb+uJdL2zsMiFv8BFcFvc=; b=rvSsCUIq2rgrARNVkgasrdngBvjWPlgWvmLJm4PHoNDpq8mTEMLX78VwCNUzbKdZ8o yOiYwkJQqh4KUR96rvh5ZPzJkTlmo3ggeUzJgr47unSDW+95ZmrGKvno439ixHPWjShc 2g324jqQ67Tp/C9ETyM5H00ruKVb4fbFpR0Y4z9ueaLShW9Vk8aUyc6AAhUAWkOqbN3E abbtRXJ/DOg+2vAmzYXzlbl92n0fch89hCudOJYCWL4K6ausnHOGEo+9ip0ku67W/mZF 2TU728eIO9ffTIWs8TBuFC0rE6x4h7AS5WuFQjwlWmT4nmMeAX6v3Lu4ah3uOXDX47Qb bwtw== X-Gm-Message-State: AOAM533TD2dUJ75OJPA7Xt8a9AyLh3Mg3FBKTXrgvidFjEDIofz1f3GE OfoHOSW6B+P/8k5YdIau+kRGb2pJaaBr4Sf+Czufvw== X-Google-Smtp-Source: ABdhPJxND4NykTeUoiZAJAAT0/jKOMNPPZs/Q6+XppZjXFFy+td+8fD27dD6EmHK4M+SeG97qhaTRwwMIQ17La85RMo= X-Received: by 2002:ab0:12a:: with SMTP id 39mr26031839uak.19.1621933582381; Tue, 25 May 2021 02:06:22 -0700 (PDT) MIME-Version: 1.0 References: <20210517130823.796963-1-anup.patel@wdc.com> <20210517130823.796963-6-anup.patel@wdc.com> In-Reply-To: From: Ulf Hansson Date: Tue, 25 May 2021 11:05:45 +0200 Message-ID: Subject: Re: [RFC PATCH v4 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver To: Anup Patel Cc: Anup Patel , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , "Rafael J . Wysocki" , Pavel Machek , Rob Herring , Sandeep Tripathy , Atish Patra , Alistair Francis , Liush , DTML , linux-riscv , Linux Kernel Mailing List , Linux PM , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 May 2021 at 07:39, Anup Patel wrote: > > On Mon, May 24, 2021 at 11:31 PM Ulf Hansson wrote: > > > > On Mon, 17 May 2021 at 15:10, Anup Patel wrote: > > > > > > The generic power domain related code in PSCI domain driver is largely > > > independent of PSCI and can be shared with RISC-V SBI domain driver > > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > > > Signed-off-by: Anup Patel > > > > This is clearly a big step in the right direction. Just a couple minor > > things, see more below. > > > > Note that, I have a couple of patches in the pipe for the > > cpuidle-psci-domain driver (not ready to be posted). I need a couple > > of more days to confirm this restructuring still makes sense beyond > > these potential new changes. I will let you know as soon as I can with > > the outcome. > > Sure, I will wait for more comments from you. I was thinking of sending > next revision of patches sometime next week with the renaming of > function names which you suggested. Sounds good, that allows me a few more days this week. > > > > > [...] > > > > > diff --git a/drivers/cpuidle/dt_idle_genpd.c b/drivers/cpuidle/dt_idle_genpd.c > > > > I think it would be a good idea to add a new section for this to the > > MAINTAINERS file. Perhaps a "DT IDLE DOMAIN" section? Or perhaps you > > have another idea? > > > > In any case, I am happy to continue with maintenance of this code, > > even in the new restructured form. > > Yes, a separate "DT IDLE DOMAIN" section in MAINTAINERS file > sounds good to me. > > Anyway the dt_idle_genpd is factored-out code from cpuidle-psci-domain.c > so I suggest you to maintain dt_idle_genpd as well. > > Do you want me to add a "DT IDLE DOMAIN" section in the > MAINTAINERS file as part of this patch ?? Yeah, that works for me. Perhaps extend it to .. PM DOMAIN though. [...] Kind regards Uffe