From: Ulf Hansson <ulf.hansson@linaro.org>
To: Raul E Rangel <rrangel@chromium.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Akshu Agrawal <Akshu.Agrawal@amd.com>,
chris.wang@amd.com, "Shah,
Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>,
lkml <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2] mmc: sdhci-acpi: Fix HS400 tuning for AMDI0040
Date: Fri, 21 Aug 2020 11:03:52 +0200 [thread overview]
Message-ID: <CAPDyKFoHW=taANc4UZU7spGghn8ASo+2VOiEVPNRh9URdeyQpA@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KC3BC4bbh9YF1r3nfOAJgQp4mVZJ11_77cwFJY9fGK-Dg@mail.gmail.com>
On Fri, 21 Aug 2020 at 02:24, Nicolas Boichat <drinkcat@chromium.org> wrote:
>
> On Thu, Aug 20, 2020 at 3:00 AM Raul E Rangel <rrangel@chromium.org> wrote:
> >
> > The AMD eMMC Controller can only use the tuned clock while in HS200 and
> > HS400 mode. If we switch to a different mode, we need to disable the
> > tuned clock. If we have previously performed tuning and switch back to
> > HS200 or HS400, we can re-enable the tuned clock.
> >
> > Previously the tuned clock was not getting disabled when switching to
> > DDR52 which is part of the HS400 tuning sequence.
> >
> > Fixes: 34597a3f60b1 ("mmc: sdhci-acpi: Add support for ACPI HID of AMD Controller with HS400")
> > Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Applied for fixes, by dropping the trace_printk below, thanks!
Kind regards
Uffe
> > ---
> >
> > Changes in v2:
> > - Added static to amd_sdhci_execute_tuning
> >
> > drivers/mmc/host/sdhci-acpi.c | 68 +++++++++++++++++++++++++++++------
> > 1 file changed, 58 insertions(+), 10 deletions(-)
> [snip]
> > + /* DLL is only required for HS400 */
> > + if (host->timing == MMC_TIMING_MMC_HS400 &&
> > + !amd_host->dll_enabled) {
> > + trace_printk("%s: Enabling DLL\n", __func__);
>
> Please do not use trace_printk in production code [1,2], it is only
> meant for debug use. Consider using dev_dbg.
>
> [1] https://elixir.bootlin.com/linux/v5.8/source/kernel/trace/trace.c#L3158
> [2] https://elixir.bootlin.com/linux/v5.8/source/include/linux/kernel.h#L766
>
> > + sdhci_acpi_amd_hs400_dll(host);
> > + amd_host->dll_enabled = true;
> > + }
> > }
next prev parent reply other threads:[~2020-08-21 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 19:00 [PATCH v2] mmc: sdhci-acpi: Fix HS400 tuning for AMDI0040 Raul E Rangel
2020-08-21 0:24 ` Nicolas Boichat
2020-08-21 9:03 ` Ulf Hansson [this message]
[not found] ` <CAHQZ30BW4YMzK9KUOHP8wV49Yw0UG_PZY6UdaQZdQRdMYFjFwQ@mail.gmail.com>
2020-08-21 21:56 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFoHW=taANc4UZU7spGghn8ASo+2VOiEVPNRh9URdeyQpA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=Akshu.Agrawal@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=adrian.hunter@intel.com \
--cc=chris.wang@amd.com \
--cc=drinkcat@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).