From: Ulf Hansson <ulf.hansson@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 2/3] PM / Domains: Add support for 'assigned-performance-states'
Date: Wed, 12 Aug 2020 11:37:03 +0200 [thread overview]
Message-ID: <CAPDyKFoRv49jKi-4UW6EVyAzo1emb=rs2h7CWavON+JoXXh1kA@mail.gmail.com> (raw)
In-Reply-To: <1596541616-27688-3-git-send-email-rnayak@codeaurora.org>
On Tue, 4 Aug 2020 at 13:47, Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> For devices which have 'assigned-performance-states' specified in DT,
> set the specified performance state during attach and drop it on detach.
> Also drop/set as part of runtime suspend/resume callbacks.
To allow flexibility, I would prefer to keep the performance state
being orthogonal to the power on/off state for a genpd.
Therefore, I am wondering if this is better handled by the consumer
driver instead?
Kind regards
Uffe
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> drivers/base/power/domain.c | 27 +++++++++++++++++++++++++++
> include/linux/pm_domain.h | 1 +
> 2 files changed, 28 insertions(+)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 0a01df60..8704823 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -810,6 +810,10 @@ static int genpd_runtime_suspend(struct device *dev)
> if (irq_safe_dev_in_no_sleep_domain(dev, genpd))
> return 0;
>
> + /* Drop the assigned performance state */
> + if (dev_gpd_data(dev)->assigned_pstate)
> + dev_pm_genpd_set_performance_state(dev, 0);
> +
> genpd_lock(genpd);
> genpd_power_off(genpd, true, 0);
> genpd_unlock(genpd);
> @@ -829,6 +833,7 @@ static int genpd_runtime_resume(struct device *dev)
> {
> struct generic_pm_domain *genpd;
> struct gpd_timing_data *td = &dev_gpd_data(dev)->td;
> + unsigned int assigned_pstate = dev_gpd_data(dev)->assigned_pstate;
> bool runtime_pm = pm_runtime_enabled(dev);
> ktime_t time_start;
> s64 elapsed_ns;
> @@ -857,6 +862,9 @@ static int genpd_runtime_resume(struct device *dev)
> if (ret)
> return ret;
>
> + /* Set the assigned performance state */
> + if (assigned_pstate)
> + dev_pm_genpd_set_performance_state(dev, assigned_pstate);
> out:
> /* Measure resume latency. */
> time_start = 0;
> @@ -890,6 +898,8 @@ static int genpd_runtime_resume(struct device *dev)
> err_poweroff:
> if (!pm_runtime_is_irq_safe(dev) ||
> (pm_runtime_is_irq_safe(dev) && genpd_is_irq_safe(genpd))) {
> + if (assigned_pstate)
> + dev_pm_genpd_set_performance_state(dev, 0);
> genpd_lock(genpd);
> genpd_power_off(genpd, true, 0);
> genpd_unlock(genpd);
> @@ -2405,6 +2415,12 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off)
>
> dev_dbg(dev, "removing from PM domain %s\n", pd->name);
>
> + /* Drop the assigned performance state */
> + if (dev_gpd_data(dev)->assigned_pstate) {
> + dev_pm_genpd_set_performance_state(dev, 0);
> + dev_gpd_data(dev)->assigned_pstate = 0;
> + }
> +
> for (i = 1; i < GENPD_RETRY_MAX_MS; i <<= 1) {
> ret = genpd_remove_device(pd, dev);
> if (ret != -EAGAIN)
> @@ -2442,6 +2458,7 @@ static void genpd_dev_pm_sync(struct device *dev)
> static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
> unsigned int index, bool power_on)
> {
> + unsigned int assigned_pstate;
> struct of_phandle_args pd_args;
> struct generic_pm_domain *pd;
> int ret;
> @@ -2485,6 +2502,16 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
> if (ret)
> genpd_remove_device(pd, dev);
>
> + /* Set the assigned performance state */
> + if (!of_property_read_u32_index(base_dev->of_node,
> + "assigned-performance-states",
> + index, &assigned_pstate)) {
> + if (assigned_pstate) {
> + dev_pm_genpd_set_performance_state(dev, assigned_pstate);
> + dev_gpd_data(dev)->assigned_pstate = assigned_pstate;
> + }
> + }
> +
> return ret ? -EPROBE_DEFER : 1;
> }
>
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index 9ec78ee..4a415ee 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -180,6 +180,7 @@ struct generic_pm_domain_data {
> struct notifier_block nb;
> int cpu;
> unsigned int performance_state;
> + unsigned int assigned_pstate;
> void *data;
> };
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2020-08-12 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 11:46 [PATCH 0/3] Add support for assigned-performance-states Rajendra Nayak
2020-08-04 11:46 ` [PATCH 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property Rajendra Nayak
2020-08-05 6:39 ` Stephen Boyd
2020-08-05 8:13 ` Rajendra Nayak
2020-08-05 23:57 ` Stephen Boyd
2020-08-04 11:46 ` [PATCH 2/3] PM / Domains: Add support for 'assigned-performance-states' Rajendra Nayak
2020-08-12 9:37 ` Ulf Hansson [this message]
2020-08-04 11:46 ` [PATCH 3/3] arm64: dts: sc7180: Add assigned-performance-states for i2c Rajendra Nayak
2020-08-05 6:41 ` Stephen Boyd
2020-08-05 8:14 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFoRv49jKi-4UW6EVyAzo1emb=rs2h7CWavON+JoXXh1kA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).