From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9A3AC55189 for ; Wed, 22 Apr 2020 10:39:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97C0420656 for ; Wed, 22 Apr 2020 10:39:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UooOANnk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbgDVKjl (ORCPT ); Wed, 22 Apr 2020 06:39:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730195AbgDVKjh (ORCPT ); Wed, 22 Apr 2020 06:39:37 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D3DC03C1A9 for ; Wed, 22 Apr 2020 03:39:37 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id y10so1069290uao.8 for ; Wed, 22 Apr 2020 03:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VHT7Mk3BzDO0gyW1iwYfsy8IG0PJGK/2+QKrpnZX3QU=; b=UooOANnkncazrjwT6A5IIVWXx3TaevD8levmFwktxmkLRtC+jYIawEY8VaMp9I4ome MhywIVZGwaoUBGPY2nmynUgZLZD81R8ok0ftRCcAW+neSqf3vEfUeVAeyA/GUeeumg7P L6ILsJb2XCIn45d8r+UvPw1okUg71V8TyiPjv4fC1fW0VKrExn9ARhgnMb3ZdG/83MDd xQgdiafbDTuwRkn0Yl97Ukuzw1I+VXvJUUiTW496N/uhyINL2t2sW9sYMaDS7sCPrRMH 4yOPaYEUMVQ2YQKIRv18eAvijqXFHMfBZ2hCpbxedUO7XU1eeiY/wb5Dk6mFCxElL9lw JlFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VHT7Mk3BzDO0gyW1iwYfsy8IG0PJGK/2+QKrpnZX3QU=; b=hWAw+sBRRVwAKbYVoPzyqaj3clEflxo+k+ucqKC1WkrLzF/QptfIwhtTqdgbgfw9Je gvUUx5UeuvSEaD35Yqsv2WMBQ6SupoGIdPgFvT/hLbIKUrAYz2KVo+Dq6mcBrjC5g2pL xFeok4Q5ooiTNUxb9V/VyEZDFvnDgvMA4HS3XPt67IY86z6ApzeAA24+0oH47Sx5fLv4 K+3UBJwJtFXJwPjnpZU00QbvT/MRGmBTK57QLUukBXqhkYTZ5k6IZiQP5FhjhRGAAX/v oX7hh8Ur4TSBDIFXc/1NNTKm8f5KTpr88Hch0mibNP1AA9FyCMFvwbU8LvwwAj7ym3Bt 0UZA== X-Gm-Message-State: AGi0PubmVb7HfEInMi9CFOo7N5EA5d57BdRNJ9AJKfqG+ONPdZ/mV5EZ qURK1UCMDWX5stnZxnQOu06y+E53fx6ipy6CBbC7SQ== X-Google-Smtp-Source: APiQypKbq2XGjzlmevXUc1yOHOUstc2Fw4sHPY9uc/yPKfLYTlRgn/XYeQqIlHCt8Ee7WqRUnRo8oGo4FnJUwdd8B7E= X-Received: by 2002:a67:8b46:: with SMTP id n67mr8244570vsd.35.1587551976321; Wed, 22 Apr 2020 03:39:36 -0700 (PDT) MIME-Version: 1.0 References: <20200409064416.83340-1-sboyd@kernel.org> <20200409064416.83340-7-sboyd@kernel.org> <158755046077.159702.10648240040343779828@swboyd.mtv.corp.google.com> In-Reply-To: <158755046077.159702.10648240040343779828@swboyd.mtv.corp.google.com> From: Ulf Hansson Date: Wed, 22 Apr 2020 12:39:00 +0200 Message-ID: Subject: Re: [PATCH v2 06/10] mmc: meson-mx-sdio: Depend on OF_ADDRESS and not just OF To: Stephen Boyd Cc: Michael Turquette , Linux Kernel Mailing List , linux-clk , kbuild test robot , Neil Armstrong Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Apr 2020 at 12:14, Stephen Boyd wrote: > > Quoting Ulf Hansson (2020-04-21 07:04:54) > > On Thu, 9 Apr 2020 at 08:44, Stephen Boyd wrote: > > > > > > Making COMMON_CLK a visible option causes the sparc allyesconfig to fail > > > to build like so: > > > > > > sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_remove': > > > meson-mx-sdio.c:(.text+0x70): undefined reference to `of_platform_device_destroy' > > > sparc64-linux-ld: drivers/mmc/host/meson-mx-sdio.o: in function `meson_mx_mmc_probe': > > > meson-mx-sdio.c:(.text+0x9e4): undefined reference to `of_platform_device_create' > > > sparc64-linux-ld: meson-mx-sdio.c:(.text+0xdd4): undefined reference to `of_platform_device_destroy' > > > > > > This is because the implementation of of_platform_device_destroy() is > > > inside an #ifdef CONFIG_OF_ADDRESS section of drivers/of/platform.c. > > > This driver already depends on OF being enabled, so let's tighten that > > > constrain a little more so that it depends on OF_ADDRESS instead. This > > > way we won't try to build this driver on platforms that don't have this > > > function. > > > > > > Reported-by: kbuild test robot > > > Cc: Neil Armstrong > > > Cc: Ulf Hansson > > > Signed-off-by: Stephen Boyd > > > > I don't have the complete picture here, can I just apply this a fix to > > my mmc tree? > > > > If this patch stays in the series then I can avoid a bisection hole. And > it also doesn't matter until COMMON_CLK config becomes selectable. Maybe > just ack and let it go through clk tree? Unless there's something > changing here in the mmc tree? This file is likely to change in my mmc-tree. However, let's deal with the conflict, if/when that happens. So, please pick it through your clock tree. Acked-by: Ulf Hansson Kind regards Uffe