From: Ulf Hansson <ulf.hansson@linaro.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chris Ball <chris@printf.net>, Tony Prisk <linux@prisktech.co.nz>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 33/35 linux-next] mmc: constify of_device_id array
Date: Fri, 20 Mar 2015 09:56:50 +0100 [thread overview]
Message-ID: <CAPDyKFoWoQhSat9vAfTGy_exdubcknySMPjoSXp5ox_YB+M6ZQ@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFodW1zgrQ-sd5TPO_rCa_-tm95JkwCWiGX4BCUSFqPHdg@mail.gmail.com>
On 17 March 2015 at 10:49, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 16 March 2015 at 20:59, Fabian Frederick <fabf@skynet.be> wrote:
>> of_device_id is always used as const.
>> (See driver.of_match_table and open firmware functions)
>>
>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
I realized that you might wanted me to pick this up and queue it
through my mmc tree? Just tell me if that's what you want.
Kind regards
Uffe
>
>> ---
>> drivers/mmc/host/mmc_spi.c | 2 +-
>> drivers/mmc/host/wmt-sdmmc.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
>> index e4a0754..ae19d83 100644
>> --- a/drivers/mmc/host/mmc_spi.c
>> +++ b/drivers/mmc/host/mmc_spi.c
>> @@ -1507,7 +1507,7 @@ static int mmc_spi_remove(struct spi_device *spi)
>> return 0;
>> }
>>
>> -static struct of_device_id mmc_spi_of_match_table[] = {
>> +static const struct of_device_id mmc_spi_of_match_table[] = {
>> { .compatible = "mmc-spi-slot", },
>> {},
>> };
>> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
>> index dd2e1aa..5af0055 100644
>> --- a/drivers/mmc/host/wmt-sdmmc.c
>> +++ b/drivers/mmc/host/wmt-sdmmc.c
>> @@ -744,7 +744,7 @@ static struct wmt_mci_caps wm8505_caps = {
>> .max_blk_size = 2048,
>> };
>>
>> -static struct of_device_id wmt_mci_dt_ids[] = {
>> +static const struct of_device_id wmt_mci_dt_ids[] = {
>> { .compatible = "wm,wm8505-sdhc", .data = &wm8505_caps },
>> { /* Sentinel */ },
>> };
>> --
>> 2.1.0
>>
next prev parent reply other threads:[~2015-03-20 8:56 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 19:17 [PATCH 00/35 linux-next] constify of_device_id array Fabian Frederick
2015-03-16 19:17 ` [PATCH 01/35 linux-next] ata: " Fabian Frederick
2015-03-16 22:16 ` Richard Weinberger
2015-03-17 18:48 ` Fabian Frederick
2015-03-16 19:17 ` [PATCH 02/35 linux-next] regulator: " Fabian Frederick
2015-03-17 12:11 ` Mark Brown
2015-03-17 17:10 ` Fabian Frederick
2015-03-17 17:19 ` Mark Brown
2015-03-17 17:26 ` Fabian Frederick
2015-03-19 17:44 ` Mark Brown
2015-03-16 19:17 ` [PATCH 03/35 linux-next] thermal: " Fabian Frederick
2015-03-16 19:17 ` [PATCH 04/35 linux-next] tty/hvc_opal: " Fabian Frederick
2015-03-16 19:17 ` [PATCH 05/35 linux-next] tty: " Fabian Frederick
2015-03-16 19:20 ` Timur Tabi
2015-03-16 19:51 ` Peter Korsgaard
2015-03-17 8:10 ` Patrice Chotard
2015-03-16 19:17 ` [PATCH 06/35 linux-next] power: " Fabian Frederick
2015-03-17 11:38 ` Sudeep Holla
2015-03-20 12:32 ` Sebastian Reichel
2015-03-16 19:17 ` [PATCH 07/35 linux-next] char: " Fabian Frederick
2015-03-16 19:17 ` [PATCH 08/35 linux-next] dma: " Fabian Frederick
2015-03-18 16:43 ` Vinod Koul
2015-03-16 19:17 ` [PATCH 09/35 linux-next] iio: " Fabian Frederick
2015-03-21 12:02 ` Jonathan Cameron
2015-03-16 19:20 ` [PATCH 10/35 linux-next] misc: " Fabian Frederick
2015-03-16 19:20 ` [PATCH 11/35 linux-next] usb: gadget: " Fabian Frederick
2015-03-16 19:20 ` [PATCH 12/35 linux-next] mtd: " Fabian Frederick
2015-05-07 6:44 ` Brian Norris
2015-03-16 19:20 ` [PATCH 13/35 linux-next] w1: " Fabian Frederick
2015-03-16 19:20 ` [PATCH 14/35 linux-next] ide: pmac: " Fabian Frederick
2015-03-16 19:20 ` [PATCH 15/35 linux-next] spi: " Fabian Frederick
2015-03-17 12:15 ` Mark Brown
2015-03-16 19:20 ` [PATCH 16/35 linux-next] video: " Fabian Frederick
2015-03-16 19:29 ` Timur Tabi
2015-03-16 19:20 ` [PATCH 17/35 linux-next] coresight-replicator: " Fabian Frederick
2015-03-16 19:20 ` [PATCH 18/35 linux-next] macintosh: " Fabian Frederick
2015-03-16 19:20 ` [PATCH 19/35 linux-next] virtio_mmio: " Fabian Frederick
2015-03-23 14:20 ` Pawel Moll
2015-03-16 19:21 ` [PATCH 20/35 linux-next] swim3: " Fabian Frederick
2015-03-16 19:21 ` [PATCH 21/35 linux-next] mfd: " Fabian Frederick
2015-03-23 12:29 ` Lee Jones
2015-03-16 19:54 ` [PATCH 22/35 linux-next] soc: ti: " Fabian Frederick
2015-03-16 19:54 ` [PATCH 23/35 linux-next] [media] " Fabian Frederick
2015-03-17 8:12 ` Patrice Chotard
2015-03-16 19:54 ` [PATCH 24/35 linux-next] Input: " Fabian Frederick
2015-03-18 16:59 ` Dmitry Torokhov
2015-03-16 19:54 ` [PATCH 25/35 linux-next] PCI: " Fabian Frederick
2015-03-16 20:23 ` Sergei Shtylyov
2015-03-16 20:30 ` Fabian Frederick
2015-03-16 19:54 ` [PATCH 26/35 linux-next] hwmon: " Fabian Frederick
2015-03-17 3:55 ` Guenter Roeck
2015-03-16 19:54 ` [PATCH 27/35 linux-next] reset: sti: " Fabian Frederick
2015-03-17 8:13 ` Patrice Chotard
2015-03-17 8:33 ` Maxime Coquelin
2015-03-17 9:52 ` Philipp Zabel
2015-03-16 19:54 ` [PATCH 28/35 linux-next] uio: " Fabian Frederick
2015-03-16 19:54 ` [PATCH 29/35 linux-next] gpu: " Fabian Frederick
2015-03-16 19:54 ` [PATCH 30/35 linux-next] devfreq: " Fabian Frederick
2015-03-16 19:54 ` [PATCH 31/35 linux-next] EDAC: " Fabian Frederick
2015-03-20 16:57 ` Borislav Petkov
2015-03-16 19:59 ` [PATCH 32/35 linux-next] clk: " Fabian Frederick
2015-03-16 19:59 ` [PATCH 33/35 linux-next] mmc: " Fabian Frederick
2015-03-17 9:49 ` Ulf Hansson
2015-03-20 8:56 ` Ulf Hansson [this message]
2015-03-21 20:09 ` Fabian Frederick
2015-03-23 10:06 ` Ulf Hansson
2015-03-16 19:59 ` [PATCH 34/35 linux-next] Staging: octeon: " Fabian Frederick
2015-03-16 19:59 ` [PATCH 35/35 linux-next] pinctrl: " Fabian Frederick
2015-03-17 4:03 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-17 8:15 ` Patrice Chotard
2015-03-17 8:34 ` Maxime Coquelin
2015-03-19 1:58 ` Hongzhou Yang
2015-03-19 18:41 ` Fabian Frederick
2015-03-19 20:55 ` Hongzhou Yang
2015-03-19 7:12 ` Lee Jones
2015-03-27 9:00 ` Linus Walleij
2015-03-18 14:15 ` [PATCH 32/35 linux-next] clk: " Michael Turquette
2015-03-22 10:34 ` Fabian Frederick
2015-03-27 7:19 ` Stephen Boyd
2015-03-31 19:05 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFoWoQhSat9vAfTGy_exdubcknySMPjoSXp5ox_YB+M6ZQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=chris@printf.net \
--cc=fabf@skynet.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@prisktech.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).