From: Ulf Hansson <ulf.hansson@linaro.org>
To: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Cc: adrian.hunter@intel.com, CLoehle@hyperstone.com,
brauner@kernel.org, axboe@kernel.dk,
victor.shih@genesyslogic.com.tw, f.fainelli@gmail.com,
asuk4.q@gmail.com, yibin.ding@unisoc.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: block: Use octal for file permissions
Date: Mon, 23 Oct 2023 13:42:20 +0200 [thread overview]
Message-ID: <CAPDyKFoeuVHu+Rt7kg1zbz1oFW8aCkQJ5swCbmSnA_Xrhx0eYw@mail.gmail.com> (raw)
In-Reply-To: <20231019195752.62692-1-edson.drosdeck@gmail.com>
On Thu, 19 Oct 2023 at 21:58, Edson Juliano Drosdeck
<edson.drosdeck@gmail.com> wrote:
>
> Octal permissions are preferred as stated in
> Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions
> with octal permissions when creating the files.
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Thanks for your patch!
Replacing symbolic permissions with octal permissions makes sense to
me. However, I don't want one patch per line that needs to be changed.
Instead, please go over all the files in drivers/mmc/core and fix all
of them in one patch. Another patch can be done for
drivers/mmc/hosts/*
Kind regards
Uffe
> ---
> drivers/mmc/core/block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index b5b414a71e0b..edb653d8fbfa 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
>
> if (mmc_card_mmc(card)) {
> md->ext_csd_dentry =
> - debugfs_create_file("ext_csd", S_IRUSR, root, card,
> + debugfs_create_file("ext_csd", 0400, root, card,
> &mmc_dbg_ext_csd_fops);
> }
> }
> --
> 2.39.2
>
prev parent reply other threads:[~2023-10-23 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 19:57 [PATCH] mmc: block: Use octal for file permissions Edson Juliano Drosdeck
2023-10-23 11:42 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFoeuVHu+Rt7kg1zbz1oFW8aCkQJ5swCbmSnA_Xrhx0eYw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=CLoehle@hyperstone.com \
--cc=adrian.hunter@intel.com \
--cc=asuk4.q@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=edson.drosdeck@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=victor.shih@genesyslogic.com.tw \
--cc=yibin.ding@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).