From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933452AbcIOK1L (ORCPT ); Thu, 15 Sep 2016 06:27:11 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:33599 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933311AbcIOK1J (ORCPT ); Thu, 15 Sep 2016 06:27:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160901142335.2396-1-pramod.gurav@linaro.org> <496321c5-24e7-3ac5-b3dd-7b7d5dc75536@linaro.org> From: Ulf Hansson Date: Thu, 15 Sep 2016 12:19:25 +0200 Message-ID: Subject: Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support To: Pramod Gurav Cc: Georgi Djakov , Adrian Hunter , linux-mmc , "open list:ARM/QUALCOMM SUPPORT" , open list , Ritesh Harjani , Stephen Boyd Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15 September 2016 at 09:59, Pramod Gurav wrote: > On 9 September 2016 at 15:48, Georgi Djakov wrote: >> On 09/08/2016 11:02 AM, Adrian Hunter wrote: >>> >>> On 01/09/16 17:23, Pramod Gurav wrote: >>>> >>>> Provides runtime PM callbacks to enable and disable clock resources >>>> when idle. Also support system PM callbacks to be called during system >>>> suspend and resume. >>>> >>>> Signed-off-by: Pramod Gurav >>> >>> >>> Can we get some Tested/Reviewed/Acked-by from people using this driver? >>> >> >> Hi Pramod, >> Thanks for the patch. Unfortunately, my db410c board fails to >> boot when i apply it. >> > > Thanks Georgi for testing the patch. Its my wrong I did not update my > kernel and continued fixing comments on old kernel. > After spending some time I came to know that below change is causing the issue: > > Author: Dong Aisheng > Date: Tue Jul 12 15:46:17 2016 +0800 > > mmc: sdhci: add standard hw auto retuning support > > If HW supports SDHCI_TUNING_MODE_3 which is auto retuning, we won't > retune during runtime suspend and resume, instead we use Re-tuning > Request signaled via SDHCI_INT_RETUNE interrupt to do retuning and > hw auto retuning during data transfer to guarantee the signal sample > window correction. > > This can avoid a mass of repeatedly retuning during small file system > data access and improve the performance. > > Specially these lines that was added to suspend path: > > + if (host->tuning_mode != SDHCI_TUNING_MODE_3) > + mmc_retune_needed(host->mmc); > > During sdhci setup in msm driver, the host returns the values to set > sdhci auto tuning as supported. > Hence host->tuning_mode is set to SDHCI_TUNING_MODE_3 during setup. > But some how the auto tuning is not happening. > Just to verify my case, I removed the 'if' part in above code and got > the FS mounted. > > Is there anything else needed in msm sdhci driver so that the auto > tuning is taken care of? I am not familiar with any other than sdhci-esdhc-imx which supports the SDHCI_TUNING_MODE_3. I may be wrong though. In the sdhci-esdhc-imx case, enabling of auto tuning seems to be done in esdhc_post_tuning(), where a vendor specific register (ESDHC_MIX_CTRL) is being written to. Perhaps something similar in your case? [...] Kind regards Uffe