From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754607AbaKSLEJ (ORCPT ); Wed, 19 Nov 2014 06:04:09 -0500 Received: from mail-qg0-f49.google.com ([209.85.192.49]:47072 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752903AbaKSLEG (ORCPT ); Wed, 19 Nov 2014 06:04:06 -0500 MIME-Version: 1.0 In-Reply-To: <1415904621-26800-1-git-send-email-abrestic@chromium.org> References: <1415904621-26800-1-git-send-email-abrestic@chromium.org> Date: Wed, 19 Nov 2014 12:04:05 +0100 Message-ID: Subject: Re: [PATCH] mmc: dw_mmc: Add support for IMG Pistachio From: Ulf Hansson To: Andrew Bresticker Cc: Seungwon Jeon , Jaehoon Chung , Chris Ball , James Hartley , Ezequiel Garcia , Doug Anderson , "linux-kernel@vger.kernel.org" , linux-mmc Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13 November 2014 19:50, Andrew Bresticker wrote: > Add support for the DW MMC host found on the Imagination Pistachio SoC. > Like the DW MMC hosts found on SOCFPGA and Rockchip SoCs, the DW MMC > host on Pistachio requires the use of SDMMC_CMD_USE_HOLD_REG. > > Signed-off-by: Andrew Bresticker Thanks! Applied for next. Kind regards Uffe > --- > .../devicetree/bindings/mmc/img-dw-mshc.txt | 29 ++++++++++++++++++++++ > drivers/mmc/host/dw_mmc-pltfm.c | 6 +++++ > 2 files changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/img-dw-mshc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt > new file mode 100644 > index 0000000..85de99f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt > @@ -0,0 +1,29 @@ > +* Imagination specific extensions to the Synopsys Designware Mobile Storage > + Host Controller > + > +The Synopsys designware mobile storage host controller is used to interface > +a SoC with storage medium such as eMMC or SD/MMC cards. This file documents > +differences between the core Synopsys dw mshc controller properties described > +by synopsys-dw-mshc.txt and the properties used by the Imagination specific > +extensions to the Synopsys Designware Mobile Storage Host Controller. > + > +Required Properties: > + > +* compatible: should be > + - "img,pistachio-dw-mshc": for Pistachio SoCs > + > +Example: > + > + mmc@18142000 { > + compatible = "img,pistachio-dw-mshc"; > + reg = <0x18142000 0x400>; > + interrupts = ; > + > + clocks = <&system_clk>, <&sdhost_clk>; > + clock-names = "biu", "ciu"; > + > + fifo-depth = <0x20>; > + bus-width = <4>; > + num-slots = <1>; > + disable-wp; > + }; > diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c > index 8b65721..ec6dbcd 100644 > --- a/drivers/mmc/host/dw_mmc-pltfm.c > +++ b/drivers/mmc/host/dw_mmc-pltfm.c > @@ -35,6 +35,10 @@ static const struct dw_mci_drv_data socfpga_drv_data = { > .prepare_command = dw_mci_pltfm_prepare_command, > }; > > +static const struct dw_mci_drv_data pistachio_drv_data = { > + .prepare_command = dw_mci_pltfm_prepare_command, > +}; > + > int dw_mci_pltfm_register(struct platform_device *pdev, > const struct dw_mci_drv_data *drv_data) > { > @@ -90,6 +94,8 @@ static const struct of_device_id dw_mci_pltfm_match[] = { > { .compatible = "snps,dw-mshc", }, > { .compatible = "altr,socfpga-dw-mshc", > .data = &socfpga_drv_data }, > + { .compatible = "img,pistachio-dw-mshc", > + .data = &pistachio_drv_data }, > {}, > }; > MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match); > -- > 2.1.0.rc2.206.gedb03e5 >