From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A137C47082 for ; Mon, 31 May 2021 10:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC141611CA for ; Mon, 31 May 2021 10:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbhEaKS5 (ORCPT ); Mon, 31 May 2021 06:18:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbhEaKSq (ORCPT ); Mon, 31 May 2021 06:18:46 -0400 Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63610C06174A for ; Mon, 31 May 2021 03:17:06 -0700 (PDT) Received: by mail-vs1-xe35.google.com with SMTP id u188so5764423vsu.8 for ; Mon, 31 May 2021 03:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dZlOBlSZYULypfw5/ewHC+v8ch9iaJNGfsO0EtuWzfM=; b=Y2yUwc3uTGu50MTnx/PW29KqfUP+uFZqZkHW9KemUvYqqNi5Iw8OiWOr+KH4x64vJ2 UkI4ZBbwfQMZfqHGYU1Z6RQnVO0VOnUX5Tjn2GxF6SWF9Hll3vxzQS/3esWCcC21HqMU bSodJRHUZKMVsnQdSnCRYoVxbyr1gnVumiyUBqQZat6cOkWUch0nFsldRlk7vVYst2n8 NoodRFcQ4CSva7Be76FzJkwqSLevyGU/GsQGcpV6REi4yXeyQMQR0iFMXsyCQEEjZLG/ CaRXWiwmnK9ZtXHMoaTrBqcdepmPRBbfH3fxhOKjtmwCuAgm/Al9d8XSXKJy2EE6hHk2 hXBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dZlOBlSZYULypfw5/ewHC+v8ch9iaJNGfsO0EtuWzfM=; b=NFHizwdIFG+0O9yyhwewkDqIti3dVGCUideJ99wnTwhFH84z6+8sS8b4/TJfPYrBAk Vvn26T1PQs/oeWerrACEx4gjMDVcHkKGzLjIrHjvaHdlz5EPSpP7u5C1H8k+4krbmldB CPgagD6RC07s9FWTWfNIgRM6YauUloOcaoAPzb8fW8Ld5dB61W096QihKp8qj/sOdhVW WkebT3q7j42xuzrQIrT2nTZh+dN677k7f7sgYYBW14zcDu5SnB53ozhf5n/KlK1XgCEq WlGKV47fVU8ENTLHv+VKDr2xEY05SqLh58AQ4gkFVjJB0VCcSystega7zwXADvORgHR7 fqqQ== X-Gm-Message-State: AOAM533ZdA1NreTqzfBFTLwWnk7pExM+C2ERtMqv5eQmuyDKinxJuskY OtuyP7VFX98EkNvTSUFUjwP3jae3wjJHSP0xVvujxA== X-Google-Smtp-Source: ABdhPJzgNUwfNc7KV7nrd1Dztm0iM1syumDQ3ZnEjB9Q60g7bqz7yWKku4XH8O/WDamv0wx+bkqorLwQFKUfEmeuMLU= X-Received: by 2002:a67:e915:: with SMTP id c21mr2200575vso.19.1622456225517; Mon, 31 May 2021 03:17:05 -0700 (PDT) MIME-Version: 1.0 References: <20210528112127.71738-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210528112127.71738-1-andriy.shevchenko@linux.intel.com> From: Ulf Hansson Date: Mon, 31 May 2021 12:16:29 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] mmc: mmc_spi: Drop duplicate 'mmc_spi' in the debug messages To: Andy Shevchenko Cc: linux-mmc , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 May 2021 at 13:21, Andy Shevchenko wrote: > > dev_dbg() in any case prints the device and driver name, no need > to repeat this in (some) messages. Drop duplicates for good. > > Signed-off-by: Andy Shevchenko Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/mmc_spi.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c > index 9776a03a10f5..65c65bb5737f 100644 > --- a/drivers/mmc/host/mmc_spi.c > +++ b/drivers/mmc/host/mmc_spi.c > @@ -504,7 +504,7 @@ mmc_spi_command_send(struct mmc_spi_host *host, > /* else: R1 (most commands) */ > } > > - dev_dbg(&host->spi->dev, " mmc_spi: CMD%d, resp %s\n", > + dev_dbg(&host->spi->dev, " CMD%d, resp %s\n", > cmd->opcode, maptype(cmd)); > > /* send command, leaving chipselect active */ > @@ -928,8 +928,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd, > while (length) { > t->len = min(length, blk_size); > > - dev_dbg(&host->spi->dev, > - " mmc_spi: %s block, %d bytes\n", > + dev_dbg(&host->spi->dev, " %s block, %d bytes\n", > (direction == DMA_TO_DEVICE) ? "write" : "read", > t->len); > > @@ -974,7 +973,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd, > int tmp; > const unsigned statlen = sizeof(scratch->status); > > - dev_dbg(&spi->dev, " mmc_spi: STOP_TRAN\n"); > + dev_dbg(&spi->dev, " STOP_TRAN\n"); > > /* Tweak the per-block message we set up earlier by morphing > * it to hold single buffer with the token followed by some > @@ -1175,7 +1174,7 @@ static void mmc_spi_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > > canpower = host->pdata && host->pdata->setpower; > > - dev_dbg(&host->spi->dev, "mmc_spi: power %s (%d)%s\n", > + dev_dbg(&host->spi->dev, "power %s (%d)%s\n", > mmc_powerstring(ios->power_mode), > ios->vdd, > canpower ? ", can switch" : ""); > @@ -1248,8 +1247,7 @@ static void mmc_spi_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > > host->spi->max_speed_hz = ios->clock; > status = spi_setup(host->spi); > - dev_dbg(&host->spi->dev, > - "mmc_spi: clock to %d Hz, %d\n", > + dev_dbg(&host->spi->dev, " clock to %d Hz, %d\n", > host->spi->max_speed_hz, status); > } > } > -- > 2.30.2 >