From: Ulf Hansson <ulf.hansson@linaro.org>
To: Bean Huo <huobean@gmail.com>
Cc: rric@kernel.org, Linus Walleij <linus.walleij@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Bean Huo (beanhuo)" <beanhuo@micron.com>
Subject: Re: [PATCH v1 1/2] mmc: cavium: Use '"%s...", __func__' to print function name
Date: Fri, 19 Mar 2021 15:12:42 +0100 [thread overview]
Message-ID: <CAPDyKFp4Y-MS_tsNpCS9M8pqm2RoTmMG7=4MYyxZ7ZsnVKKeQw@mail.gmail.com> (raw)
In-Reply-To: <20210319121357.255176-2-huobean@gmail.com>
On Fri, 19 Mar 2021 at 13:14, Bean Huo <huobean@gmail.com> wrote:
>
> From: Bean Huo <beanhuo@micron.com>
>
> Use preferred way '"%s...", __func__' to print function name.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/cavium.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/cavium.c b/drivers/mmc/host/cavium.c
> index 4bb8f2800a2b..95a41983c6c0 100644
> --- a/drivers/mmc/host/cavium.c
> +++ b/drivers/mmc/host/cavium.c
> @@ -656,8 +656,7 @@ static void cvm_mmc_dma_request(struct mmc_host *mmc,
>
> if (!mrq->data || !mrq->data->sg || !mrq->data->sg_len ||
> !mrq->stop || mrq->stop->opcode != MMC_STOP_TRANSMISSION) {
> - dev_err(&mmc->card->dev,
> - "Error: cmv_mmc_dma_request no data\n");
> + dev_err(&mmc->card->dev, "Error: %s no data\n", __func__);
> goto error;
> }
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-03-19 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 12:13 [PATCH v1 0/2] wo minor changes for Cavium MMC host driver Bean Huo
2021-03-19 12:13 ` [PATCH v1 1/2] mmc: cavium: Use '"%s...", __func__' to print function name Bean Huo
2021-03-19 14:12 ` Ulf Hansson [this message]
2021-03-19 12:13 ` [PATCH v1 2/2] mmc: cavium: Remove redundant if-statement checkup Bean Huo
2021-03-19 14:09 ` Ulf Hansson
2021-03-19 15:42 ` Bean Huo
2021-04-29 20:30 ` Bean Huo
2021-05-10 14:01 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFp4Y-MS_tsNpCS9M8pqm2RoTmMG7=4MYyxZ7ZsnVKKeQw@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=beanhuo@micron.com \
--cc=huobean@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).