From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341C6C4363A for ; Tue, 20 Oct 2020 15:08:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE23022247 for ; Tue, 20 Oct 2020 15:08:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U1XUF5Dh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408519AbgJTPIC (ORCPT ); Tue, 20 Oct 2020 11:08:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407657AbgJTPIC (ORCPT ); Tue, 20 Oct 2020 11:08:02 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB130C061755 for ; Tue, 20 Oct 2020 08:08:01 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id k12so764410uad.11 for ; Tue, 20 Oct 2020 08:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YpTMFQeEZb0rjpUuW6XXMOAXIdREE2jLBrSTZUeG4I8=; b=U1XUF5DhInl+St5txZvE2N429K3nu9ruKXD64YmX2X9+frCh1aWremcUA85iF2PIx1 DLK9xaE52MkGJALcimxPhnvF3IBiGas67tyRMEO11rVkqq2lMq8YJzOqqG1pvEgcHaVM QrU6NGgqq+aY7T8Bl7fUpiQM4tFebDK9yMrhenwM6yX58MjiEYyAMTQQ7YrFTE6lxtUi OXaQRoagMEWU3zF0JrOSkFFMp+bcFDs4SvBOnhtj57cGNHe212D2YzYsy6WeE2rXyg0G y0Hx3T05Dcv4O0QwgqD0NlzZ/TXN5kk8ycpPqPu7i3n5fTgYQGkWxShdlqxNh00mY5GT nXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YpTMFQeEZb0rjpUuW6XXMOAXIdREE2jLBrSTZUeG4I8=; b=i7p/Ob1eqGsr49Xzf8eZBHtxy2YJW/A2VCQATr5jUd6Ow7NiLTl1M/x9P/sSozmR+B AaN/fUg3XuRjtJ8wJ+6lIGwlWgRhaVpeyqixPvP8Tgydw4tYEmhXjJN3DNiqm7c9AE6W LstMrVwHb4SsWhLKA/cNul2dXbY/rgZGljHB/QRuGAlswKHTXRESfyFz+7plnnQHfwtA 4zDSqxrIxdMjWPwvrZ6Mgod/kLfYOCMCjxQVNcs2XueJ1A6rzzo9Kj0MfBvsDJUlFG1M kiIe0hJEIISxhzmyx0u0PUuWJ4kPkDQ0yxgvsOx+QU8fPCBiVjh7wEbX9cy0tRkBB0qm xzZQ== X-Gm-Message-State: AOAM533dEMwgKjXMIcOmFvwiZ5zFsBQiUShslY/lioOCtA0mbH7LzBm6 hNX43w8J3/NZyPygk6/jX5/vJxt7zsEi2h8BjTsZUQ== X-Google-Smtp-Source: ABdhPJwm/KewgGT5Q4WyxYXhPhUG/Zzq9WDofYxTVkmfKUiHImFkm6avmj6ccvMkFsJ3lYGD58oCWd/inLtq/UlBoG4= X-Received: by 2002:ab0:6f11:: with SMTP id r17mr1324840uah.15.1603206476961; Tue, 20 Oct 2020 08:07:56 -0700 (PDT) MIME-Version: 1.0 References: <20201020125817.1632995-1-Jerome.Pouiller@silabs.com> <20201020125817.1632995-2-Jerome.Pouiller@silabs.com> In-Reply-To: <20201020125817.1632995-2-Jerome.Pouiller@silabs.com> From: Ulf Hansson Date: Tue, 20 Oct 2020 17:07:19 +0200 Message-ID: Subject: Re: [PATCH v2 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip To: Jerome Pouiller Cc: linux-wireless , netdev , driverdevel , Linux Kernel Mailing List , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , DTML , Rob Herring , "linux-mmc@vger.kernel.org" , =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2020 at 14:58, Jerome Pouiller wrote: > > From: J=C3=A9r=C3=B4me Pouiller > > Add Silabs SDIO ID to sdio_ids.h. > > Note that the values used by Silabs are uncommon. A driver cannot fully > rely on the SDIO PnP. It should also check if the device is declared in > the DT. > > Signed-off-by: J=C3=A9r=C3=B4me Pouiller Acked-by: Ulf Hansson Kind regards Uffe > --- > include/linux/mmc/sdio_ids.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h > index 12036619346c..20a48162f7fc 100644 > --- a/include/linux/mmc/sdio_ids.h > +++ b/include/linux/mmc/sdio_ids.h > @@ -25,6 +25,11 @@ > * Vendors and devices. Sort key: vendor first, device next. > */ > > +// Silabs does not use a reliable vendor ID. To avoid conflicts, the dri= ver > +// won't probe the device if it is not also declared in the DT. > +#define SDIO_VENDOR_ID_SILABS 0x0000 > +#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 > + > #define SDIO_VENDOR_ID_STE 0x0020 > #define SDIO_DEVICE_ID_STE_CW1200 0x2280 > > -- > 2.28.0 >