From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbdGUH44 (ORCPT ); Fri, 21 Jul 2017 03:56:56 -0400 Received: from mail-ua0-f178.google.com ([209.85.217.178]:37404 "EHLO mail-ua0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753238AbdGUH4x (ORCPT ); Fri, 21 Jul 2017 03:56:53 -0400 MIME-Version: 1.0 In-Reply-To: <20170718214339.7774-10-robh@kernel.org> References: <20170718214339.7774-10-robh@kernel.org> From: Ulf Hansson Date: Fri, 21 Jul 2017 09:56:52 +0200 Message-ID: Subject: Re: [PATCH] PM / Domains: Convert to using %pOF instead of full_name To: Rob Herring Cc: "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kevin Hilman , Pavel Machek , Len Brown , Greg Kroah-Hartman , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 July 2017 at 23:42, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: "Rafael J. Wysocki" > Cc: Kevin Hilman > Cc: Ulf Hansson > Cc: Pavel Machek > Cc: Len Brown > Cc: Greg Kroah-Hartman > Cc: linux-pm@vger.kernel.org Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/base/power/domain.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 3b8210ebb50e..d0989f9b5e67 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1743,7 +1743,7 @@ static int genpd_add_provider(struct device_node *np, genpd_xlate_t xlate, > mutex_lock(&of_genpd_mutex); > list_add(&cp->link, &of_genpd_providers); > mutex_unlock(&of_genpd_mutex); > - pr_debug("Added domain provider from %s\n", np->full_name); > + pr_debug("Added domain provider from %pOF\n", np); > > return 0; > } > @@ -2149,16 +2149,16 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state, > err = of_property_read_u32(state_node, "entry-latency-us", > &entry_latency); > if (err) { > - pr_debug(" * %s missing entry-latency-us property\n", > - state_node->full_name); > + pr_debug(" * %pOF missing entry-latency-us property\n", > + state_node); > return -EINVAL; > } > > err = of_property_read_u32(state_node, "exit-latency-us", > &exit_latency); > if (err) { > - pr_debug(" * %s missing exit-latency-us property\n", > - state_node->full_name); > + pr_debug(" * %pOF missing exit-latency-us property\n", > + state_node); > return -EINVAL; > } > > @@ -2212,8 +2212,8 @@ int of_genpd_parse_idle_states(struct device_node *dn, > ret = genpd_parse_state(&st[i++], np); > if (ret) { > pr_err > - ("Parsing idle state node %s failed with err %d\n", > - np->full_name, ret); > + ("Parsing idle state node %pOF failed with err %d\n", > + np, ret); > of_node_put(np); > kfree(st); > return ret; > -- > 2.11.0 >