From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: adrian.hunter@intel.com, haibo.chen@nxp.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] mmc: sdhci-acpi: Fix comment typo
Date: Fri, 22 Jul 2022 11:32:38 +0200 [thread overview]
Message-ID: <CAPDyKFpBc_XZStRb7mwQ_nN-YUnxxmXrqx6hFFxoVG=iJ-VdiQ@mail.gmail.com> (raw)
In-Reply-To: <20220718082650.9784-1-wangborong@cdjrlc.com>
On Thu, 21 Jul 2022 at 18:30, Jason Wang <wangborong@cdjrlc.com> wrote:
>
> The double `the' is duplicated in the comment, remove one.
>
Hi Jason, these spelling fixups are getting somewhat annoying to me,
sorry. Don't get me wrong, it's nice to have good readable comments,
but the patches don't really need to be one line of change per patch.
Could you perhaps look over all mmc host drivers and fix all spelling
mistakes in them and send one patch to cover all of them instead?
Kind regards
Uffe
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/mmc/host/sdhci-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 4cca4c90769b..bddfaba091a9 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -648,7 +648,7 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
> * in reading a garbage value and using the wrong presets.
> *
> * Since HS400 and HS200 presets must be identical, we could
> - * instead use the the SDR104 preset register.
> + * instead use the SDR104 preset register.
> *
> * If the above issues are resolved we could remove this quirk for
> * firmware that that has valid presets (i.e., SDR12 <= 12 MHz).
> --
> 2.35.1
>
prev parent reply other threads:[~2022-07-22 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 8:26 [PATCH 1/3] mmc: sdhci-acpi: Fix comment typo Jason Wang
2022-07-18 8:26 ` [PATCH 2/3] mmc: sdhci-esdhc-imx: " Jason Wang
2022-07-18 8:26 ` [PATCH 3/3] mmc: sdhci-omap: " Jason Wang
2022-07-22 9:32 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpBc_XZStRb7mwQ_nN-YUnxxmXrqx6hFFxoVG=iJ-VdiQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).