From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E424AC433E0 for ; Fri, 29 May 2020 10:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C163320776 for ; Fri, 29 May 2020 10:36:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n6OtqtRi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbgE2Kgc (ORCPT ); Fri, 29 May 2020 06:36:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbgE2Kg3 (ORCPT ); Fri, 29 May 2020 06:36:29 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E4B7C08C5C6 for ; Fri, 29 May 2020 03:36:29 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id g129so1199352vsc.4 for ; Fri, 29 May 2020 03:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HmjuhvsPi7i8QqafSrWT+BKWCrvyW72ZyBBet/hxqD0=; b=n6OtqtRiLbTORvfYG6+bQXzcgCH/G6pkw+zSMMdxMxkDlpoVqcIbqFNyv3NrrCz5UM FYu3A0S/YnIkMA6bPm3usBVBl4ZBaVa7R9KMWxUFhoNB1G2oMSEiymI0XafYge8Sf0Vw RE5rWLK+Ax0x/TMsslPBgGo/gJ7BZJ07OXg/tMJlBcLFWiVx5N0oeSsxW8LMHfj2MWbF TrE2E2NBmbZV50QHjMp5wcPnnKffF5IPTYZFS6YILUdLLHlTJ9jvyGuKXuiOblPE7urJ eKL9W0/yjaSHd7EMkRbmYeRpkPUCJZWIWARpOLgbdPj+Lxi4usxtZkAfc6wHgLFUil1t 8jGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HmjuhvsPi7i8QqafSrWT+BKWCrvyW72ZyBBet/hxqD0=; b=VTEOjMqVJB6JvZocs30z2XvQz50ewENMxeEMX5fXSnw+cSN7gALDd84p/gqqux/m2s 0VK942ebrP02uzb/mtuiA8mglfQO/wlAtWoiVWzgL+dFEZqgdpiuPFKLWd2zwsXXdijM qrSJqSGthRkIlblI21LjtRcJ2athRWt9gWUfujFsNFyHuXfJW4sorlGKld/l7R8VTr/c UDM3iwy5GOtCMPsB2CGSp5ZTpMFIfgIGWt2PwdR5qBc3cJpJbTZnAmb3nkFnWCfAvxH5 REPdhPXMn3WNFXXV/aI+3leW/iwx0scL7F+KQBC/2hdAj1DYVHwCXp86fzMAp/eimV1t 0KDg== X-Gm-Message-State: AOAM5313ILB3pyOQq7kEpiLYwDXz2wiF+RHBCntlwJ+TCBqseGB7agjr RXJfYu+kjuU1a5se36MXvtrViV68AF/rUikPxS9lhjRiSKw= X-Google-Smtp-Source: ABdhPJzBQ0zlzWRM+H9Ii1EWbIJoP5vdLRB7231T5LWWfcHEbqkYTyRcxm7AJOljOxCsWsLh6iMLrbF8H2nC95j2LAE= X-Received: by 2002:a67:1486:: with SMTP id 128mr5150038vsu.191.1590748585116; Fri, 29 May 2020 03:36:25 -0700 (PDT) MIME-Version: 1.0 References: <1590678838-18099-1-git-send-email-vbadigan@codeaurora.org> In-Reply-To: <1590678838-18099-1-git-send-email-vbadigan@codeaurora.org> From: Ulf Hansson Date: Fri, 29 May 2020 12:35:48 +0200 Message-ID: Subject: Re: [PATCH V1] mmc: sdhci-msm: Clear tuning done flag while hs400 tuning To: Veerabhadrarao Badiganti Cc: Adrian Hunter , Bjorn Andersson , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-arm-msm , "# 4.0+" , Andy Gross , Ritesh Harjani , Venkat Gopalakrishnan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 May 2020 at 17:14, Veerabhadrarao Badiganti wrote: > > Clear tuning_done flag while executing tuning to ensure vendor > specific HS400 settings are applied properly when the controller > is re-initialized in HS400 mode. > > Without this, re-initialization of the qcom SDHC in HS400 mode fails > while resuming the driver from runtime-suspend or system-suspend. > > Fixes: ff06ce4 ("mmc: sdhci-msm: Add HS400 platform support") > Cc: stable@vger.kernel.org > Signed-off-by: Veerabhadrarao Badiganti Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-msm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 95cd973..b277dd7 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1174,6 +1174,12 @@ static int sdhci_msm_execute_tuning(struct mmc_host *mmc, u32 opcode) > msm_host->use_cdr = true; > > /* > + * Clear tuning_done flag before tuning to ensure proper > + * HS400 settings. > + */ > + msm_host->tuning_done = 0; > + > + /* > * For HS400 tuning in HS200 timing requires: > * - select MCLK/2 in VENDOR_SPEC > * - program MCLK to 400MHz (or nearest supported) in GCC > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project >