From: Ulf Hansson <ulf.hansson@linaro.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mmc: rtsx_usb_sdmmc: simplify the return expression of sd_change_phase()
Date: Thu, 24 Sep 2020 14:49:41 +0200 [thread overview]
Message-ID: <CAPDyKFpF3+Dr3iJq1Yn2OSnpV4OZ9oVig3g3GzROiiPiiwJyrw@mail.gmail.com> (raw)
In-Reply-To: <20200921131042.92340-1-miaoqinglang@huawei.com>
On Mon, 21 Sep 2020 at 15:10, Qinglang Miao <miaoqinglang@huawei.com> wrote:
>
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/rtsx_usb_sdmmc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
> index 598f49573..5fe4528e2 100644
> --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
> @@ -579,7 +579,6 @@ static void sd_normal_rw(struct rtsx_usb_sdmmc *host,
> static int sd_change_phase(struct rtsx_usb_sdmmc *host, u8 sample_point, int tx)
> {
> struct rtsx_ucr *ucr = host->ucr;
> - int err;
>
> dev_dbg(sdmmc_dev(host), "%s: %s sample_point = %d\n",
> __func__, tx ? "TX" : "RX", sample_point);
> @@ -601,11 +600,7 @@ static int sd_change_phase(struct rtsx_usb_sdmmc *host, u8 sample_point, int tx)
> rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, CLK_DIV, CLK_CHANGE, 0);
> rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, SD_CFG1, SD_ASYNC_FIFO_RST, 0);
>
> - err = rtsx_usb_send_cmd(ucr, MODE_C, 100);
> - if (err)
> - return err;
> -
> - return 0;
> + return rtsx_usb_send_cmd(ucr, MODE_C, 100);
> }
>
> static inline u32 get_phase_point(u32 phase_map, unsigned int idx)
> --
> 2.23.0
>
prev parent reply other threads:[~2020-09-24 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:10 [PATCH -next] mmc: rtsx_usb_sdmmc: simplify the return expression of sd_change_phase() Qinglang Miao
2020-09-24 12:49 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpF3+Dr3iJq1Yn2OSnpV4OZ9oVig3g3GzROiiPiiwJyrw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).