From: Ulf Hansson <ulf.hansson@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mmc: block: Avoid uninitialized warning in mmc_blk_issue_discard_rq()
Date: Thu, 29 Dec 2016 20:02:51 +0100 [thread overview]
Message-ID: <CAPDyKFpFfsovCcmAqvuYXxy9VDQhsHzXABXg0JXKtzPGgWMrCw@mail.gmail.com> (raw)
In-Reply-To: <1482156225-32517-1-git-send-email-geert@linux-m68k.org>
On 19 December 2016 at 15:03, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> With gcc-4.1.2:
>
> mmc/core/block.c: In function ‘mmc_blk_issue_discard_rq’:
> mmc/core/block.c:1150: warning: ‘arg’ may be used uninitialized in this function
> mmc/core/block.c:1150: warning: ‘nr’ may be used uninitialized in this function
> mmc/core/block.c:1150: warning: ‘from’ may be used uninitialized in this function
>
> While this is a false positive, it can be avoided easily by jumping over
> the checks for "err" that are always false.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/core/block.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index bab3f07b1117ea81..8c0e0833d481cf94 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -1152,7 +1152,7 @@ static int mmc_blk_issue_discard_rq(struct mmc_queue *mq, struct request *req)
>
> if (!mmc_can_erase(card)) {
> err = -EOPNOTSUPP;
> - goto out;
> + goto fail;
> }
>
> from = blk_rq_pos(req);
> @@ -1181,6 +1181,7 @@ static int mmc_blk_issue_discard_rq(struct mmc_queue *mq, struct request *req)
> goto retry;
> if (!err)
> mmc_blk_reset_success(md, type);
> +fail:
> blk_end_request(req, err, blk_rq_bytes(req));
>
> return err ? 0 : 1;
> --
> 1.9.1
>
prev parent reply other threads:[~2016-12-29 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 14:03 [PATCH 1/2] mmc: block: Avoid uninitialized warning in mmc_blk_issue_discard_rq() Geert Uytterhoeven
2016-12-19 14:03 ` [PATCH 2/2] [RFC] mmc: block: Replace "goto retry" by a proper do / while loop Geert Uytterhoeven
2016-12-29 19:03 ` Ulf Hansson
2016-12-29 19:02 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpFfsovCcmAqvuYXxy9VDQhsHzXABXg0JXKtzPGgWMrCw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).