From: Ulf Hansson <ulf.hansson@linaro.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci_am654: Fix the driver data of AM64 SoC
Date: Thu, 17 Feb 2022 16:39:21 +0100 [thread overview]
Message-ID: <CAPDyKFpH4nnnzbFRfZ8p_vLSqh+m+fEd4yW2T2Z4rq6tRQS-Lw@mail.gmail.com> (raw)
In-Reply-To: <20220211075056.26179-1-a-govindraju@ti.com>
On Fri, 11 Feb 2022 at 08:51, Aswath Govindraju <a-govindraju@ti.com> wrote:
>
> The MMCSD IPs used in AM64 are the same as the ones used in J721E.
> Therefore, fix this by using the driver data from J721E for AM64 too, for
> both 8 and 4 bit instances.
>
> Fixes: 754b7f2f7d2a ("mmc: sdhci_am654: Add Support for TI's AM64 SoC")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci_am654.c | 24 ++----------------------
> 1 file changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index f654afbe8e83..b4891bb26648 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -514,26 +514,6 @@ static const struct sdhci_am654_driver_data sdhci_j721e_4bit_drvdata = {
> .flags = IOMUX_PRESENT,
> };
>
> -static const struct sdhci_pltfm_data sdhci_am64_8bit_pdata = {
> - .ops = &sdhci_j721e_8bit_ops,
> - .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
> -};
> -
> -static const struct sdhci_am654_driver_data sdhci_am64_8bit_drvdata = {
> - .pdata = &sdhci_am64_8bit_pdata,
> - .flags = DLL_PRESENT | DLL_CALIB,
> -};
> -
> -static const struct sdhci_pltfm_data sdhci_am64_4bit_pdata = {
> - .ops = &sdhci_j721e_4bit_ops,
> - .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
> -};
> -
> -static const struct sdhci_am654_driver_data sdhci_am64_4bit_drvdata = {
> - .pdata = &sdhci_am64_4bit_pdata,
> - .flags = IOMUX_PRESENT,
> -};
> -
> static const struct soc_device_attribute sdhci_am654_devices[] = {
> { .family = "AM65X",
> .revision = "SR1.0",
> @@ -759,11 +739,11 @@ static const struct of_device_id sdhci_am654_of_match[] = {
> },
> {
> .compatible = "ti,am64-sdhci-8bit",
> - .data = &sdhci_am64_8bit_drvdata,
> + .data = &sdhci_j721e_8bit_drvdata,
> },
> {
> .compatible = "ti,am64-sdhci-4bit",
> - .data = &sdhci_am64_4bit_drvdata,
> + .data = &sdhci_j721e_4bit_drvdata,
> },
> { /* sentinel */ }
> };
> --
> 2.17.1
>
prev parent reply other threads:[~2022-02-17 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 7:50 [PATCH] mmc: sdhci_am654: Fix the driver data of AM64 SoC Aswath Govindraju
2022-02-17 15:39 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFpH4nnnzbFRfZ8p_vLSqh+m+fEd4yW2T2Z4rq6tRQS-Lw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=a-govindraju@ti.com \
--cc=adrian.hunter@intel.com \
--cc=faiz_abbas@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).