From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEA2C433E0 for ; Mon, 18 Jan 2021 10:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E932A22252 for ; Mon, 18 Jan 2021 10:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389572AbhARKzs (ORCPT ); Mon, 18 Jan 2021 05:55:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390203AbhARKed (ORCPT ); Mon, 18 Jan 2021 05:34:33 -0500 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94590C061573 for ; Mon, 18 Jan 2021 02:33:26 -0800 (PST) Received: by mail-vs1-xe31.google.com with SMTP id p20so1637208vsq.7 for ; Mon, 18 Jan 2021 02:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=adiPbiEP1YT6K9N1O0mWeeG4Pxclh7kWVlewQqbqeNE=; b=I3qVuBr5uDMMAfGcazh4VHKHknGJ0eoa0uFRy3D86VXscngmO6tKadEb8Tf2J9n3rY Wk6qdTAlcNr2fk4JZjTwHDYfs1/VYbw1AFxrB8AW28CwyG+Y+8XVdpzq4llf/epKoR9k iZniMhqgneDNT6L6Wjpyapo/qMi/m+7C7A7EN7HZLGMnKFVv3c8LSjXZkXN3dZiQg4pN yKdif6tHIgU3b373dIpgsnOyC/d38I9Js8UYY9lpS1Bk/TCj7cBiILsGEGCRvuR+Boa/ 22QUys2sv67Jll9loPfC0rqQBGwqY6hAPPuSDD+BDM4QKipHQ4T0SQ/wZoxMugDQuXCj 4Lhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=adiPbiEP1YT6K9N1O0mWeeG4Pxclh7kWVlewQqbqeNE=; b=RciROCJkNxwhb2vdXMQZWKi0a5ryxGeTK8ja5V9YQuqZkkSHzvpteEmDPeBSf50Jic i/O+MElcb6+FA9D/fBf8953/UTkgWIsyTGn9EFCTrbp5zndTaOlx3e4dGXTohIr1ZC7k WFWlK/fRX0aGJBDmuuYe72QFLwH/EBBvNqAWJUWph5e4vlTH3pBQhiSSiv4E3WisxwWp 1g1233kwOjIjLQfz3KR4aC/sMbMZ5UAoCpXYqwmA8JjocdAy3xsKN2G6INt4mQMmMhaz OdDTXDNy7J+pkKx7Y03GMw2+wvHc89L/xfmrVV9B3GUttumN1m5aaIUFnphbsZnl33ai taJw== X-Gm-Message-State: AOAM533n3uGo5gBM0kqhGuMXlAqzzeTK9AX7yhVJECEJ1FSVCBBkZRWW bvKg9/hY3Zat+P7U4dLHd8Q6RBQ8nRRNmjfHdv9NjDSpYu0xEQ== X-Google-Smtp-Source: ABdhPJz7J/RbHIZCaRXKtv4bI/4J9V1bWxYQzBjJDzVZXkaPGqqSpE/x0WWPE3R4rM1rIh4V9JZj+GO+3R+IOR7Ne3c= X-Received: by 2002:a67:c787:: with SMTP id t7mr7915130vsk.48.1610966005685; Mon, 18 Jan 2021 02:33:25 -0800 (PST) MIME-Version: 1.0 References: <20210118011330.4145-1-digetx@gmail.com> <20210118011330.4145-4-digetx@gmail.com> In-Reply-To: <20210118011330.4145-4-digetx@gmail.com> From: Ulf Hansson Date: Mon, 18 Jan 2021 11:32:48 +0100 Message-ID: Subject: Re: [PATCH v3 3/3] PM: domains: Make of_genpd_add_subdomain() to return -EPROBE_DEFER To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Peter Geis , Nicolas Chauvet , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Greg Kroah-Hartman , Matt Merhar , Linux Kernel Mailing List , linux-tegra , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jan 2021 at 02:13, Dmitry Osipenko wrote: > > Driver of a power domain provider may not be ready at the time of > of_genpd_add_subdomain() invocation. Make this function to return > -EPROBE_DEFER instead of -ENOENT in order to remove a need from > power domain drivers to handle the error code specially. > > Suggested-by: Ulf Hansson > Signed-off-by: Dmitry Osipenko Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 2ab77aa516eb..7ef6764ee30f 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2462,7 +2462,7 @@ int of_genpd_add_subdomain(struct of_phandle_args *parent_spec, > out: > mutex_unlock(&gpd_list_lock); > > - return ret; > + return ret == -ENOENT ? -EPROBE_DEFER : ret; > } > EXPORT_SYMBOL_GPL(of_genpd_add_subdomain); > > -- > 2.29.2 >