From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D169C31E46 for ; Wed, 12 Jun 2019 11:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60B6020665 for ; Wed, 12 Jun 2019 11:49:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IWDvMyC9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730259AbfFLLtf (ORCPT ); Wed, 12 Jun 2019 07:49:35 -0400 Received: from mail-ua1-f67.google.com ([209.85.222.67]:45914 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfFLLtf (ORCPT ); Wed, 12 Jun 2019 07:49:35 -0400 Received: by mail-ua1-f67.google.com with SMTP id v18so5776826uad.12 for ; Wed, 12 Jun 2019 04:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fL5+yAvFpszDdwrzAhEA7Ye5Luf0zjBze5h9taUU+T8=; b=IWDvMyC9P5AiIW64CutGGY3WzwhVrLGaAwN6J8EHfw77V8yPYgGHANQJg8t7eiy16v uMqvroecwGxZQhVf/oKmaAoo3x8Zv6b+o3OUoxe8P5B/4oLM4GhchWkpjqvRt+VvIA3l OJa17Pfk4PgfzzVZjGVPa3deTyFnbxuDADm7WJ9Sc4pnYOc18CjiqS7J44hKqeXxDKCr piablk8wr9MlnupnliBftfIn4flYndyYx6WkOtHT3Ju+Yeph+UIiWKaVCoxSyXhYEyIM 27B1y+7ahTL2MLr2dgibSIN4AwXg/MjbIfq1YkfB3kyLgGXCBK9ZErt71PtnX/DZhIjk 4Rlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fL5+yAvFpszDdwrzAhEA7Ye5Luf0zjBze5h9taUU+T8=; b=Ez1Qbxg6a9Tu3Dyg7DrPaSHw6WpPuN5n1ELdi8A6DyPZD841A5Elc0D6FN7taKU5lp Qsfg6hAr1IQd8rJx+RuywXUjXUSMiqHaRoxwLwso+GoMBrREF31xXk/c1tz6TD9FU2d4 YazgTTiIBcthHYQXO/X5CuVOnnk1kVsCt0xvtXIOIgJWwfGpO+QGfpHS3f9zwEhEPKX6 n9zCbGfSDbF6KqRO6sYfe0DdyugtBTFpi39gTEEZzJvGSrs85dVjOibrtIiKfKGZU907 3Sz8pUSUB/wDtluNkTUiRATZry91ZmuWBDyrf5fPwF2LAgn04YILZp774gB7L0Kmnocx a7qw== X-Gm-Message-State: APjAAAU4fv9bVreR+yGS9GAAbimhbxVjyC0I5zvC8CmK7bkj6OhCLqqJ GpiQqsWKLDnKKGRLWQK24E5voDee3BH18gGHU7ub4Q== X-Google-Smtp-Source: APXvYqy9Znw8HxyqdcJxmFY7a6Iw36a1N9tWz9NbjPT8mcjJotx9MWPFEjWPSQY9+rfUfMt64hGDugr+7AVqGSrtZqY= X-Received: by 2002:ab0:2705:: with SMTP id s5mr576634uao.104.1560340174391; Wed, 12 Jun 2019 04:49:34 -0700 (PDT) MIME-Version: 1.0 References: <20190607223716.119277-1-dianders@chromium.org> <20190607223716.119277-4-dianders@chromium.org> <363DA0ED52042842948283D2FC38E4649C52F8A0@IRSMSX106.ger.corp.intel.com> In-Reply-To: From: Ulf Hansson Date: Wed, 12 Jun 2019 13:48:57 +0200 Message-ID: Subject: Re: [PATCH v3 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail To: Arend Van Spriel Cc: Doug Anderson , "Hunter, Adrian" , Kalle Valo , "brcm80211-dev-list.pdl@broadcom.com" , "linux-rockchip@lists.infradead.org" , Double Lo , "briannorris@chromium.org" , "linux-wireless@vger.kernel.org" , Naveen Gupta , Madhan Mohan R , "mka@chromium.org" , Wright Feng , Chi-Hsien Lin , "netdev@vger.kernel.org" , "brcm80211-dev-list@cypress.com" , Franky Lin , "linux-kernel@vger.kernel.org" , Hante Meuleman , YueHaibing , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Jun 2019 at 13:11, Arend Van Spriel wrote: > > On 6/12/2019 12:10 PM, Ulf Hansson wrote: > >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c: > >> mmc_set_data_timeout(md, func->card); > >> mmc_wait_for_req(func->card->host, mr); > > These are not okay, none of these things calls should really be done > > from an SDIO func driver. > > > > It tells me that the func driver is a doing workaround for something > > that should be managed in a common way. > > We are using some low-level functions passing chain of skbuff to the > device using CMD53 with scatterlist. If I recall correctly Marvell made > an attempt to have a similar function for it in the mmc stack. Not sure > if that ever made it in. If so I can rework our driver using that API. > If not, I can make a new attempt. I recall there were some patches, but not sure why we didn't merge them. Anyway, if you want to move this forward, that would be awesome! Kind regards Uffe