* [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode
@ 2021-04-14 10:00 Neil Armstrong
2021-04-15 9:07 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2021-04-14 10:00 UTC (permalink / raw)
To: ulf.hansson
Cc: linux-mmc, linux-arm-kernel, linux-amlogic, linux-kernel,
lebed.dmitry, Neil Armstrong, Marek Szyprowski
Since commit e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode"),
support for SDIO SD_IO_RW_EXTENDED transferts are properly filtered but some driver
like brcmfmac still gives a block sg buffer size not aligned with SDIO block,
triggerring a warning even if the transfer works in degraded mode.
This should be ultimately fixed in brcmfmac, but since it's only a performance issue
the warning should be removed.
Fixes: e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/mmc/host/meson-gx-mmc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index eb6c02bc4a02..6bc151045843 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -246,11 +246,8 @@ static void meson_mmc_get_transfer_mode(struct mmc_host *mmc,
* size, otherwise chain mode could not be used.
*/
for_each_sg(data->sg, sg, data->sg_len, i) {
- if (sg->length % data->blksz) {
- WARN_ONCE(1, "unaligned sg len %u blksize %u\n",
- sg->length, data->blksz);
+ if (sg->length % data->blksz)
return;
- }
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode
2021-04-14 10:00 [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode Neil Armstrong
@ 2021-04-15 9:07 ` Ulf Hansson
2021-04-16 9:33 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Hansson @ 2021-04-15 9:07 UTC (permalink / raw)
To: Neil Armstrong
Cc: linux-mmc, Linux ARM, open list:ARM/Amlogic Meson...,
Linux Kernel Mailing List, Dmitry Lebed, Marek Szyprowski
On Wed, 14 Apr 2021 at 12:00, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Since commit e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode"),
> support for SDIO SD_IO_RW_EXTENDED transferts are properly filtered but some driver
> like brcmfmac still gives a block sg buffer size not aligned with SDIO block,
> triggerring a warning even if the transfer works in degraded mode.
>
> This should be ultimately fixed in brcmfmac, but since it's only a performance issue
> the warning should be removed.
>
> Fixes: e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode")
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/mmc/host/meson-gx-mmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index eb6c02bc4a02..6bc151045843 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -246,11 +246,8 @@ static void meson_mmc_get_transfer_mode(struct mmc_host *mmc,
> * size, otherwise chain mode could not be used.
> */
> for_each_sg(data->sg, sg, data->sg_len, i) {
> - if (sg->length % data->blksz) {
> - WARN_ONCE(1, "unaligned sg len %u blksize %u\n",
> - sg->length, data->blksz);
Rather than removing this warning, perhaps an option could be to use
dev_warn_once() instead?
> + if (sg->length % data->blksz)
> return;
> - }
> }
> }
>
Kind regards
Uffe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode
2021-04-15 9:07 ` Ulf Hansson
@ 2021-04-16 9:33 ` Neil Armstrong
0 siblings, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2021-04-16 9:33 UTC (permalink / raw)
To: Ulf Hansson
Cc: linux-mmc, Linux ARM, open list:ARM/Amlogic Meson...,
Linux Kernel Mailing List, Dmitry Lebed, Marek Szyprowski
On 15/04/2021 11:07, Ulf Hansson wrote:
> On Wed, 14 Apr 2021 at 12:00, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Since commit e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode"),
>> support for SDIO SD_IO_RW_EXTENDED transferts are properly filtered but some driver
>> like brcmfmac still gives a block sg buffer size not aligned with SDIO block,
>> triggerring a warning even if the transfer works in degraded mode.
>>
>> This should be ultimately fixed in brcmfmac, but since it's only a performance issue
>> the warning should be removed.
>>
>> Fixes: e085b51c74cc ("mmc: meson-gx: check for scatterlist size alignment in block mode")
>> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> drivers/mmc/host/meson-gx-mmc.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index eb6c02bc4a02..6bc151045843 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -246,11 +246,8 @@ static void meson_mmc_get_transfer_mode(struct mmc_host *mmc,
>> * size, otherwise chain mode could not be used.
>> */
>> for_each_sg(data->sg, sg, data->sg_len, i) {
>> - if (sg->length % data->blksz) {
>> - WARN_ONCE(1, "unaligned sg len %u blksize %u\n",
>> - sg->length, data->blksz);
>
> Rather than removing this warning, perhaps an option could be to use
> dev_warn_once() instead?
Yep, I'll re-spin.
Neil
>
>> + if (sg->length % data->blksz)
>> return;
>> - }
>> }
>> }
>>
>
> Kind regards
> Uffe
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-16 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 10:00 [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode Neil Armstrong
2021-04-15 9:07 ` Ulf Hansson
2021-04-16 9:33 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).