From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E224FA3735 for ; Thu, 17 Oct 2019 15:43:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1FAF2089C for ; Thu, 17 Oct 2019 15:43:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MTHKy8u0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407960AbfJQPnr (ORCPT ); Thu, 17 Oct 2019 11:43:47 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:37544 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407331AbfJQPnq (ORCPT ); Thu, 17 Oct 2019 11:43:46 -0400 Received: by mail-vk1-f194.google.com with SMTP id v78so629475vke.4 for ; Thu, 17 Oct 2019 08:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9cPCkoWUtN/mgY5EDGDopreFb0szGU5fkwoJ47zwfPo=; b=MTHKy8u0XqikOxEYya8246NAjzWcNntEUXhTxkxFVqzTMaYoVEBeZXjNk0FHbzdnKN 0N3Whx01EUOQi+X52WYuVqZziQ3loO+xUt0O+Bu+bc3wIyCqlFh3X0TC2udeTOyEeDX8 pGdXdUlSP1FE3aG9PtQ6bgrL5EdUzHXyyMn19xZF9SJ40XnSYyFk3LDzqCiey7VfEYD0 rng6yXn7zCmTS6aMr67NSuUztzm2JInboiuigxcYTTwP4a49QrjaPeC8bkHSRiTLId6p XLpmHTegDAIezM4pqQOuSz0h0+43h9CdDvXoxOPWia4qV8yznSGdO8TZgSWYvZheZfZC Ie+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9cPCkoWUtN/mgY5EDGDopreFb0szGU5fkwoJ47zwfPo=; b=LlZTD+mF31pCg3+7sf/Y5O/WLgs/1cepjbKjr5e2gedwe+Jz1sIhtMQ8FUx5aVRgU2 Z+bZr4aVDm38xdP8WZPeAknbEKFBnBv2ddgkvrLdrCq/Z/Uz1ym/v6uGqDCgoj70eLMh Iz+/Et6DB6tUTFxTkzwjsZTdDzL5I3nd7nLUs08pMROYj1crQ4qzqUzcWOH+UXfsEgyk vJwr5xPmupDlbHmGGMn0omMcooxJ2etqkY+ZDSiIU/kAEg2rWFSYllR8Y2pspG6wd+U0 GrT1Rf+G19+AHkJwMC6734sZUJJHI7USrTkN/jI8qBiMpbtRFeabGlO9YpiMxiMiQey2 88hA== X-Gm-Message-State: APjAAAVKxfV/hqdiQlsOeAwDFxfIjCd8CNYxwfOZsiX+5LBy88sBnllo +gLUUpgYVaHD7nYCtN44h30iuqRGnM5qZUKnWbZyzg== X-Google-Smtp-Source: APXvYqzCMxkr3FQElBCVQfH8au6MF/yRHYSwhLVuExQHapPedkdyeqQ70PUUZ9KNUkOTqzAiQVBqcfLfYi3jP+lvsIc= X-Received: by 2002:a1f:b202:: with SMTP id b2mr2307071vkf.59.1571327024388; Thu, 17 Oct 2019 08:43:44 -0700 (PDT) MIME-Version: 1.0 References: <1571254641-13626-1-git-send-email-thara.gopinath@linaro.org> <1571254641-13626-7-git-send-email-thara.gopinath@linaro.org> <5DA88892.5000408@linaro.org> In-Reply-To: <5DA88892.5000408@linaro.org> From: Ulf Hansson Date: Thu, 17 Oct 2019 17:43:08 +0200 Message-ID: Subject: Re: [PATCH v3 6/7] dt-bindings: soc: qcom: Extend RPMh power controller binding to describe thermal warming device To: Thara Gopinath Cc: Eduardo Valentin , Zhang Rui , Daniel Lezcano , Bjorn Andersson , Andy Gross , amit.kucheria@verdurent.com, Mark Rutland , "Rafael J. Wysocki" , Linux PM , DTML , linux-arm-msm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Oct 2019 at 17:28, Thara Gopinath wrote: > > Hello Ulf, > Thanks for the review! > > On 10/17/2019 05:04 AM, Ulf Hansson wrote: > > On Wed, 16 Oct 2019 at 21:37, Thara Gopinath wrote: > >> > >> RPMh power controller hosts mx domain that can be used as thermal > >> warming device. Add a sub-node to specify this. > >> > >> Signed-off-by: Thara Gopinath > >> --- > >> Documentation/devicetree/bindings/power/qcom,rpmpd.txt | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt > >> index eb35b22..fff695d 100644 > >> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt > >> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt > >> @@ -18,6 +18,16 @@ Required Properties: > >> Refer to for the level values for > >> various OPPs for different platforms as well as Power domain indexes > >> > >> += SUBNODES > >> +RPMh alsp hosts power domains that can behave as thermal warming device. > >> +These are expressed as subnodes of the RPMh. The name of the node is used > >> +to identify the power domain and must therefor be "mx". > >> + > >> +- #cooling-cells: > >> + Usage: optional > >> + Value type: > >> + Definition: must be 2 > >> + > > > > Just wanted to express a minor thought about this. In general we use > > subnodes of PM domain providers to represent the topology of PM > > domains (subdomains), this is something different, which I guess is > > fine. > > > > I assume the #cooling-cells is here tells us this is not a PM domain > > provider, but a "cooling device provider"? > Yep. > > > > Also, I wonder if it would be fine to specify "power-domains" here, > > rather than using "name" as I think that is kind of awkward!? > Do you mean "power-domain-names" ? I am using this to match against the > genpd names defined in the provider driver. No. If you are using "power-domains" it means that you allow to describe the specifier for the provider. >From Linux point of view, it means you can use dev_pm_domain_attach() to hook up the corresponding device with the PM domain. Using "power-domain-names" is just to allow to specify a name rather than an index, which makes sense if there is more than one index. Perhaps you can state that the "power-domain-names" should be there anyway, to be a little bit future proof if ever multiple index (multiple PM domains). Kind regards Uffe