From: Ulf Hansson <ulf.hansson@linaro.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
Sowjanya Komatineni <skomatineni@nvidia.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"(Exiting) Baolin Wang" <baolin.wang@linaro.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Bradley Bolen <bradleybolen@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Aniruddha Tvs Rao <anrao@nvidia.com>,
linux-tegra <linux-tegra@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
lkft-triage@lists.linaro.org,
linux- stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] sdhci: tegra: Implement Tegra specific set_timeout callback
Date: Thu, 16 Apr 2020 12:59:06 +0200 [thread overview]
Message-ID: <CAPDyKFpZEiqTdD6O-y6Sw7ifXF__MHAv0zKT=RFKs+Fmvr-K_Q@mail.gmail.com> (raw)
In-Reply-To: <CA+G9fYvreAv5HmZg0O4VvLvf_PYSvzD1rp08XONNQGExctgQ0Q@mail.gmail.com>
On Wed, 15 Apr 2020 at 19:55, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Fri, 13 Mar 2020 at 06:41, Sowjanya Komatineni
> <skomatineni@nvidia.com> wrote:
> >
> > Tegra host supports HW busy detection and timeouts based on the
> > count programmed in SDHCI_TIMEOUT_CONTROL register and max busy
> > timeout it supports is 11s in finite busy wait mode.
> >
> > Some operations like SLEEP_AWAKE, ERASE and flush cache through
> > SWITCH commands take longer than 11s and Tegra host supports
> > infinite HW busy wait mode where HW waits forever till the card
> > is busy without HW timeout.
> >
> > This patch implements Tegra specific set_timeout sdhci_ops to allow
> > switching between finite and infinite HW busy detection wait modes
> > based on the device command expected operation time.
> >
> > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> > ---
> > drivers/mmc/host/sdhci-tegra.c | 31 +++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> > index a25c3a4..fa8f6a4 100644
> > --- a/drivers/mmc/host/sdhci-tegra.c
> > +++ b/drivers/mmc/host/sdhci-tegra.c
> > @@ -45,6 +45,7 @@
> > #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_SHIFT 8
> >
> > #define SDHCI_TEGRA_VENDOR_MISC_CTRL 0x120
> > +#define SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT BIT(0)
> > #define SDHCI_MISC_CTRL_ENABLE_SDR104 0x8
>
> > #define SDHCI_MISC_CTRL_ENABLE_SDR50 0x10
> > #define SDHCI_MISC_CTRL_ENABLE_SDHCI_SPEC_300 0x20
> > @@ -1227,6 +1228,34 @@ static u32 sdhci_tegra_cqhci_irq(struct sdhci_host *host, u32 intmask)
> > return 0;
> > }
> >
> > +static void tegra_sdhci_set_timeout(struct sdhci_host *host,
> > + struct mmc_command *cmd)
> > +{
> > + u32 val;
> > +
> > + /*
> > + * HW busy detection timeout is based on programmed data timeout
> > + * counter and maximum supported timeout is 11s which may not be
> > + * enough for long operations like cache flush, sleep awake, erase.
> > + *
> > + * ERASE_TIMEOUT_LIMIT bit of VENDOR_MISC_CTRL register allows
> > + * host controller to wait for busy state until the card is busy
> > + * without HW timeout.
> > + *
> > + * So, use infinite busy wait mode for operations that may take
> > + * more than maximum HW busy timeout of 11s otherwise use finite
> > + * busy wait mode.
> > + */
> > + val = sdhci_readl(host, SDHCI_TEGRA_VENDOR_MISC_CTRL);
> > + if (cmd && cmd->busy_timeout >= 11 * HZ)
> > + val |= SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT;
> > + else
> > + val &= ~SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT;
> > + sdhci_writel(host, val, SDHCI_TEGRA_VENDOR_MISC_CTRL);
> > +
> > + __sdhci_set_timeout(host, cmd);
>
> kernel build on arm and arm64 architecture failed on stable-rc 4.19
> (arm), 5.4 (arm64) and 5.5 (arm64)
>
> drivers/mmc/host/sdhci-tegra.c: In function 'tegra_sdhci_set_timeout':
> drivers/mmc/host/sdhci-tegra.c:1256:2: error: implicit declaration of
> function '__sdhci_set_timeout'; did you mean
> 'tegra_sdhci_set_timeout'? [-Werror=implicit-function-declaration]
> __sdhci_set_timeout(host, cmd);
> ^~~~~~~~~~~~~~~~~~~
> tegra_sdhci_set_timeout
>
> Full build log,
> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-5.5/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/83/consoleText
> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-5.4/DISTRO=lkft,MACHINE=juno,label=docker-lkft/158/consoleText
> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/511/consoleText
>
> - Naresh
Thanks for reporting! What a mess.
It turns out that the commit that was queued for stable that is
causing the above errors, also requires another commit.
The commit that was queued:
5e958e4aacf4 ("sdhci: tegra: Implement Tegra specific set_timeout callback")
The additional commit needed (which was added in v5.6-rc1):
7d76ed77cfbd ("mmc: sdhci: Refactor sdhci_set_timeout()")
However, the above commit needs a manual backport (quite trivial, but
still) for the relevant stable kernels, to allow it to solve the build
problems.
Greg, Sasha - I suggest you to drop the offending commit from the
stable kernels, for now. I think it's better to let Sowjanya deal with
the backports, then send them in small series instead.
Kind regards
Uffe
next prev parent reply other threads:[~2020-04-16 11:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 0:20 [PATCH v2 1/2] sdhci: tegra: Implement Tegra specific set_timeout callback Sowjanya Komatineni
2020-03-11 0:20 ` [PATCH v2 2/2] sdhci: tegra: Enable MMC_CAP_WAIT_WHILE_BUSY host capability Sowjanya Komatineni
2020-03-12 13:08 ` [PATCH v2 1/2] sdhci: tegra: Implement Tegra specific set_timeout callback Ulf Hansson
2020-03-12 15:28 ` Sowjanya Komatineni
2020-03-12 15:35 ` Ulf Hansson
2020-03-13 1:19 ` Sowjanya Komatineni
2020-04-15 17:55 ` Naresh Kamboju
2020-04-16 10:59 ` Ulf Hansson [this message]
2020-04-16 11:37 ` Greg Kroah-Hartman
2020-04-16 16:29 ` Sowjanya Komatineni
2020-04-16 19:38 ` Sowjanya Komatineni
2020-04-17 8:04 ` Ulf Hansson
2020-04-17 18:29 ` Sowjanya Komatineni
2020-03-11 8:54 Sowjanya Komatineni
2020-03-11 8:56 Sowjanya Komatineni
2020-03-11 15:47 Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpZEiqTdD6O-y6Sw7ifXF__MHAv0zKT=RFKs+Fmvr-K_Q@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=anrao@nvidia.com \
--cc=baolin.wang@linaro.org \
--cc=bradleybolen@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=sashal@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).