From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4018C49EA2 for ; Tue, 15 Jun 2021 15:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CDDC6157F for ; Tue, 15 Jun 2021 15:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231363AbhFOPId (ORCPT ); Tue, 15 Jun 2021 11:08:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhFOPIb (ORCPT ); Tue, 15 Jun 2021 11:08:31 -0400 Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15E53C0613A2 for ; Tue, 15 Jun 2021 08:06:26 -0700 (PDT) Received: by mail-ua1-x930.google.com with SMTP id n61so6776296uan.2 for ; Tue, 15 Jun 2021 08:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g6ccgATn5J7iu5AD+WjcCm3W6RvKZU4zwOSyY17Ugqo=; b=VMgwN6I5rM2ZzwlseZMckLT3Mq6mCu2sqjyLreObQwBJl2xO1JFJ3KrSGgtV8elyMX e33Mq0nMBfJo+VWoDsuWJ/OQhPo/6hCjkU3PUcv86c6bh3WsCwyTLW779KqqeJxNs2N1 bcVS5CG3eY+iSWhjr5uoTKFRAL2QvE41iULH9uhbTJI+33T5vZZQdjTN0T76I2ijXnJ3 mA9SHp+3dF2Htwd9o6p/2E8J7Tlv3NUNPxFdFaXQIvmPbcpjUvX5x/RXCgIdwJZFVe3v OMQwMaPWMBL4rOzueRuy7ZbtwoQTLkXvNrLjXq5sYiPDjhgVnSS8QzNVxcElkoRSH6Z+ mY3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g6ccgATn5J7iu5AD+WjcCm3W6RvKZU4zwOSyY17Ugqo=; b=lZUBLL//KPON3lqGDPAXWjMliNUxeg21rMzi8GFtkiwL9izyToaylg/AOzMhgMFOIb 4uyFqBMzt2caYV1pyX3Msd7Iixaear1eNeFeNGHbqDFlQnOw5qW5ZFKq5o1w/vjRq9ya cvquxFgRS7qf8mwetlouHB8uBFCDi7DEZ3/sVh/HMSuDsVav5bDnEusyM8yTFAEJ/wUr RSIQHwnAKqIR2PbVPG/oCHo9l8H80YNt7OTxDAXiRfhDosThBkyDz1IczwCdi1VELK07 A8TVq5Yp/DNQ9D78dzr/qZIzVSOjhTEcoTd1MVP6iBtYFkZmrrRydzw/Nqppt3M33jqm EtKA== X-Gm-Message-State: AOAM530R/ZMhRn1jEtFxWSuMuWvdf2pKq8lUiKMAoXESC5f8tCeJMAlv IAvqVKCaeX+WaXQXyol1/9naF7IqFFuX58DHwGylgg== X-Google-Smtp-Source: ABdhPJwifxZlIC2ycNIdNlntzCYwWlEJJuNQ0hwJz82zBzFvKR5y27inbr8Cfln1EGIPgiyx/G2yZ93oXa16qSAzWsc= X-Received: by 2002:ab0:4d49:: with SMTP id k9mr3219610uag.129.1623769585148; Tue, 15 Jun 2021 08:06:25 -0700 (PDT) MIME-Version: 1.0 References: <1622095949-2014-1-git-send-email-rnayak@codeaurora.org> <1622095949-2014-2-git-send-email-rnayak@codeaurora.org> In-Reply-To: <1622095949-2014-2-git-send-email-rnayak@codeaurora.org> From: Ulf Hansson Date: Tue, 15 Jun 2021 17:05:48 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: power: Introduce 'assigned-performance-states' property To: Rajendra Nayak Cc: Rob Herring , Bjorn Andersson , Viresh Kumar , Linux PM , DTML , Linux Kernel Mailing List , linux-arm-msm , Stephen Boyd , Roja Rani Yarubandi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 May 2021 at 08:13, Rajendra Nayak wrote: > > While most devices within power-domains which support performance states, > scale the performance state dynamically, some devices might want to > set a static/default performance state while the device is active. > These devices typically would also run off a fixed clock and not support > dynamically scaling the device's performance, also known as DVFS techniques. > Add a property 'assigned-performance-states' which client devices can > use to set this default performance state on their power-domains. > > Signed-off-by: Rajendra Nayak Rajendra, I think this is ready to be re-spinned on top of the latest changes for genpd that Rafael recently queued [1]. If you would prefer me to do it, then please let me know. Otherwise I will be awaiting a new version from you. Kind regards Uffe [1] https://lore.kernel.org/linux-pm/CAJZ5v0i0FD-F7tN=AJNEY5HVVTCNuciLT4hCqdoS5bgF5WdmaA@mail.gmail.com/ > --- > .../devicetree/bindings/power/power-domain.yaml | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml > index aed51e9..88cebf2 100644 > --- a/Documentation/devicetree/bindings/power/power-domain.yaml > +++ b/Documentation/devicetree/bindings/power/power-domain.yaml > @@ -66,6 +66,19 @@ properties: > by the given provider should be subdomains of the domain specified > by this binding. > > + assigned-performance-states: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + Some devices might need to configure their power domains in a default > + performance state while the device is active. These devices typically > + would also run off a fixed clock and not support dynamically scaling the > + device's performance, also known as DVFS techniques. The list of performance > + state values should correspond to the list of power domains specified as part > + of the power-domains property. Each cell corresponds to one power-domain. > + A value of 0 can be used for power-domains with no performance state > + requirement. In case the power-domains have OPP tables associated, the values > + here would typically match with one of the entries in the OPP table. > + > required: > - "#power-domain-cells" > > @@ -131,3 +144,40 @@ examples: > min-residency-us = <7000>; > }; > }; > + > + - | > + parent4: power-controller@12340000 { > + compatible = "foo,power-controller"; > + reg = <0x12340000 0x1000>; > + #power-domain-cells = <0>; > + }; > + > + parent5: power-controller@43210000 { > + compatible = "foo,power-controller"; > + reg = <0x43210000 0x1000>; > + #power-domain-cells = <0>; > + operating-points-v2 = <&power_opp_table>; > + > + power_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + power_opp_low: opp1 { > + opp-level = <16>; > + }; > + > + rpmpd_opp_ret: opp2 { > + opp-level = <64>; > + }; > + > + rpmpd_opp_svs: opp3 { > + opp-level = <256>; > + }; > + }; > + }; > + > + child4: consumer@12341000 { > + compatible = "foo,consumer"; > + reg = <0x12341000 0x1000>; > + power-domains = <&parent4>, <&parent5>; > + assigned-performance-states = <0>, <256>; > + }; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >